9488142782

Committed 12 Jun 2024 06:53PM UTC coverage: 31.905% (-0.03%) from 31.934%

Build # 9488142782

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9397 from ForumMagnum/master

[EA] Deploy some small fixes, LW stuff

Run Details

4816 of 39338 branches covered (12.24%)

Branch coverage included in aggregate %.

26 of 106 new or added lines in 17 files covered. (24.53%)

3 existing lines in 3 files now uncovered.

27991 of 63490 relevant lines covered (44.09%)

180.32 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

14.29

/packages/lesswrong/components/posts/PostsPreviewTooltip/PostsTooltip.tsx

import React, { ReactNode, useCallback } from "react";
import { Components, registerComponent } from "../../../lib/vulcan-lib";
import type { PopperPlacementType } from "@material-ui/core/Popper/Popper";
import { DialogueMessageInfo, PostsPreviewTooltip } from "./PostsPreviewTooltip";
import {
  DialogueMessagePreviewTooltip,
  PostsPreviewTooltipSingle,
  PostsPreviewTooltipSingleWithComment,
  TaggedPostTooltipSingle,
} from "./PostsPreviewTooltipSingle";

const PostsTooltip = ({
  post,
  postId,
  comment,
  commentId,
  tagRelId,
  dialogueMessageInfo,
  hash,
  postsList,
  inlineBlock=false,
  As,
  clickable,
  flip,
  placement,
  children,
  pageElementContext,
  pageElementSubContext,
  disabled,
  className,
}: {
  post?: PostsList | SunshinePostsList | null,
  postId?: string,
  comment?: CommentsList,
  commentId?: string,
  tagRelId?: string,
  dialogueMessageInfo?: DialogueMessageInfo,
  hash?: string | null,
  postsList?: boolean,
  inlineBlock?: boolean,
  As?: keyof JSX.IntrinsicElements,
  clickable?: boolean,
  flip?: boolean,
  placement?: PopperPlacementType,
  children?: ReactNode,
  pageElementContext?: string,
  pageElementSubContext?: string,
  //bypasses the component and just returns the children
  disabled?: boolean,
  className?: string,
}) => {
  const renderTitle = useCallback(() => {
    if (tagRelId) {
      return (
        <TaggedPostTooltipSingle tagRelId={tagRelId} />
      );
    }
    if (post) {
      return (
        <PostsPreviewTooltip
          post={post}
          postsList={postsList}
          comment={comment}
          hash={hash}
        />
      );
    }

    if (postId) {
      if (dialogueMessageInfo) {
        return <DialogueMessagePreviewTooltip postId={postId} dialogueMessageInfo={dialogueMessageInfo}/>
      }

      const actualCommentId = commentId ?? comment?._id;
      return actualCommentId
        ? (
          <PostsPreviewTooltipSingleWithComment
            postId={postId}
            commentId={actualCommentId}
          />
        )
        : (
          <PostsPreviewTooltipSingle
            postId={postId}
            postsList={postsList}
          />
        );
    }
    return null;
  }, [tagRelId, post, postId, postsList, comment, commentId, dialogueMessageInfo, hash]);

  if (disabled) {
    return <>
    {children}
    </>
  };

  const {HoverOver} = Components;
  return (
    <HoverOver
      title={renderTitle()}
      placement={placement}
      tooltip={false}
      hideOnTouchScreens
      inlineBlock={inlineBlock}
      As={As}
      clickable={clickable}
      flip={flip}
      analyticsProps={{
        pageElementContext,
        pageElementSubContext,
        postId: postId ?? post?._id,
      }}
      className={className}
    >
      {children}
    </HoverOver>
  );
}

const PostsTooltipComponent = registerComponent(
  "PostsTooltip",
  PostsTooltip,
);

declare global {
  interface ComponentTypes {
    PostsTooltip: typeof PostsTooltipComponent
  }
}

1	import React, { ReactNode, useCallback } from "react";	1✔
2	import { Components, registerComponent } from "../../../lib/vulcan-lib";	1✔
3	import type { PopperPlacementType } from "@material-ui/core/Popper/Popper";
4	import { DialogueMessageInfo, PostsPreviewTooltip } from "./PostsPreviewTooltip";	1✔
5	import {
6	DialogueMessagePreviewTooltip,
7	PostsPreviewTooltipSingle,
8	PostsPreviewTooltipSingleWithComment,
9	TaggedPostTooltipSingle,
10	} from "./PostsPreviewTooltipSingle";	1✔
11
12	const PostsTooltip = ({	1✔
13	post,
14	postId,
15	comment,
16	commentId,
17	tagRelId,
18	dialogueMessageInfo,
19	hash,
20	postsList,
21	inlineBlock=false,	×
22	As,
23	clickable,
24	flip,
25	placement,
26	children,
27	pageElementContext,
28	pageElementSubContext,
29	disabled,
30	className,
31	}: {
32	post?: PostsList \| SunshinePostsList \| null,
33	postId?: string,
34	comment?: CommentsList,
35	commentId?: string,
36	tagRelId?: string,
37	dialogueMessageInfo?: DialogueMessageInfo,
38	hash?: string \| null,
39	postsList?: boolean,
40	inlineBlock?: boolean,
41	As?: keyof JSX.IntrinsicElements,
42	clickable?: boolean,
43	flip?: boolean,
44	placement?: PopperPlacementType,
45	children?: ReactNode,
46	pageElementContext?: string,
47	pageElementSubContext?: string,
48	//bypasses the component and just returns the children
49	disabled?: boolean,
50	className?: string,
51	}) => {
52	const renderTitle = useCallback(() => {	×
53	if (tagRelId) {	×
54	return (	×
55	<TaggedPostTooltipSingle tagRelId={tagRelId} />
56	);
57	}
58	if (post) {	×
59	return (	×
60	<PostsPreviewTooltip
61	post={post}
62	postsList={postsList}
63	comment={comment}
64	hash={hash}
65	/>
66	);
67	}
68
69	if (postId) {	×
70	if (dialogueMessageInfo) {	×
71	return <DialogueMessagePreviewTooltip postId={postId} dialogueMessageInfo={dialogueMessageInfo}/>	×
72	}
73
74	const actualCommentId = commentId ?? comment?._id;	×
75	return actualCommentId	×
76	? (
77	<PostsPreviewTooltipSingleWithComment	×
78	postId={postId}
79	commentId={actualCommentId}
80	/>
81	)
82	: (
83	<PostsPreviewTooltipSingle
84	postId={postId}
85	postsList={postsList}
86	/>
87	);
88	}
89	return null;	×
90	}, [tagRelId, post, postId, postsList, comment, commentId, dialogueMessageInfo, hash]);
91
NEW 92	if (disabled) {	×
NEW 93	return <>	×
94	{children}
95	</>
96	};
97
98	const {HoverOver} = Components;	×
99	return (	×
100	<HoverOver
101	title={renderTitle()}
102	placement={placement}
103	tooltip={false}
104	hideOnTouchScreens
105	inlineBlock={inlineBlock}
106	As={As}
107	clickable={clickable}
108	flip={flip}
109	analyticsProps={{
110	pageElementContext,
111	pageElementSubContext,
112	postId: postId ?? post?._id,	×
113	}}
114	className={className}
115	>
116	{children}
117	</HoverOver>
118	);
119	}
120
121	const PostsTooltipComponent = registerComponent(	1✔
122	"PostsTooltip",
123	PostsTooltip,
124	);
125
126	declare global {
127	interface ComponentTypes {
128	PostsTooltip: typeof PostsTooltipComponent
129	}
130	}

ForumMagnum / ForumMagnum / 9488142782

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous