9415656689

Committed 07 Jun 2024 10:34AM UTC coverage: 31.934% (-0.009%) from 31.943%

Build # 9415656689

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9380 from ForumMagnum/master

[EA] deploy audio "play from heading" fixes

Run Details

4815 of 39271 branches covered (12.26%)

Branch coverage included in aggregate %.

7 of 45 new or added lines in 10 files covered. (15.56%)

3 existing lines in 2 files now uncovered.

27979 of 63422 relevant lines covered (44.12%)

180.49 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.67

/packages/lesswrong/server/resolvers/subscribedUsersFeedResolver.tsx

1	import { defineFeedResolver } from "../utils/feedUtil";	18✔
2	import { addGraphQLSchema } from "../vulcan-lib";	18✔
3	import { loadByIds } from "../../lib/loaders";	18✔
4	import { filterNonnull } from "../../lib/utils/typeGuardUtils";	18✔
5	import { accessFilterMultiple } from "../../lib/utils/schemaUtils";	18✔
6	import { unflattenComments, flattenCommentBranch } from "@/lib/utils/unflatten";	18✔
7	import keyBy from "lodash/keyBy";	18✔
8	import sortBy from "lodash/sortBy";	18✔
9	import filter from "lodash/fp/filter";	18✔
10	import type { PostAndCommentsResultRow } from "../repos/PostsRepo";
11
12	function ensureHasId<T extends DbObject>(record: Partial<T>): record is Partial<T> & HasIdType {
NEW 13	return !!record._id;	×
14	}
15
16	function getPostComments(postAndCommentsRow: PostAndCommentsResultRow, commentsById: Record<string, Partial<DbComment> & HasIdType>) {
NEW 17	return filterNonnull(postAndCommentsRow.fullCommentTreeIds?.map(commentId => commentsById[commentId]) ?? []);	×
18	}
19
20	/**
21	* Return the ids for comments which, for each separate branch in a given tree, are the most recent comment by a user you're subscribed to, in that branch.
22	* Each branch should have zero or one comment IDs returned.
23	*/
24	function getExpandedCommentIds(postAndCommentsRow: PostAndCommentsResultRow, commentsById: Record<string, Partial<DbComment> & HasIdType>) {
NEW 25	const expansionCandidateIds = new Set(postAndCommentsRow.commentIds);	×
NEW 26	const allPostComments = getPostComments(postAndCommentsRow, commentsById);	×
NEW 27	const commentsTree = unflattenComments(allPostComments);	×
28
NEW 29	const expandCommentIds: string[] = [];	×
30
NEW 31	for (let commentNode of commentsTree) {	×
32	// Get the entire "branch" of comments as a flattened list, sorted by most recent comments first
NEW 33	const commentBranch = sortBy(flattenCommentBranch(commentNode), 'postedAt').reverse();	×
NEW 34	const commentToExpand = commentBranch.find(({ _id }) => expansionCandidateIds.has(_id));	×
NEW 35	if (commentToExpand) {	×
NEW 36	expandCommentIds.push(commentToExpand._id);	×
37	}
38	}
39
NEW 40	return expandCommentIds;	×
41	}	18✔
42
43	addGraphQLSchema(`
44	type SubscribedPostAndComments {
45	_id: String!
46	post: Post!
47	comments: [Comment!]
48	expandCommentIds: [String!]
49	postIsFromSubscribedUser: Boolean!
50	}
51	`);	18✔
52
53	defineFeedResolver<Date>({
54	name: "SubscribedFeed",
55	cutoffTypeGraphQL: "Date",
56	args: "af: Boolean",
57	resultTypesGraphQL: `
58	postCommented: SubscribedPostAndComments
59	`,
60	resolver: async ({limit=20, cutoff, offset, args, context}: {	×
61	limit?: number, cutoff?: Date, offset?: number,
62	args: {af: boolean},
63	context: ResolverContext
64	}) => {
65	const currentUser = context.currentUser;	×
66	if (!currentUser) throw new Error("Must be logged in");	×
67
68	const postsAndCommentsAll = await context.repos.posts.getPostsAndCommentsFromSubscriptions(currentUser._id, 30);	×
69	const postsAndComments = postsAndCommentsAll.slice(offset, (offset??0)+limit);	×
70	const isLastPage = postsAndComments.length < limit;	×
NEW 71	const lastFeedItem = postsAndComments.at(-1);	×
NEW 72	const nextCutoff = isLastPage ? null : (lastFeedItem?.last_commented ?? lastFeedItem?.postedAt ?? null);	×
73
NEW 74	const postIds: string[] = filterNonnull(postsAndComments.map(row => row.postId));	×
NEW 75	const commentIds: string[] = filterNonnull(postsAndComments.flatMap(row => row.fullCommentTreeIds ?? []));	×
76
77	const [posts, comments] = await Promise.all([	×
78	loadByIds(context, "Posts", postIds)
NEW 79	.then(posts => accessFilterMultiple(currentUser, context.Posts, posts, context))	×
80	.then(filterNonnull)
81	.then(filter(ensureHasId)),
82	loadByIds(context, "Comments", commentIds)
NEW 83	.then(comments => accessFilterMultiple(currentUser, context.Comments, comments, context))	×
84	.then(filterNonnull)
85	.then(filter(ensureHasId)),
86	]);
87
NEW 88	const postsById = keyBy(posts, p=>p._id);	×
NEW 89	const commentsById = keyBy(comments, c=>c._id);	×
90
91	return {	×
92	cutoff: nextCutoff,
93	endOffset: (offset??0)+postsAndComments.length,	×
94	results: postsAndComments.map(postAndCommentsRow => {
NEW 95	const allPostComments = getPostComments(postAndCommentsRow, commentsById);	×
NEW 96	const expandCommentIds = getExpandedCommentIds(postAndCommentsRow, commentsById);	×
97
UNCOV 98	return {	×
99	type: "postCommented",
100	postCommented: {
101	_id: postAndCommentsRow.postId,
102	post: postsById[postAndCommentsRow.postId],
103	postIsFromSubscribedUser: !!postAndCommentsRow.subscribedPosts,
104	comments: allPostComments,
105	expandCommentIds
106	}
107	};
108	})
109	};
110	}
111	});

ForumMagnum / ForumMagnum / 9415656689

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous