d369ba79692f3a61843c9f85eef6af1be60080dc

Committed 05 Jun 2024 11:21AM UTC coverage: 52.64% (+0.01%) from 52.628%

Build # d369ba79692f3a61843c9f85eef6af1be60080dc

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #21335 from Yoast/20335-yoastwpseoshould_index_indexables-filter-doesnt-disable-indexables

Make the filter that disables indexable creation, cover also the creation when a post is created and updated

Run Details

7399 of 13455 branches covered (54.99%)

Branch coverage included in aggregate %.

73 of 78 new or added lines in 15 files covered. (93.59%)

841 existing lines in 1 file now uncovered.

28346 of 54449 relevant lines covered (52.06%)

61880.01 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.92

/src/repositories/indexable-hierarchy-repository.php

<?php

namespace Yoast\WP\SEO\Repositories;

use Yoast\WP\Lib\Model;
use Yoast\WP\Lib\ORM;
use Yoast\WP\SEO\Builders\Indexable_Hierarchy_Builder;
use Yoast\WP\SEO\Helpers\Indexable_Helper;
use Yoast\WP\SEO\Models\Indexable;

/**
 * Class Indexable_Hierarchy_Repository.
 */
class Indexable_Hierarchy_Repository {

        /**
         * Represents the indexable hierarchy builder.
         *
         * @var Indexable_Hierarchy_Builder
         */
        protected $builder;

        /**
         * Represents the indexable helper.
         *
         * @var Indexable_Helper
         */
        protected $indexable_helper;

        /**
         * Sets the hierarchy builder.
         *
         * @required
         *
         * @param Indexable_Hierarchy_Builder $builder The indexable hierarchy builder.
         *
         * @return void
         */
        public function set_builder( Indexable_Hierarchy_Builder $builder ) {
                $this->builder = $builder;
        }

        /**
         * Sets the indexable helper.
         *
         * @required
         *
         * @param Indexable_Helper $indexable_helper The indexable helper.
         *
         * @return void
         */
        public function set_helper( Indexable_Helper $indexable_helper ) {
                $this->indexable_helper = $indexable_helper;
        }

        /**
         * Removes all ancestors for an indexable.
         *
         * @param int $indexable_id The indexable id.
         *
         * @return bool Whether or not the indexables were successfully deleted.
         */
        public function clear_ancestors( $indexable_id ) {
                return $this->query()->where( 'indexable_id', $indexable_id )->delete_many();
        }

        /**
         * Adds an ancestor to an indexable.
         *
         * @param int $indexable_id The indexable id.
         * @param int $ancestor_id  The ancestor id.
         * @param int $depth        The depth.
         *
         * @return bool Whether or not the ancestor was added successfully.
         */
        public function add_ancestor( $indexable_id, $ancestor_id, $depth ) {
                if ( ! $this->indexable_helper->should_index_indexables() ) {
                        return false;
                }

                $hierarchy = $this->query()->create(
                        [
                                'indexable_id' => $indexable_id,
                                'ancestor_id'  => $ancestor_id,
                                'depth'        => $depth,
                                'blog_id'      => \get_current_blog_id(),
                        ]
                );

                return $hierarchy->save();
        }

        /**
         * Retrieves the ancestors. Create them when empty.
         *
         * @param Indexable $indexable The indexable to get the ancestors for.
         *
         * @return int[] The indexable id's of the ancestors in order of grandparent to child.
         */
        public function find_ancestors( Indexable $indexable ) {
                $ancestors = $this->query()
                        ->select( 'ancestor_id' )
                        ->where( 'indexable_id', $indexable->id )
                        ->order_by_desc( 'depth' )
                        ->find_array();

                if ( ! empty( $ancestors ) ) {
                        if ( \count( $ancestors ) === 1 && $ancestors[0]['ancestor_id'] === '0' ) {
                                return [];
                        }
                        return \wp_list_pluck( $ancestors, 'ancestor_id' );
                }

                $indexable = $this->builder->build( $indexable );

                return \wp_list_pluck( $indexable->ancestors, 'id' );
        }

        /**
         * Finds the children for a given indexable.
         *
         * @param Indexable $indexable The indexable to find the children for.
         *
         * @return array Array with indexable id's for the children.
         */
        public function find_children( Indexable $indexable ) {
                $children = $this->query()
                        ->select( 'indexable_id' )
                        ->where( 'ancestor_id', $indexable->id )
                        ->find_array();

                if ( empty( $children ) ) {
                        return [];
                }

                return \wp_list_pluck( $children, 'indexable_id' );
        }

        /**
         * Starts a query for this repository.
         *
         * @return ORM
         */
        public function query() {
                return Model::of_type( 'Indexable_Hierarchy' );
        }

        /**
         * Finds all the children by given ancestor id's.
         *
         * @param array $object_ids List of id's to get the children for.
         *
         * @return array List of indexable id's for the children.
         */
        public function find_children_by_ancestor_ids( array $object_ids ) {
                if ( empty( $object_ids ) ) {
                        return [];
                }

                $children = $this->query()
                        ->select( 'indexable_id' )
                        ->where_in( 'ancestor_id', $object_ids )
                        ->find_array();

                if ( empty( $children ) ) {
                        return [];
                }

                return \wp_list_pluck( $children, 'indexable_id' );
        }
}

1	<?php
2
3	namespace Yoast\WP\SEO\Repositories;
4
5	use Yoast\WP\Lib\Model;
6	use Yoast\WP\Lib\ORM;
7	use Yoast\WP\SEO\Builders\Indexable_Hierarchy_Builder;
8	use Yoast\WP\SEO\Helpers\Indexable_Helper;
9	use Yoast\WP\SEO\Models\Indexable;
10
11	/**
12	* Class Indexable_Hierarchy_Repository.
13	*/
14	class Indexable_Hierarchy_Repository {
15
16	/**
17	* Represents the indexable hierarchy builder.
18	*
19	* @var Indexable_Hierarchy_Builder
20	*/
21	protected $builder;
22
23	/**
24	* Represents the indexable helper.
25	*
26	* @var Indexable_Helper
27	*/
28	protected $indexable_helper;
29
30	/**
31	* Sets the hierarchy builder.
32	*
33	* @required
34	*
35	* @param Indexable_Hierarchy_Builder $builder The indexable hierarchy builder.
36	*
37	* @return void
38	*/
39	public function set_builder( Indexable_Hierarchy_Builder $builder ) {	2✔
40	$this->builder = $builder;	2✔
41	}	1✔
42
43	/**
44	* Sets the indexable helper.
45	*
46	* @required
47	*
48	* @param Indexable_Helper $indexable_helper The indexable helper.
49	*
50	* @return void
51	*/
52	public function set_helper( Indexable_Helper $indexable_helper ) {	2✔
53	$this->indexable_helper = $indexable_helper;	2✔
54	}	1✔
55
56	/**
57	* Removes all ancestors for an indexable.
58	*
59	* @param int $indexable_id The indexable id.
60	*
61	* @return bool Whether or not the indexables were successfully deleted.
62	*/
63	public function clear_ancestors( $indexable_id ) {	2✔
64	return $this->query()->where( 'indexable_id', $indexable_id )->delete_many();	2✔
65	}
66
67	/**
68	* Adds an ancestor to an indexable.
69	*
70	* @param int $indexable_id The indexable id.
71	* @param int $ancestor_id The ancestor id.
72	* @param int $depth The depth.
73	*
74	* @return bool Whether or not the ancestor was added successfully.
75	*/
76	public function add_ancestor( $indexable_id, $ancestor_id, $depth ) {	2✔
77	if ( ! $this->indexable_helper->should_index_indexables() ) {	2✔
NEW 78	return false;	×
79	}
80
81	$hierarchy = $this->query()->create(	2✔
82	[	1✔
83	'indexable_id' => $indexable_id,	2✔
84	'ancestor_id' => $ancestor_id,	2✔
85	'depth' => $depth,	2✔
86	'blog_id' => \get_current_blog_id(),	2✔
87	]	1✔
88	);	1✔
89
90	return $hierarchy->save();	2✔
91	}
92
93	/**
94	* Retrieves the ancestors. Create them when empty.
95	*
96	* @param Indexable $indexable The indexable to get the ancestors for.
97	*
98	* @return int[] The indexable id's of the ancestors in order of grandparent to child.
99	*/
100	public function find_ancestors( Indexable $indexable ) {	4✔
101	$ancestors = $this->query()	4✔
102	->select( 'ancestor_id' )	4✔
103	->where( 'indexable_id', $indexable->id )	4✔
104	->order_by_desc( 'depth' )	4✔
105	->find_array();	4✔
106
107	if ( ! empty( $ancestors ) ) {	4✔
108	if ( \count( $ancestors ) === 1 && $ancestors[0]['ancestor_id'] === '0' ) {	2✔
109	return [];	×
110	}
111	return \wp_list_pluck( $ancestors, 'ancestor_id' );	2✔
112	}
113
114	$indexable = $this->builder->build( $indexable );	2✔
115
116	return \wp_list_pluck( $indexable->ancestors, 'id' );	2✔
117	}
118
119	/**
120	* Finds the children for a given indexable.
121	*
122	* @param Indexable $indexable The indexable to find the children for.
123	*
124	* @return array Array with indexable id's for the children.
125	*/
126	public function find_children( Indexable $indexable ) {	4✔
127	$children = $this->query()	4✔
128	->select( 'indexable_id' )	4✔
129	->where( 'ancestor_id', $indexable->id )	4✔
130	->find_array();	4✔
131
132	if ( empty( $children ) ) {	4✔
133	return [];	2✔
134	}
135
136	return \wp_list_pluck( $children, 'indexable_id' );	2✔
137	}
138
139	/**
140	* Starts a query for this repository.
141	*
142	* @return ORM
143	*/
144	public function query() {	2✔
145	return Model::of_type( 'Indexable_Hierarchy' );	2✔
146	}
147
148	/**
149	* Finds all the children by given ancestor id's.
150	*
151	* @param array $object_ids List of id's to get the children for.
152	*
153	* @return array List of indexable id's for the children.
154	*/
155	public function find_children_by_ancestor_ids( array $object_ids ) {	×
156	if ( empty( $object_ids ) ) {	×
157	return [];	×
158	}
159
160	$children = $this->query()	×
161	->select( 'indexable_id' )	×
162	->where_in( 'ancestor_id', $object_ids )	×
163	->find_array();	×
164
165	if ( empty( $children ) ) {	×
166	return [];	×
167	}
168
169	return \wp_list_pluck( $children, 'indexable_id' );	×
170	}
171	}

Yoast / wordpress-seo / d369ba79692f3a61843c9f85eef6af1be60080dc

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous