9357544842

Committed 03 Jun 2024 09:31PM UTC coverage: 32.085% (+0.1%) from 31.94%

Build # 9357544842

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9361 from ForumMagnum/fix-lw-user-tooltip-positioning

fix positioning of lw user tooltip, and hide follow button for users who shouldn't have it

Run Details

3217 of 26288 branches covered (12.24%)

Branch coverage included in aggregate %.

2 of 4 new or added lines in 1 file covered. (50.0%)

3 existing lines in 2 files now uncovered.

18647 of 41855 relevant lines covered (44.55%)

273.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.0

/packages/lesswrong/server/callbacks/rateLimitCallbacks.ts

import moment from 'moment';
import { captureEvent } from '../../lib/analyticsEvents';
import Users from '../../lib/collections/users/collection';
import { getCollectionHooks } from '../mutationCallbacks';
import { rateLimitDateWhenUserNextAbleToComment, rateLimitDateWhenUserNextAbleToPost } from '../rateLimitUtils';

// Post rate limiting
getCollectionHooks("Posts").createValidate.add(async function PostsNewRateLimit (validationErrors, { newDocument: post, currentUser }) {
  if (!post.draft && !post.isEvent) {
    await enforcePostRateLimit(currentUser!);
  }
  return validationErrors;
});

getCollectionHooks("Posts").updateValidate.add(async function PostsUndraftRateLimit (validationErrors, { oldDocument, newDocument, currentUser }) {
  // Only undrafting is rate limited, not other edits
  if (oldDocument.draft && !newDocument.draft && !newDocument.isEvent) {
    await enforcePostRateLimit(currentUser!);
  }
  return validationErrors;
});

getCollectionHooks("Comments").createValidate.add(async function CommentsNewRateLimit (validationErrors, { newDocument: comment, currentUser, context }) {
  if (!currentUser) {
    throw new Error(`Can't comment while logged out.`);
  }
  await enforceCommentRateLimit({user: currentUser, comment, context});

  return validationErrors;
});

getCollectionHooks("Comments").createAsync.add(async ({document, context}: {
  document: DbComment
  context: ResolverContext
}) => {
  const user = await Users.findOne(document.userId)
  
  if (user) {
    const rateLimit = await rateLimitDateWhenUserNextAbleToComment(user, null, context)
    // if the user has created a comment that makes them hit the rate limit, record an event
    // (ignore the universal 8 sec rate limit)
    if (rateLimit && rateLimit.rateLimitType !== 'universal') {
      captureEvent("commentRateLimitHit", {
        rateLimitType: rateLimit.rateLimitType,
        userId: document.userId,
        commentId: document._id
      })
    }
  }
})

// Check whether the given user can post a post right now. If they can, does
// nothing; if they would exceed a rate limit, throws an exception.
async function enforcePostRateLimit (user: DbUser) {
  const rateLimit = await rateLimitDateWhenUserNextAbleToPost(user);
  if (rateLimit) {
    const {nextEligible} = rateLimit;
    if (nextEligible > new Date()) {
      // "fromNow" makes for a more human readable "how long till I can comment/post?".
      // moment.relativeTimeThreshold ensures that it doesn't appreviate unhelpfully to "now"
      moment.relativeTimeThreshold('ss', 0);
      throw new Error(`Rate limit: You cannot post for ${moment(nextEligible).fromNow()}, until ${nextEligible}`);
    }
  }
}

async function enforceCommentRateLimit({user, comment, context}: {
  user: DbUser,
  comment: DbComment,
  context: ResolverContext,
}) {
  const rateLimit = await rateLimitDateWhenUserNextAbleToComment(user, comment.postId, context);
  if (rateLimit) {
    const {nextEligible, rateLimitType:_} = rateLimit;
    if (nextEligible > new Date()) {
      // "fromNow" makes for a more human readable "how long till I can comment/post?".
      // moment.relativeTimeThreshold ensures that it doesn't appreviate unhelpfully to "now"
      moment.relativeTimeThreshold('ss', 0);
      throw new Error(`Rate limit: You cannot comment for ${moment(nextEligible).fromNow()} (until ${nextEligible})`);
    }
  }
}

1	import moment from 'moment';	18✔
2	import { captureEvent } from '../../lib/analyticsEvents';	18✔
3	import Users from '../../lib/collections/users/collection';	18✔
4	import { getCollectionHooks } from '../mutationCallbacks';	18✔
5	import { rateLimitDateWhenUserNextAbleToComment, rateLimitDateWhenUserNextAbleToPost } from '../rateLimitUtils';	18✔
6
7	// Post rate limiting
8	getCollectionHooks("Posts").createValidate.add(async function PostsNewRateLimit (validationErrors, { newDocument: post, currentUser }) {
9	if (!post.draft && !post.isEvent) {	×
10	await enforcePostRateLimit(currentUser!);	×
11	}
12	return validationErrors;	×
13	});	18✔
14
15	getCollectionHooks("Posts").updateValidate.add(async function PostsUndraftRateLimit (validationErrors, { oldDocument, newDocument, currentUser }) {
16	// Only undrafting is rate limited, not other edits
17	if (oldDocument.draft && !newDocument.draft && !newDocument.isEvent) {	10!
18	await enforcePostRateLimit(currentUser!);	×
19	}
20	return validationErrors;	10✔
21	});	18✔
22
23	getCollectionHooks("Comments").createValidate.add(async function CommentsNewRateLimit (validationErrors, { newDocument: comment, currentUser, context }) {
24	if (!currentUser) {	4!
25	throw new Error(`Can't comment while logged out.`);	×
26	}
27	await enforceCommentRateLimit({user: currentUser, comment, context});	4✔
28
29	return validationErrors;	3✔
30	});	18✔
31
32	getCollectionHooks("Comments").createAsync.add(async ({document, context}: {
33	document: DbComment
34	context: ResolverContext
35	}) => {
36	const user = await Users.findOne(document.userId)	22✔
37
38	if (user) {	22!
39	const rateLimit = await rateLimitDateWhenUserNextAbleToComment(user, null, context)	22✔
40	// if the user has created a comment that makes them hit the rate limit, record an event
41	// (ignore the universal 8 sec rate limit)
42	if (rateLimit && rateLimit.rateLimitType !== 'universal') {	22!
UNCOV 43	captureEvent("commentRateLimitHit", {	×
44	rateLimitType: rateLimit.rateLimitType,
45	userId: document.userId,
46	commentId: document._id
47	})
48	}
49	}
50	})
51
52	// Check whether the given user can post a post right now. If they can, does
53	// nothing; if they would exceed a rate limit, throws an exception.
54	async function enforcePostRateLimit (user: DbUser) {
55	const rateLimit = await rateLimitDateWhenUserNextAbleToPost(user);	×
56	if (rateLimit) {	×
57	const {nextEligible} = rateLimit;	×
58	if (nextEligible > new Date()) {	×
59	// "fromNow" makes for a more human readable "how long till I can comment/post?".
60	// moment.relativeTimeThreshold ensures that it doesn't appreviate unhelpfully to "now"
61	moment.relativeTimeThreshold('ss', 0);	×
62	throw new Error(`Rate limit: You cannot post for ${moment(nextEligible).fromNow()}, until ${nextEligible}`);	×
63	}
64	}
65	}
66
67	async function enforceCommentRateLimit({user, comment, context}: {
68	user: DbUser,
69	comment: DbComment,
70	context: ResolverContext,
71	}) {
72	const rateLimit = await rateLimitDateWhenUserNextAbleToComment(user, comment.postId, context);	4✔
73	if (rateLimit) {	4✔
74	const {nextEligible, rateLimitType:_} = rateLimit;	1✔
75	if (nextEligible > new Date()) {	1!
76	// "fromNow" makes for a more human readable "how long till I can comment/post?".
77	// moment.relativeTimeThreshold ensures that it doesn't appreviate unhelpfully to "now"
78	moment.relativeTimeThreshold('ss', 0);	1✔
79	throw new Error(`Rate limit: You cannot comment for ${moment(nextEligible).fromNow()} (until ${nextEligible})`);	1✔
80	}
81	}
82	}

ForumMagnum / ForumMagnum / 9357544842

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous