9357476274

Committed 03 Jun 2024 09:25PM UTC coverage: 31.887% (-0.05%) from 31.94%

Build # 9357476274

Build Type

Pull #9361

github

Committed by

b0b3rt

Commit Message

fix positioning of lw user tooltip, and hide follow button for users who shouldn't have it

Pull Request Pull Request #9361: fix positioning of lw user tooltip, and hide follow button for users who shouldn't have it

Run Details

4815 of 39318 branches covered (12.25%)

Branch coverage included in aggregate %.

2 of 4 new or added lines in 1 file covered. (50.0%)

2 existing lines in 1 file now uncovered.

27973 of 63509 relevant lines covered (44.05%)

180.24 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

32.14

/packages/lesswrong/components/users/LWUserTooltipContent.tsx

import React from 'react';
import { registerComponent, Components } from '../../lib/vulcan-lib';
import { truncate } from '../../lib/editor/ellipsize';
import { useMulti } from '@/lib/crud/withMulti';
import { userHasSubscribeTabFeed } from '@/lib/betas';
import { useCurrentUser } from '../common/withUser';

const styles = (theme: ThemeType) => ({
  root: {
    display: "flex",
    flexDirection: "column",
    width: 350,
    maxWidth: "unset",
    fontSize: 14,
    fontWeight: 450,
    lineHeight: "19.5px",
    padding: 16,
    color: theme.palette.text.primary,
    background: theme.palette.panelBackground.default,
    boxShadow: theme.palette.boxShadow.lwTagHoverOver,
    ...theme.typography.postStyle
  },
  header: {
    display: "flex",
    flexDirection: "column",
    maxWidth: 400,
  },
  name: {
    marginTop: 4,
    fontSize: "1.7rem",
    fontWeight: 400,
    color: theme.palette.grey["A400"],
  },
  metaRow: {
    marginTop: 8,
    display: "flex",
    flexDirection: "row",
    justifyContent: "space-between",
    alignItems: "center",
    color: theme.palette.grey["600"],
    fontSize: "1.1rem",
  },
  bio: {
    marginTop: 8,
    lineHeight: "1.3rem",
  },
  bioText: {
    fontSize: "1.1rem",
  },
  posts: {
    marginTop: 8,
    paddingTop: 8,
    borderTop: theme.palette.border.extraFaint,
    overflow: "hidden",
  },
});

export const LWUserTooltipContent = ({hideFollowButton=false, classes, user}: {
  hideFollowButton?: boolean,
  classes: ClassesType<typeof styles>,
  user: UsersMinimumInfo,
}) => {

  const { ContentStyles, TagSmallPostLink, FollowUserButton, UserMetaInfo, Loading } = Components

  const currentUser = useCurrentUser();

  const { htmlBio, displayName } = user;
  const truncatedBio = truncate(htmlBio, 500)

  const { loading, results } = useMulti({
    terms: {
      userId: user._id,
      view: "userPosts",
      sortedBy: "new"
    },
    collectionName: "Posts",
    fragmentName: 'PostsList',
    enableTotal: false,
    limit: 3,
  });


  return (
    <div className={classes.root}>
      <div className={classes.header}>
        <div className={classes.name}>{displayName}</div>
        <div className={classes.metaRow}>
          <UserMetaInfo user={user} />
          {!hideFollowButton && userHasSubscribeTabFeed(currentUser) && <FollowUserButton user={user} />}
        </div>
      </div>

      {truncatedBio && <ContentStyles className={classes.bio} contentType='postHighlight'>
        <div className={classes.bioText } dangerouslySetInnerHTML={{__html: truncatedBio}}/>
      </ContentStyles>}
      {results && <div className={classes.posts}>
        {results.map((post) => post &&
          <TagSmallPostLink
            key={post._id}
            post={post}
            hideAuthor
          />
        )}
      </div>}
      {loading && <Loading />}
    </div>
);
}

const LWUserTooltipContentComponent = registerComponent(
  'LWUserTooltipContent',
  LWUserTooltipContent,
  {styles},
);

declare global {
  interface ComponentTypes {
    LWUserTooltipContent: typeof LWUserTooltipContentComponent
  }
}

1	import React from 'react';	3✔
2	import { registerComponent, Components } from '../../lib/vulcan-lib';	1✔
3	import { truncate } from '../../lib/editor/ellipsize';	1✔
4	import { useMulti } from '@/lib/crud/withMulti';	1✔
5	import { userHasSubscribeTabFeed } from '@/lib/betas';	1✔
6	import { useCurrentUser } from '../common/withUser';	1✔
7
8	const styles = (theme: ThemeType) => ({	1✔
9	root: {
10	display: "flex",
11	flexDirection: "column",
12	width: 350,
13	maxWidth: "unset",
14	fontSize: 14,
15	fontWeight: 450,
16	lineHeight: "19.5px",
17	padding: 16,
18	color: theme.palette.text.primary,
19	background: theme.palette.panelBackground.default,
20	boxShadow: theme.palette.boxShadow.lwTagHoverOver,
21	...theme.typography.postStyle
22	},
23	header: {
24	display: "flex",
25	flexDirection: "column",
26	maxWidth: 400,
27	},
28	name: {
29	marginTop: 4,
30	fontSize: "1.7rem",
31	fontWeight: 400,
32	color: theme.palette.grey["A400"],
33	},
34	metaRow: {
35	marginTop: 8,
36	display: "flex",
37	flexDirection: "row",
38	justifyContent: "space-between",
39	alignItems: "center",
40	color: theme.palette.grey["600"],
41	fontSize: "1.1rem",
42	},
43	bio: {
44	marginTop: 8,
45	lineHeight: "1.3rem",
46	},
47	bioText: {
48	fontSize: "1.1rem",
49	},
50	posts: {
51	marginTop: 8,
52	paddingTop: 8,
53	borderTop: theme.palette.border.extraFaint,
54	overflow: "hidden",
55	},
56	});
57
58	export const LWUserTooltipContent = ({hideFollowButton=false, classes, user}: {	1!
59	hideFollowButton?: boolean,
60	classes: ClassesType<typeof styles>,
61	user: UsersMinimumInfo,
62	}) => {
63
64	const { ContentStyles, TagSmallPostLink, FollowUserButton, UserMetaInfo, Loading } = Components	×
65
NEW 66	const currentUser = useCurrentUser();	×
67
UNCOV 68	const { htmlBio, displayName } = user;	×
NEW 69	const truncatedBio = truncate(htmlBio, 500)	×
70
71	const { loading, results } = useMulti({	×
72	terms: {
73	userId: user._id,
74	view: "userPosts",
75	sortedBy: "new"
76	},
77	collectionName: "Posts",
78	fragmentName: 'PostsList',
79	enableTotal: false,
80	limit: 3,
81	});
82
83
UNCOV 84	return (	×
85	<div className={classes.root}>
86	<div className={classes.header}>
87	<div className={classes.name}>{displayName}</div>
88	<div className={classes.metaRow}>
89	<UserMetaInfo user={user} />
90	{!hideFollowButton && userHasSubscribeTabFeed(currentUser) && <FollowUserButton user={user} />}	×
91	</div>
92	</div>
93
94	{truncatedBio && <ContentStyles className={classes.bio} contentType='postHighlight'>	×
95	<div className={classes.bioText } dangerouslySetInnerHTML={{__html: truncatedBio}}/>
96	</ContentStyles>}
97	{results && <div className={classes.posts}>	×
98	{results.map((post) => post &&	×
99	<TagSmallPostLink
100	key={post._id}
101	post={post}
102	hideAuthor
103	/>
104	)}
105	</div>}
106	{loading && <Loading />}	×
107	</div>
108	);
109	}
110
111	const LWUserTooltipContentComponent = registerComponent(	1✔
112	'LWUserTooltipContent',
113	LWUserTooltipContent,
114	{styles},
115	);
116
117	declare global {
118	interface ComponentTypes {
119	LWUserTooltipContent: typeof LWUserTooltipContentComponent
120	}
121	}

ForumMagnum / ForumMagnum / 9357476274

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous