9288453438

Committed 29 May 2024 02:59PM UTC coverage: 92.853% (+0.002%) from 92.851%

Build # 9288453438

Build Type

push

github

Committed by

web-flow

Commit Message

Checksum `safeAddress` when unregistering notifications and propagate type (#1600)

Checksums the incoming `safeAddress` of `NotificationsController` and propagates the stricter (`0x${string}`) type throughout the project accordingly:

- Checksum the `safeAddress` in `NotificationsController['unregisterSafe']`
- Increase strictness of `safeAddress` in `NotificationsService['unregisterSafe']` and its implementation
- Increase strictness of `safeAddress` in `ITransactionApi['deleteSafeRegistration']` and its implementation
- Increase strictness of `safeAddress` in `INotificationsRepository['unregisterSafe']` and its implementation
- Update tests accordingly

Run Details

2018 of 2463 branches covered (81.93%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

7102 of 7359 relevant lines covered (96.51%)

326.09 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.0

/src/routes/transactions/entities/__tests__/human-description.builder.ts

import { Builder, IBuilder } from '@/__tests__/builder';
import {
  RichAddressFragment,
  RichTokenValueFragment,
  RichTextFragment,
  RichDecodedInfoFragment,
  RichFragmentType,
} from '@/routes/transactions/entities/human-description.entity';
import { faker } from '@faker-js/faker';

function richTokenValueFragmentBuilder(): IBuilder<RichTokenValueFragment> {
  return new Builder<RichTokenValueFragment>()
    .with('type', RichFragmentType.TokenValue)
    .with('value', faker.string.numeric())
    .with('symbol', faker.finance.currencySymbol())
    .with('logoUri', faker.image.avatar());
}

function richTextFragmentBuilder(): IBuilder<RichTextFragment> {
  return new Builder<RichTextFragment>()
    .with('type', RichFragmentType.Text)
    .with('value', faker.word.words());
}

function richAddressFragmentBuilder(): IBuilder<RichAddressFragment> {
  return new Builder<RichAddressFragment>()
    .with('type', RichFragmentType.Address)
    .with('value', faker.finance.ethereumAddress());
}

const humanDescriptionBuilders: Array<() => IBuilder<RichDecodedInfoFragment>> =
  [
    richTokenValueFragmentBuilder,
    richTextFragmentBuilder,
    richAddressFragmentBuilder,
  ];

export function buildHumanDescription(): RichDecodedInfoFragment[] {
  return Array.from({ length: faker.number.int({ min: 0, max: 6 }) }, () =>
    faker.helpers.arrayElement(humanDescriptionBuilders)().build(),
  );
}

1	import { Builder, IBuilder } from '@/__tests__/builder';	2✔
2	import {	2✔
3	RichAddressFragment,
4	RichTokenValueFragment,
5	RichTextFragment,
6	RichDecodedInfoFragment,
7	RichFragmentType,
8	} from '@/routes/transactions/entities/human-description.entity';
9	import { faker } from '@faker-js/faker';	2✔
10
11	function richTokenValueFragmentBuilder(): IBuilder<RichTokenValueFragment> {
UNCOV 12	return new Builder<RichTokenValueFragment>()	×
13	.with('type', RichFragmentType.TokenValue)
14	.with('value', faker.string.numeric())
15	.with('symbol', faker.finance.currencySymbol())
16	.with('logoUri', faker.image.avatar());
17	}
18
19	function richTextFragmentBuilder(): IBuilder<RichTextFragment> {
UNCOV 20	return new Builder<RichTextFragment>()	×
21	.with('type', RichFragmentType.Text)
22	.with('value', faker.word.words());
23	}
24
25	function richAddressFragmentBuilder(): IBuilder<RichAddressFragment> {
UNCOV 26	return new Builder<RichAddressFragment>()	×
27	.with('type', RichFragmentType.Address)
28	.with('value', faker.finance.ethereumAddress());
29	}
30
31	const humanDescriptionBuilders: Array<() => IBuilder<RichDecodedInfoFragment>> =
32	[	2✔
33	richTokenValueFragmentBuilder,
34	richTextFragmentBuilder,
35	richAddressFragmentBuilder,
36	];
37
38	export function buildHumanDescription(): RichDecodedInfoFragment[] {	2✔
39	return Array.from({ length: faker.number.int({ min: 0, max: 6 }) }, () =>	2✔
UNCOV 40	faker.helpers.arrayElement(humanDescriptionBuilders)().build(),	×
41	);
42	}

safe-global / safe-client-gateway / 9288453438

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous