9238549075

Committed 25 May 2024 09:46PM UTC coverage: 49.637% (+0.2%) from 49.45%

Build # 9238549075

Build Type

push

github

Committed by

bcomnes

Commit Message

Simplify get-admin-users query

Run Details

431 of 683 branches covered (63.1%)

Branch coverage included in aggregate %.

3 of 37 new or added lines in 2 files covered. (8.11%)

4 existing lines in 1 file now uncovered.

7162 of 14614 relevant lines covered (49.01%)

0.98 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.0

/packages/web/routes/api/admin/users/get-admin-users.js

import { fullSerializedAdminUserProps } from './admin-user-props.js'
import { userEditableUserProps } from '../../user/user-props.js'
import { getAdminUsersQuery } from './get-admin-users-query.js'
import { addMillisecond } from '../../bookmarks/addMillisecond.js'

export async function getAdminUsers (fastify, opts) {
  fastify.get(
    '/',
    {
      preHandler: fastify.auth([
        fastify.verifyJWT,
        fastify.verifyAdmin
      ], {
        relation: 'and'
      }),
      schema: {
        hide: true,
        querystring: {
          type: 'object',
          properties: {
            before: {
              type: 'string',
              format: 'date-time'
            },
            after: {
              type: 'string',
              format: 'date-time'
            },
            per_page: {
              type: 'integer',
              minimum: 1,
              maximum: 200,
              default: 20
            },
            username: userEditableUserProps.username
          },
          dependencies: {
            before: { allOf: [{ not: { required: ['after'] } }] },
            after: { allOf: [{ not: { required: ['before'] } }] }
          }
        },
        response: {
          200: {
            type: 'object',
            properties: {
              data: {
                type: 'array',
                items: {
                  type: 'object',
                  properties: fullSerializedAdminUserProps
                }
              },
              pagination: {
                type: 'object',
                properties: {
                  before: { type: 'string', format: 'date-time' },
                  after: { type: 'string', format: 'date-time' },
                  top: { type: 'boolean' },
                  bottom: { type: 'boolean' }
                }
              }
            }
          }
        }
      }
    },
    // GET users with administrative fields
    async function getAdminUsersHandler (request, reply) {
      return fastify.pg.transact(async client => {
        const {
          before,
          after,
          per_page: perPage,
          username
        } = request.query

        const adminUsersQuery = getAdminUsersQuery({
          before,
          after,
          perPage: perPage + 1,
          username
        })

        const results = await client.query(adminUsersQuery)

        const top = Boolean(
          (!before && !after) ||
          (after && results.rows.length <= perPage)
        )
        const bottom = Boolean(
          (before && results.rows.length <= perPage) ||
          (!before && !after && results.rows.length <= perPage)
        )

        if (results.rows.length > perPage) {
          if (after) {
            results.rows.shift()
          } else {
            results.rows.pop()
          }
        }

        const nextPage = bottom ? null : results.rows.at(-1)?.created_at
        const prevPage = top ? null : addMillisecond(results.rows[0]?.created_at)

        return {
          data: results.rows,
          pagination: {
            before: nextPage,
            after: prevPage,
            top,
            bottom
          }
        }
      })
    }
  )
}

1	import { fullSerializedAdminUserProps } from './admin-user-props.js'	2✔
2	import { userEditableUserProps } from '../../user/user-props.js'	2✔
3	import { getAdminUsersQuery } from './get-admin-users-query.js'	2✔
4	import { addMillisecond } from '../../bookmarks/addMillisecond.js'	2✔
5		2✔
6	export async function getAdminUsers (fastify, opts) {	2✔
7	fastify.get(	2✔
8	'/',	2✔
9	{	2✔
10	preHandler: fastify.auth([	2✔
11	fastify.verifyJWT,	2✔
12	fastify.verifyAdmin	2✔
13	], {	2✔
14	relation: 'and'	2✔
15	}),	2✔
16	schema: {	2✔
17	hide: true,	2✔
18	querystring: {	2✔
19	type: 'object',	2✔
20	properties: {	2✔
21	before: {	2✔
22	type: 'string',	2✔
23	format: 'date-time'	2✔
24	},	2✔
25	after: {	2✔
26	type: 'string',	2✔
27	format: 'date-time'	2✔
28	},	2✔
29	per_page: {	2✔
30	type: 'integer',	2✔
31	minimum: 1,	2✔
32	maximum: 200,	2✔
33	default: 20	2✔
34	},	2✔
35	username: userEditableUserProps.username	2✔
36	},	2✔
37	dependencies: {	2✔
38	before: { allOf: [{ not: { required: ['after'] } }] },	2✔
39	after: { allOf: [{ not: { required: ['before'] } }] }	2✔
40	}	2✔
41	},	2✔
42	response: {	2✔
43	200: {	2✔
44	type: 'object',	2✔
45	properties: {	2✔
46	data: {	2✔
47	type: 'array',	2✔
48	items: {	2✔
49	type: 'object',	2✔
50	properties: fullSerializedAdminUserProps	2✔
51	}	2✔
52	},	2✔
53	pagination: {	2✔
54	type: 'object',	2✔
55	properties: {	2✔
56	before: { type: 'string', format: 'date-time' },	2✔
57	after: { type: 'string', format: 'date-time' },	2✔
58	top: { type: 'boolean' },	2✔
59	bottom: { type: 'boolean' }	2✔
60	}	2✔
61	}	2✔
62	}	2✔
63	}	2✔
64	}	2✔
65	}	2✔
66	},	2✔
67	// GET users with administrative fields	2✔
68	async function getAdminUsersHandler (request, reply) {	2✔
69	return fastify.pg.transact(async client => {	×
70	const {	×
NEW 71	before,	×
72	after,	×
73	per_page: perPage,	×
74	username	×
75	} = request.query	×
76		×
77	const adminUsersQuery = getAdminUsersQuery({	×
78	before,	×
NEW 79	after,	×
NEW 80	perPage: perPage + 1,	×
81	username	×
82	})	×
83		×
84	const results = await client.query(adminUsersQuery)	×
85		×
NEW 86	const top = Boolean(	×
NEW 87	(!before && !after) \|\|	×
NEW 88	(after && results.rows.length <= perPage)	×
NEW 89	)	×
NEW 90	const bottom = Boolean(	×
NEW 91	(before && results.rows.length <= perPage) \|\|	×
NEW 92	(!before && !after && results.rows.length <= perPage)	×
NEW 93	)	×
NEW 94		×
NEW 95	if (results.rows.length > perPage) {	×
NEW 96	if (after) {	×
NEW 97	results.rows.shift()	×
NEW 98	} else {	×
NEW 99	results.rows.pop()	×
NEW 100	}	×
NEW 101	}	×
102		×
NEW 103	const nextPage = bottom ? null : results.rows.at(-1)?.created_at	×
NEW 104	const prevPage = top ? null : addMillisecond(results.rows[0]?.created_at)	×
105		×
106	return {	×
107	data: results.rows,	×
108	pagination: {	×
109	before: nextPage,	×
110	after: prevPage,	×
111	top,	×
112	bottom	×
113	}	×
114	}	×
115	})	×
116	}	×
117	)	2✔
118	}	2✔

hifiwi-fi / breadcrum.net / 9238549075

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous