9238384161

Committed 25 May 2024 09:38PM UTC coverage: 97.615% (-1.1%) from 98.716%

Build # 9238384161

Build Type

Pull #1742

github

Committed by

web-flow

Commit Message

Merge 9b9215592 into abad4f068

Pull Request Pull Request #1742: Replace forum options with account settings

Run Details

192 of 242 new or added lines in 20 files covered. (79.34%)

660 existing lines in 146 files now uncovered.

51658 of 52920 relevant lines covered (97.62%)

0.98 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.65

/misago/threads/api/threadendpoints/delete.py

from django.db import transaction
from rest_framework.response import Response

from ...moderation import threads as moderation
from ...permissions import allow_delete_thread
from ...serializers import DeleteThreadsSerializer


@transaction.atomic
def delete_thread(request, thread):
    allow_delete_thread(request.user_acl, thread)
    moderation.delete_thread(request, thread)
    return Response({})


def delete_bulk(request, viewmodel):
    serializer = DeleteThreadsSerializer(
        data={"threads": request.data},
        context={
            "request": request,
            "settings": request.settings,
            "viewmodel": viewmodel,
        },
    )

    if not serializer.is_valid():
        if "threads" in serializer.errors:
            errors = serializer.errors["threads"]
            if "details" in errors:
                return Response(hydrate_error_details(errors["details"]), status=400)
            # Fix for KeyError - errors[0]
            try:
                return Response({"detail": errors[0]}, status=403)
            except KeyError:
                return Response({"detail": list(errors.values())[0][0]}, status=403)

        errors = list(serializer.errors)[0][0]
        return Response({"detail": errors}, status=400)

    for thread in serializer.validated_data["threads"]:
        with transaction.atomic():
            delete_thread(request, thread)

    return Response([])


def hydrate_error_details(errors):
    for error in errors:
        error["thread"]["id"] = int(error["thread"]["id"])
    return errors

1	from django.db import transaction	1✔
2	from rest_framework.response import Response	1✔
3
4	from ...moderation import threads as moderation	1✔
5	from ...permissions import allow_delete_thread	1✔
6	from ...serializers import DeleteThreadsSerializer	1✔
7
8
9	@transaction.atomic	1✔
10	def delete_thread(request, thread):	1✔
11	allow_delete_thread(request.user_acl, thread)	1✔
12	moderation.delete_thread(request, thread)	1✔
13	return Response({})	1✔
14
15
16	def delete_bulk(request, viewmodel):	1✔
17	serializer = DeleteThreadsSerializer(	1✔
18	data={"threads": request.data},
19	context={
20	"request": request,
21	"settings": request.settings,
22	"viewmodel": viewmodel,
23	},
24	)
25
26	if not serializer.is_valid():	1✔
27	if "threads" in serializer.errors:	1✔
28	errors = serializer.errors["threads"]	1✔
29	if "details" in errors:	1✔
30	return Response(hydrate_error_details(errors["details"]), status=400)	1✔
31	# Fix for KeyError - errors[0]
32	try:	1✔
33	return Response({"detail": errors[0]}, status=403)	1✔
34	except KeyError:	1✔
35	return Response({"detail": list(errors.values())[0][0]}, status=403)	1✔
36
UNCOV 37	errors = list(serializer.errors)[0][0]	×
UNCOV 38	return Response({"detail": errors}, status=400)	×
39
UNCOV 40	for thread in serializer.validated_data["threads"]:	×
UNCOV 41	with transaction.atomic():	×
UNCOV 42	delete_thread(request, thread)	×
43
UNCOV 44	return Response([])	×
45
46
47	def hydrate_error_details(errors):	1✔
48	for error in errors:	1✔
49	error["thread"]["id"] = int(error["thread"]["id"])	1✔
50	return errors	1✔

rafalp / Misago / 9238384161

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous