9228097223

Committed 24 May 2024 06:03PM UTC coverage: 31.974% (+0.02%) from 31.956%

Build # 9228097223

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9317 from ForumMagnum/untangle-onstartup

Refactor `onStartup` to eliminate inverted control flow

Run Details

4798 of 39185 branches covered (12.24%)

Branch coverage included in aggregate %.

64 of 144 new or added lines in 14 files covered. (44.44%)

4 existing lines in 4 files now uncovered.

27959 of 63265 relevant lines covered (44.19%)

180.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/packages/lesswrong/client/start.tsx

import React from 'react';
import AppGenerator from './AppGenerator';

import { createApolloClient } from './apolloClient';
import { fmCrosspostBaseUrlSetting } from "../lib/instanceSettings";
import { populateComponentsAppDebug } from '../lib/vulcan-lib';
import { initServerSentEvents } from "./serverSentEventsClient";
import { hydrateRoot } from 'react-dom/client';

export function hydrateClient() {
  populateComponentsAppDebug();
  initServerSentEvents();
  const apolloClient = createApolloClient();
  apolloClient.disableNetworkFetches = true;
  const foreignApolloClient = createApolloClient(fmCrosspostBaseUrlSetting.get() ?? "/");
  foreignApolloClient.disableNetworkFetches = true;

  // Create the root element, if it doesn't already exist.
  if (!document.getElementById('react-app')) {
    const rootElement = document.createElement('div');
    rootElement.id = 'react-app';
    document.body.appendChild(rootElement);
  }

  const Main = () => (
    <AppGenerator
      apolloClient={apolloClient}
      foreignApolloClient={foreignApolloClient}
      abTestGroupsUsed={{}}
      themeOptions={window.themeOptions}
      ssrMetadata={window.ssrMetadata}
    />
  );

  const root = hydrateRoot(
    document.getElementById('react-app')!,
    <Main />,
  );
  setTimeout(() => {
    apolloClient.disableNetworkFetches = false;
    foreignApolloClient.disableNetworkFetches = false;
  });
};

1	import React from 'react';	×
2	import AppGenerator from './AppGenerator';	×
3
UNCOV 4	import { createApolloClient } from './apolloClient';	×
5	import { fmCrosspostBaseUrlSetting } from "../lib/instanceSettings";	×
6	import { populateComponentsAppDebug } from '../lib/vulcan-lib';	×
7	import { initServerSentEvents } from "./serverSentEventsClient";	×
8	import { hydrateRoot } from 'react-dom/client';	×
9
10	export function hydrateClient() {
11	populateComponentsAppDebug();	×
12	initServerSentEvents();	×
13	const apolloClient = createApolloClient();	×
14	apolloClient.disableNetworkFetches = true;	×
15	const foreignApolloClient = createApolloClient(fmCrosspostBaseUrlSetting.get() ?? "/");	×
16	foreignApolloClient.disableNetworkFetches = true;	×
17
18	// Create the root element, if it doesn't already exist.
19	if (!document.getElementById('react-app')) {	×
20	const rootElement = document.createElement('div');	×
21	rootElement.id = 'react-app';	×
22	document.body.appendChild(rootElement);	×
23	}
24
25	const Main = () => (	×
26	<AppGenerator	×
27	apolloClient={apolloClient}
28	foreignApolloClient={foreignApolloClient}
29	abTestGroupsUsed={{}}
30	themeOptions={window.themeOptions}
31	ssrMetadata={window.ssrMetadata}
32	/>
33	);
34
35	const root = hydrateRoot(	×
36	document.getElementById('react-app')!,
37	<Main />,
38	);
39	setTimeout(() => {	×
40	apolloClient.disableNetworkFetches = false;	×
41	foreignApolloClient.disableNetworkFetches = false;	×
42	});
43	};

ForumMagnum / ForumMagnum / 9228097223

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous