9214939382

Committed 23 May 2024 09:12PM UTC coverage: 31.908% (-0.02%) from 31.924%

Build # 9214939382

Build Type

Pull #9289

github

Committed by

darkruby501

Commit Message

fix test

Pull Request Pull Request #9289: Subscribed tab feed improvements 20240514

Run Details

4799 of 39195 branches covered (12.24%)

Branch coverage included in aggregate %.

60 of 141 new or added lines in 14 files covered. (42.55%)

1 existing line in 1 file now uncovered.

27914 of 63328 relevant lines covered (44.08%)

180.11 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

26.47

/packages/lesswrong/components/dropdowns/NotifyMeToggleDropdownItem.tsx

import React, { useCallback } from "react";
import { Components, registerComponent } from "../../lib/vulcan-lib";
import { NotifyMeDocument, useNotifyMe } from "../hooks/useNotifyMe";
import { useOptimisticToggle } from "../hooks/useOptimisticToggle";
import type { SubscriptionType } from "../../lib/collections/subscriptions/schema";
import Checkbox from "@material-ui/core/Checkbox";

type NotifyMeToggleDropdownItemInternalProps = {
  document: NotifyMeDocument,
  title: string,
  enabled?: boolean,
  subscriptionType: SubscriptionType,
  useCheckboxIcon?: boolean,
  classes: ClassesType,
}

type NotifyMeToggleDropdownItemProps = {
  document?: NotifyMeDocument | null,
} & Omit<NotifyMeToggleDropdownItemInternalProps, "document">;

export type NotifyMeToggleDropdownItemPropsExternal = Omit<NotifyMeToggleDropdownItemProps, "classes">;


const styles = (_theme: ThemeType) => ({
  toggle: {
    marginLeft: 12,
  },
  menuItemCheckbox: {
    paddingRight: 8
  }
});

export const NotifyMeToggleDropdownItemInternal = ({
  document,
  title,
  subscriptionType,
  useCheckboxIcon,
  classes,
}: NotifyMeToggleDropdownItemInternalProps) => {
  const {isSubscribed, onSubscribe, disabled} = useNotifyMe({
    document,
    overrideSubscriptionType: subscriptionType,
    hideFlashes: true,
  });
  const [subscribed, toggleSubscribed] = useOptimisticToggle(
    isSubscribed ?? false,
    onSubscribe ?? (() => {}),
  );

  const {DropdownItem, ToggleSwitch} = Components;

  const afterIcon = useCallback(
    () => {
      if (useCheckboxIcon) {
        return <Checkbox checked={subscribed} />
      } 

      return <ToggleSwitch value={subscribed} className={classes.toggle} smallVersion />
    },
    [subscribed, useCheckboxIcon, ToggleSwitch, classes.toggle],
  );

  return (
    <DropdownItem
      title={title}
      onClick={toggleSubscribed}
      afterIcon={afterIcon}
      disabled={disabled}
      menuItemClassName={useCheckboxIcon ? classes.menuItemCheckbox : undefined}
    />
  );
}

export const NotifyMeToggleDropdownItem = (
  props: NotifyMeToggleDropdownItemProps,
) => {
  if (!(props.enabled ?? true) || !props.document) {
    return null;
  }
  return (
    <NotifyMeToggleDropdownItemInternal
      {...props as NotifyMeToggleDropdownItemInternalProps}
    />
  );
}

const NotifyMeToggleDropdownItemComponent = registerComponent(
  "NotifyMeToggleDropdownItem",
  NotifyMeToggleDropdownItem,
  {styles},
);

declare global {
  interface ComponentTypes {
    NotifyMeToggleDropdownItem: typeof NotifyMeToggleDropdownItemComponent
  }
}

1	import React, { useCallback } from "react";	3✔
2	import { Components, registerComponent } from "../../lib/vulcan-lib";	1✔
3	import { NotifyMeDocument, useNotifyMe } from "../hooks/useNotifyMe";	1✔
4	import { useOptimisticToggle } from "../hooks/useOptimisticToggle";	1✔
5	import type { SubscriptionType } from "../../lib/collections/subscriptions/schema";
6	import Checkbox from "@material-ui/core/Checkbox";	1✔
7
8	type NotifyMeToggleDropdownItemInternalProps = {
9	document: NotifyMeDocument,
10	title: string,
11	enabled?: boolean,
12	subscriptionType: SubscriptionType,
13	useCheckboxIcon?: boolean,
14	classes: ClassesType,
15	}
16
17	type NotifyMeToggleDropdownItemProps = {
18	document?: NotifyMeDocument \| null,
19	} & Omit<NotifyMeToggleDropdownItemInternalProps, "document">;
20
21	export type NotifyMeToggleDropdownItemPropsExternal = Omit<NotifyMeToggleDropdownItemProps, "classes">;
22
23
24	const styles = (_theme: ThemeType) => ({	1✔
25	toggle: {
26	marginLeft: 12,
27	},
28	menuItemCheckbox: {
29	paddingRight: 8
30	}
31	});
32
33	export const NotifyMeToggleDropdownItemInternal = ({	1✔
34	document,
35	title,
36	subscriptionType,
37	useCheckboxIcon,
38	classes,
39	}: NotifyMeToggleDropdownItemInternalProps) => {
NEW 40	const {isSubscribed, onSubscribe, disabled} = useNotifyMe({	×
41	document,
42	overrideSubscriptionType: subscriptionType,
43	hideFlashes: true,
44	});
45	const [subscribed, toggleSubscribed] = useOptimisticToggle(	×
46	isSubscribed ?? false,	×
47	onSubscribe ?? (() => {}),	×
48	);
49
50	const {DropdownItem, ToggleSwitch} = Components;	×
51
52	const afterIcon = useCallback(	×
53	() => {
NEW 54	if (useCheckboxIcon) {	×
NEW 55	return <Checkbox checked={subscribed} />	×
56	}
57
NEW 58	return <ToggleSwitch value={subscribed} className={classes.toggle} smallVersion />	×
59	},
60	[subscribed, useCheckboxIcon, ToggleSwitch, classes.toggle],
61	);
62
63	return (	×
64	<DropdownItem
65	title={title}
66	onClick={toggleSubscribed}
67	afterIcon={afterIcon}
68	disabled={disabled}
69	menuItemClassName={useCheckboxIcon ? classes.menuItemCheckbox : undefined}	×
70	/>
71	);
72	}
73
74	export const NotifyMeToggleDropdownItem = (	1✔
75	props: NotifyMeToggleDropdownItemProps,
76	) => {
77	if (!(props.enabled ?? true) \|\| !props.document) {	×
78	return null;	×
79	}
80	return (	×
81	<NotifyMeToggleDropdownItemInternal
82	{...props as NotifyMeToggleDropdownItemInternalProps}
83	/>
84	);
85	}
86
87	const NotifyMeToggleDropdownItemComponent = registerComponent(	1✔
88	"NotifyMeToggleDropdownItem",
89	NotifyMeToggleDropdownItem,
90	{styles},
91	);
92
93	declare global {
94	interface ComponentTypes {
95	NotifyMeToggleDropdownItem: typeof NotifyMeToggleDropdownItemComponent
96	}
97	}

ForumMagnum / ForumMagnum / 9214939382

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous