9133282755

Committed 17 May 2024 07:27PM UTC coverage: 31.915% (-0.07%) from 31.986%

Build # 9133282755

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9303 from ForumMagnum/master

Merge master into LW Deploy

Run Details

4793 of 39041 branches covered (12.28%)

Branch coverage included in aggregate %.

51 of 140 new or added lines in 23 files covered. (36.43%)

12 existing lines in 8 files now uncovered.

27814 of 63127 relevant lines covered (44.06%)

180.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/packages/lesswrong/server/repos/ClientIdsRepo.ts

import AbstractRepo from "./AbstractRepo";
import { recordPerfMetrics } from "./perfMetricWrapper";
import { ClientIds } from "../../lib/collections/clientIds/collection";
import { randomId } from "../../lib/random";

class ClientIdsRepo extends AbstractRepo<"ClientIds"> {
  constructor() {
    super(ClientIds);
  }

  async ensureClientId({ clientId, firstSeenReferrer, firstSeenLandingPage }: { clientId: string; firstSeenReferrer: string | null; firstSeenLandingPage: string; }): Promise<void> {
    // await this.none(`
    //   INSERT INTO "ClientIds" ("_id", "clientId", "firstSeenReferrer", "firstSeenLandingPage")
    //   VALUES ($1, $2, $3, $4)
    //   ON CONFLICT ("clientId") DO NOTHING;
    // `, [randomId(), clientId, firstSeenReferrer, firstSeenLandingPage]);

    // TODO Reinstate this more standard INSERT ... ON CONFLICT query above for ensuring only one instance of the
    // client id is stored, both queries do the same thing. The change in https://github.com/ForumMagnum/ForumMagnum/pull/9296
    // resulted in the unique index being on COALESCE("clientId", '') rather than "clientId" itself, which broke the
    // ON CONFLICT clause, this is just a quirk of the query builder and can be fixed.
    await this.none(`
      INSERT INTO "ClientIds" ("_id", "clientId", "firstSeenReferrer", "firstSeenLandingPage")
      SELECT $1, $2, $3, $4
      WHERE NOT EXISTS (
        SELECT 1 FROM "ClientIds"
        WHERE "clientId" = $2
      );
    `, [randomId(), clientId, firstSeenReferrer, firstSeenLandingPage]);
  }
}

recordPerfMetrics(ClientIdsRepo);

export default ClientIdsRepo;

1	import AbstractRepo from "./AbstractRepo";	1,712✔
2	import { recordPerfMetrics } from "./perfMetricWrapper";	19✔
3	import { ClientIds } from "../../lib/collections/clientIds/collection";	19✔
4	import { randomId } from "../../lib/random";	19✔
5
6	class ClientIdsRepo extends AbstractRepo<"ClientIds"> {
7	constructor() {
8	super(ClientIds);	1,655✔
9	}
10
11	async ensureClientId({ clientId, firstSeenReferrer, firstSeenLandingPage }: { clientId: string; firstSeenReferrer: string \| null; firstSeenLandingPage: string; }): Promise<void> {
12	// await this.none(`
13	// INSERT INTO "ClientIds" ("_id", "clientId", "firstSeenReferrer", "firstSeenLandingPage")
14	// VALUES ($1, $2, $3, $4)
15	// ON CONFLICT ("clientId") DO NOTHING;
16	// `, [randomId(), clientId, firstSeenReferrer, firstSeenLandingPage]);
17
18	// TODO Reinstate this more standard INSERT ... ON CONFLICT query above for ensuring only one instance of the
19	// client id is stored, both queries do the same thing. The change in https://github.com/ForumMagnum/ForumMagnum/pull/9296
20	// resulted in the unique index being on COALESCE("clientId", '') rather than "clientId" itself, which broke the
21	// ON CONFLICT clause, this is just a quirk of the query builder and can be fixed.
NEW 22	await this.none(`	×
23	INSERT INTO "ClientIds" ("_id", "clientId", "firstSeenReferrer", "firstSeenLandingPage")
24	SELECT $1, $2, $3, $4
25	WHERE NOT EXISTS (
26	SELECT 1 FROM "ClientIds"
27	WHERE "clientId" = $2
28	);
29	`, [randomId(), clientId, firstSeenReferrer, firstSeenLandingPage]);
30	}
31	}	19✔
32
33	recordPerfMetrics(ClientIdsRepo);
34
35	export default ClientIdsRepo;	19✔

ForumMagnum / ForumMagnum / 9133282755

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous