9121438090

Committed 17 May 2024 01:17AM UTC coverage: 31.845% (-0.09%) from 31.931%

Build # 9121438090

Build Type

Pull #9289

github

Committed by

b0b3rt

Commit Message

fix alternating background colors and start on header ratios

Pull Request Pull Request #9289: Subscribed tab feed improvements 20240514

Run Details

4788 of 39226 branches covered (12.21%)

Branch coverage included in aggregate %.

43 of 99 new or added lines in 12 files covered. (43.43%)

1 existing line in 1 file now uncovered.

27867 of 63317 relevant lines covered (44.01%)

179.2 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

6.98

/packages/lesswrong/lib/subscriptionUtil.ts

import { SubscriptionType, subscriptionTypes } from './collections/subscriptions/schema';
import * as _ from 'underscore';
import { getConfirmedCoauthorIds } from './collections/posts/helpers';

export function userIsDefaultSubscribed({user, subscriptionType, collectionName, document}: {
  user: DbUser|UsersCurrent|null,
  subscriptionType: SubscriptionType,
  collectionName: CollectionNameString,
  document: any,
}): boolean
{
  if (!user) return false;
  
  switch(subscriptionType)
  {
    case subscriptionTypes.newComments:
      return user.auto_subscribe_to_my_posts && document.userId===user._id;
    case subscriptionTypes.newPosts:
      return false;
    case subscriptionTypes.newUserComments:
      return false; 
    case subscriptionTypes.newRelatedQuestions:
      // TODO
      return false;
    case subscriptionTypes.newEvents:
      return _.some(document.organizers, organizerId=>organizerId===user._id)
        && user.autoSubscribeAsOrganizer;
    case subscriptionTypes.newReplies:
      return user.auto_subscribe_to_my_comments && document.userId===user._id;
    case subscriptionTypes.newTagPosts:
      return false
    case subscriptionTypes.newSequencePosts:
      return false
    case subscriptionTypes.newShortform:
      return false;
    case subscriptionTypes.newDebateComments:
      return false;
    case subscriptionTypes.newPublishedDialogueMessages:
      return false;
    case subscriptionTypes.newDialogueMessages:
      const authorIds = [document.userId, ...getConfirmedCoauthorIds(document)];
      return authorIds.includes(user._id);
    case subscriptionTypes.newActivityForFeed:
      return false;
    default:
      //eslint-disable-next-line no-console
      console.error("Unrecognized subscription type: "+subscriptionType);
      return false;
  }
}

1	import { SubscriptionType, subscriptionTypes } from './collections/subscriptions/schema';	3✔
2	import * as _ from 'underscore';	1✔
3	import { getConfirmedCoauthorIds } from './collections/posts/helpers';	1✔
4
5	export function userIsDefaultSubscribed({user, subscriptionType, collectionName, document}: {
6	user: DbUser\|UsersCurrent\|null,
7	subscriptionType: SubscriptionType,
8	collectionName: CollectionNameString,
9	document: any,
10	}): boolean
11	{
12	if (!user) return false;	×
13
14	switch(subscriptionType)	×
15	{
16	case subscriptionTypes.newComments:
17	return user.auto_subscribe_to_my_posts && document.userId===user._id;	×
18	case subscriptionTypes.newPosts:
19	return false;	×
20	case subscriptionTypes.newUserComments:
21	return false;	×
22	case subscriptionTypes.newRelatedQuestions:
23	// TODO
24	return false;	×
25	case subscriptionTypes.newEvents:
26	return _.some(document.organizers, organizerId=>organizerId===user._id)	×
27	&& user.autoSubscribeAsOrganizer;
28	case subscriptionTypes.newReplies:
29	return user.auto_subscribe_to_my_comments && document.userId===user._id;	×
30	case subscriptionTypes.newTagPosts:
31	return false	×
32	case subscriptionTypes.newSequencePosts:
33	return false	×
34	case subscriptionTypes.newShortform:
35	return false;	×
36	case subscriptionTypes.newDebateComments:
37	return false;	×
38	case subscriptionTypes.newPublishedDialogueMessages:
39	return false;	×
40	case subscriptionTypes.newDialogueMessages:
41	const authorIds = [document.userId, ...getConfirmedCoauthorIds(document)];	×
42	return authorIds.includes(user._id);	×
43	case subscriptionTypes.newActivityForFeed:
NEW 44	return false;	×
45	default:
46	//eslint-disable-next-line no-console
47	console.error("Unrecognized subscription type: "+subscriptionType);	×
48	return false;	×
49	}
50	}

ForumMagnum / ForumMagnum / 9121438090

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous