9087042847

Committed 14 May 2024 10:29PM UTC coverage: 31.847% (-0.05%) from 31.901%

Build # 9087042847

Build Type

Pull #9272

github

Committed by

jimrandomh

Commit Message

Lint

Pull Request Pull Request #9272: Client-side JS performance optimizations

Run Details

4764 of 39078 branches covered (12.19%)

Branch coverage included in aggregate %.

11 of 32 new or added lines in 7 files covered. (34.38%)

2 existing lines in 2 files now uncovered.

27778 of 63105 relevant lines covered (44.02%)

177.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

42.86

/packages/lesswrong/components/common/LWHome.tsx

import { Components, registerComponent } from '../../lib/vulcan-lib';
import React, { useEffect } from 'react';
import { AnalyticsContext } from "../../lib/analyticsEvents";
import { getReviewPhase, reviewIsActive, REVIEW_YEAR } from '../../lib/reviewUtils';
import { showReviewOnFrontPageIfActive } from '../../lib/publicSettings';
import { useCookiesWithConsent } from '../hooks/useCookiesWithConsent';
import { LAST_VISITED_FRONTPAGE_COOKIE } from '../../lib/cookies/cookies';
import moment from 'moment';
import { visitorGetsDynamicFrontpage } from '../../lib/betas';

const LWHome = () => {
  const { DismissibleSpotlightItem, RecentDiscussionFeed, AnalyticsInViewTracker, FrontpageReviewWidget, 
    SingleColumnSection, FrontpageBestOfLWWidget, EAPopularCommentsSection, QuickTakesSection, LWHomePosts } = Components

  return (
      <AnalyticsContext pageContext="homePage">
        <React.Fragment>
          <UpdateLastVisitCookie />

          {reviewIsActive() && getReviewPhase() === "RESULTS" && <SingleColumnSection>
            <FrontpageBestOfLWWidget reviewYear={REVIEW_YEAR}/>
          </SingleColumnSection>}
        
          {reviewIsActive() && getReviewPhase() !== "RESULTS" && showReviewOnFrontPageIfActive.get() && <SingleColumnSection>
            <FrontpageReviewWidget reviewYear={REVIEW_YEAR}/>
          </SingleColumnSection>}
          
          <AnalyticsInViewTracker
            eventProps={{inViewType: "homePosts"}}
            observerProps={{threshold:[0, 0.5, 1]}}
          >
            <LWHomePosts>
              <QuickTakesSection />
    
              <EAPopularCommentsSection />
    
              <RecentDiscussionFeed
                af={false}
                commentsLimit={4}
                maxAgeHours={18}
              />
            </LWHomePosts>
          </AnalyticsInViewTracker>
        </React.Fragment>
      </AnalyticsContext>
  )
}

const UpdateLastVisitCookie = () => {
  const [_, setCookie] = useCookiesWithConsent([LAST_VISITED_FRONTPAGE_COOKIE]);

  useEffect(() => {
    if (visitorGetsDynamicFrontpage(null)) {
      setCookie(LAST_VISITED_FRONTPAGE_COOKIE, new Date().toISOString(), { path: "/", expires: moment().add(1, 'year').toDate() });
    }
  }, [setCookie])
  
  return <></>
}

const LWHomeComponent = registerComponent('LWHome', LWHome);

declare global {
  interface ComponentTypes {
    LWHome: typeof LWHomeComponent
  }
}

1	import { Components, registerComponent } from '../../lib/vulcan-lib';	1✔
2	import React, { useEffect } from 'react';	1✔
3	import { AnalyticsContext } from "../../lib/analyticsEvents";	1✔
4	import { getReviewPhase, reviewIsActive, REVIEW_YEAR } from '../../lib/reviewUtils';	1✔
5	import { showReviewOnFrontPageIfActive } from '../../lib/publicSettings';	1✔
6	import { useCookiesWithConsent } from '../hooks/useCookiesWithConsent';	1✔
7	import { LAST_VISITED_FRONTPAGE_COOKIE } from '../../lib/cookies/cookies';	1✔
8	import moment from 'moment';	1✔
9	import { visitorGetsDynamicFrontpage } from '../../lib/betas';	1✔
10
11	const LWHome = () => {	1✔
12	const { DismissibleSpotlightItem, RecentDiscussionFeed, AnalyticsInViewTracker, FrontpageReviewWidget,
13	SingleColumnSection, FrontpageBestOfLWWidget, EAPopularCommentsSection, QuickTakesSection, LWHomePosts } = Components	×
14
UNCOV 15	return (	×
16	<AnalyticsContext pageContext="homePage">
17	<React.Fragment>
18	<UpdateLastVisitCookie />	×
19
20	{reviewIsActive() && getReviewPhase() === "RESULTS" && <SingleColumnSection>
21	<FrontpageBestOfLWWidget reviewYear={REVIEW_YEAR}/>
22	</SingleColumnSection>}	×
23
24	{reviewIsActive() && getReviewPhase() !== "RESULTS" && showReviewOnFrontPageIfActive.get() && <SingleColumnSection>
25	<FrontpageReviewWidget reviewYear={REVIEW_YEAR}/>
26	</SingleColumnSection>}
27
28	<AnalyticsInViewTracker
29	eventProps={{inViewType: "homePosts"}}
30	observerProps={{threshold:[0, 0.5, 1]}}
31	>
32	<LWHomePosts>
33	<QuickTakesSection />
34
35	<EAPopularCommentsSection />
36
37	<RecentDiscussionFeed
38	af={false}
39	commentsLimit={4}
40	maxAgeHours={18}
41	/>
42	</LWHomePosts>
43	</AnalyticsInViewTracker>
44	</React.Fragment>
45	</AnalyticsContext>
46	)
47	}
48
49	const UpdateLastVisitCookie = () => {	1✔
NEW 50	const [_, setCookie] = useCookiesWithConsent([LAST_VISITED_FRONTPAGE_COOKIE]);	×
51
NEW 52	useEffect(() => {	×
NEW 53	if (visitorGetsDynamicFrontpage(null)) {	×
NEW 54	setCookie(LAST_VISITED_FRONTPAGE_COOKIE, new Date().toISOString(), { path: "/", expires: moment().add(1, 'year').toDate() });	×
55	}
56	}, [setCookie])
57
NEW 58	return <></>	×
59	}
60
61	const LWHomeComponent = registerComponent('LWHome', LWHome);	1✔
62
63	declare global {
64	interface ComponentTypes {
65	LWHome: typeof LWHomeComponent
66	}
67	}

ForumMagnum / ForumMagnum / 9087042847

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous