9036393529

Committed 10 May 2024 06:18PM UTC coverage: 31.912% (+0.01%) from 31.899%

Build # 9036393529

Build Type

Pull #9265

github

Committed by

jimrandomh

Commit Message

Don't close New Quick Take when you interact with the CkEditor toolbar

Pull Request Pull Request #9265: Don't close New Quick Take when you interact with the CkEditor toolbar

Run Details

4762 of 38932 branches covered (12.23%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

381 existing lines in 18 files now uncovered.

27724 of 62867 relevant lines covered (44.1%)

178.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

17.53

/packages/lesswrong/components/users/ViewSubscriptionsPage.tsx

import React, {ReactNode} from 'react';
import { Components, registerComponent } from '../../lib/vulcan-lib';
import { useSingle } from '../../lib/crud/withSingle';
import { useMulti } from '../../lib/crud/withMulti';
import { useCurrentUser } from '../common/withUser';
import { Link } from '../../lib/reactRouterWrapper';
import { commentGetPageUrlFromIds } from '../../lib/collections/comments/helpers';
import { tagGetUrl } from '../../lib/collections/tags/helpers';
import { allowSubscribeToSequencePosts, allowSubscribeToUserComments } from '../../lib/betas';
import { sequenceGetPageUrl } from '../../lib/collections/sequences/helpers';

const styles = (theme: ThemeType): JssStyles => ({
  subscribedItem: {
    display: "flex",
    ...theme.typography.commentStyle
  },
  subscribedItemDescription: {
    flexGrow: 1,
  },
});

const SubscriptionsList = ({collectionName, fragmentName, subscriptionType, noSubscriptionsMessage, renderDocument, title, classes}: {
  collectionName: CollectionNameString,
  fragmentName: keyof FragmentTypes,
  subscriptionType: string,
  noSubscriptionsMessage: string,
  renderDocument: (document: any) => ReactNode,
  title: React.ReactNode,
  classes: ClassesType,
}) => {
  const { SubscribedItem, SectionTitle, Loading, LoadMore } = Components;
  const currentUser = useCurrentUser();
  
  const { results, loading, loadMoreProps, showLoadMore } = useMulti({
    terms: {
      view: "subscriptionsOfType",
      userId: currentUser?._id,
      collectionName: collectionName,
      subscriptionType: subscriptionType,
      limit: 50
    },
    collectionName: "Subscriptions",
    fragmentName: "SubscriptionState",
  });
  
  if (!currentUser)
    return null;
  if (loading)
    return <Loading/>
  if (!results)
    return null;
  
  return <div>
    <SectionTitle title={title}/>
    {results.map(result =>
      <SubscribedItem
        key={result._id}
        collectionName={collectionName}
        fragmentName={fragmentName}
        subscription={result}
        renderDocument={renderDocument}
      />
    )}
    {results.length===0 && <div className={classes.subscribedItem}>
      {noSubscriptionsMessage}
    </div>}
    {showLoadMore && <LoadMore {...loadMoreProps} />}
  </div>
}

const SubscriptionsListComponent = registerComponent("SubscriptionsList", SubscriptionsList, {styles});

declare global {
  interface ComponentTypes {
    SubscriptionsList: typeof SubscriptionsListComponent
  }
}

const SubscribedItem = ({collectionName, fragmentName, subscription, renderDocument, classes}: {
  collectionName: CollectionNameString,
  fragmentName: keyof FragmentTypes,
  subscription: SubscriptionState,
  renderDocument: (document: any) => ReactNode,
  classes: ClassesType,
}) => {
  const { Loading, NotifyMeButton } = Components;
  const { document, loading } = useSingle({
    documentId: subscription.documentId,
    collectionName, fragmentName,
  });
  
  if (!document && !loading) return null
  if (loading) return <Loading/>
  
  return <div className={classes.subscribedItem}>
    <div className={classes.subscribedItemDescription}>
    {renderDocument(document)}
    </div>
    <NotifyMeButton
      document={document}
      subscriptionType={subscription.type}
      subscribeMessage="Resubscribe"
      unsubscribeMessage="Unsubscribe"
    />
  </div>
  
}

const SubscribedItemComponent = registerComponent("SubscribedItem", SubscribedItem, {styles});

declare global {
  interface ComponentTypes {
    SubscribedItem: typeof SubscribedItemComponent
  }
}

const ViewSubscriptionsPage = ({classes}: {
  classes: ClassesType,
}) => {
  const { SingleColumnSection, SubscriptionsList, UsersNameDisplay } = Components;
  const currentUser = useCurrentUser();
  
  if (!currentUser) {
    return <SingleColumnSection>
      Log in to manage your subscriptions.
    </SingleColumnSection>;
  }
  
  return <SingleColumnSection>
    <SubscriptionsList
      title="Subscribed to Posts By Users"
      collectionName="Users"
      subscriptionType="newPosts"
      fragmentName="UsersMinimumInfo"
      renderDocument={(user: UsersMinimumInfo) => <UsersNameDisplay user={user}/>}
      noSubscriptionsMessage="You are not subscribed to any users' posts."
    />
    {allowSubscribeToUserComments && <SubscriptionsList
      title="Subscribed to All Comments By Users"
      collectionName="Users"
      subscriptionType="newUserComments"
      fragmentName="UsersMinimumInfo"
      renderDocument={(user: UsersMinimumInfo) => <UsersNameDisplay user={user}/>}
      noSubscriptionsMessage="You are not subscribed to any users' comments."
    />}
    
    <SubscriptionsList
      title="Subscribed to Comments on Posts"
      collectionName="Posts"
      subscriptionType="newComments"
      fragmentName="PostsList"
      renderDocument={(post: PostsList) => post.title}
      noSubscriptionsMessage="You are not subscribed to comments on any posts."
    />

    <SubscriptionsList
      title="Subscribed to Dialogues (as a reader)"
      collectionName="Posts"
      subscriptionType="newPublishedDialogueMessages"
      fragmentName="PostsList"
      renderDocument={(post: PostsList) => post.title}
      noSubscriptionsMessage="You are not subscribed to any dialogues as a reader."
    />

    <SubscriptionsList
      title="Subscribed to Dialogues (as a participant)"
      collectionName="Posts"
      subscriptionType="newDialogueMessages"
      fragmentName="PostsList"
      renderDocument={(post: PostsList) => post.title}
      noSubscriptionsMessage="You are not subscribed to any dialogues as a participant."
    />
  
    <SubscriptionsList
      title="Subscribed to Old-Style Dialogues (as a reader)"
      collectionName="Posts"
      subscriptionType="newDebateComments"
      fragmentName="PostsList"
      renderDocument={(post: PostsList) => post.title}
      noSubscriptionsMessage="You are not subscribed to any dialogues as a reader."
    />
  
    <SubscriptionsList
      title="Subscribed to Old-Style dialogues (as a participant)"
      collectionName="Posts"
      subscriptionType="newDebateReplies"
      fragmentName="PostsList"
      renderDocument={(post: PostsList) => post.title}
      noSubscriptionsMessage="You are not subscribed to any dialogues as a participant."
    />

    <SubscriptionsList
      title="Subscribed to Comment Replies"
      collectionName="Comments"
      subscriptionType="newReplies"
      fragmentName="CommentsListWithParentMetadata"
      renderDocument={(comment: CommentsListWithParentMetadata) => <Link to={commentGetPageUrlFromIds({postId: comment?.post?._id, postSlug: comment?.post?.slug, tagSlug: comment?.tag?.slug, tagCommentType: comment?.tagCommentType, commentId: comment?._id, permalink: true})}>
        author: {comment?.user?.displayName} post: {comment?.post?.title}
      </Link>}
      noSubscriptionsMessage="You are not subscribed to any comment replies."
    />

    <SubscriptionsList
      title="Subscribed to Local Groups"
      collectionName="Localgroups"
      subscriptionType="newEvents"
      fragmentName="localGroupsBase"
      renderDocument={(group: localGroupsBase) => group.name}
      noSubscriptionsMessage="You are not subscribed to any local groups."
    />

    <SubscriptionsList
      title="Subscribed to Tags"
      collectionName="Tags"
      subscriptionType="newTagPosts"
      fragmentName="TagPreviewFragment"
      renderDocument={(tag: TagPreviewFragment) => <Link to={tagGetUrl(tag)}>{tag.name}</Link>}
      noSubscriptionsMessage="You are not subscribed to any tags."
    />
    
    {allowSubscribeToSequencePosts && <SubscriptionsList
      title="Subscribed to Sequences"
      collectionName="Sequences"
      subscriptionType="newSequencePosts"
      fragmentName="SequencesPageTitleFragment"
      renderDocument={(sequence: SequencesPageTitleFragment) => <Link to={sequenceGetPageUrl(sequence)}>{sequence.title}</Link>}
      noSubscriptionsMessage="You are not subscribed to any sequences."
    />}
    
  </SingleColumnSection>;
}

const ViewSubscriptionsPageComponent = registerComponent("ViewSubscriptionsPage", ViewSubscriptionsPage, {styles});
  
declare global {
  interface ComponentTypes {
    ViewSubscriptionsPage: typeof ViewSubscriptionsPageComponent,
  }
}

1	import React, {ReactNode} from 'react';	1✔
2	import { Components, registerComponent } from '../../lib/vulcan-lib';	1✔
3	import { useSingle } from '../../lib/crud/withSingle';	1✔
4	import { useMulti } from '../../lib/crud/withMulti';	1✔
5	import { useCurrentUser } from '../common/withUser';	1✔
6	import { Link } from '../../lib/reactRouterWrapper';	1✔
7	import { commentGetPageUrlFromIds } from '../../lib/collections/comments/helpers';	1✔
8	import { tagGetUrl } from '../../lib/collections/tags/helpers';	1✔
9	import { allowSubscribeToSequencePosts, allowSubscribeToUserComments } from '../../lib/betas';	1✔
10	import { sequenceGetPageUrl } from '../../lib/collections/sequences/helpers';	1✔
11
12	const styles = (theme: ThemeType): JssStyles => ({	3✔
13	subscribedItem: {
14	display: "flex",
15	...theme.typography.commentStyle
16	},
17	subscribedItemDescription: {
18	flexGrow: 1,
19	},
20	});
21
22	const SubscriptionsList = ({collectionName, fragmentName, subscriptionType, noSubscriptionsMessage, renderDocument, title, classes}: {	1✔
23	collectionName: CollectionNameString,
24	fragmentName: keyof FragmentTypes,
25	subscriptionType: string,
26	noSubscriptionsMessage: string,
27	renderDocument: (document: any) => ReactNode,
28	title: React.ReactNode,
29	classes: ClassesType,
30	}) => {
UNCOV 31	const { SubscribedItem, SectionTitle, Loading, LoadMore } = Components;	×
32	const currentUser = useCurrentUser();	×
33
UNCOV 34	const { results, loading, loadMoreProps, showLoadMore } = useMulti({	×
35	terms: {
36	view: "subscriptionsOfType",
37	userId: currentUser?._id,	×
38	collectionName: collectionName,
39	subscriptionType: subscriptionType,
40	limit: 50
41	},
42	collectionName: "Subscriptions",
43	fragmentName: "SubscriptionState",
44	});
45
UNCOV 46	if (!currentUser)	×
47	return null;	×
48	if (loading)	×
49	return <Loading/>	×
50	if (!results)	×
51	return null;	×
52
UNCOV 53	return <div>	×
54	<SectionTitle title={title}/>
55	{results.map(result =>
UNCOV 56	<SubscribedItem	×
57	key={result._id}
58	collectionName={collectionName}
59	fragmentName={fragmentName}
60	subscription={result}
61	renderDocument={renderDocument}
62	/>
63	)}
64	{results.length===0 && <div className={classes.subscribedItem}>	×
65	{noSubscriptionsMessage}
66	</div>}
67	{showLoadMore && <LoadMore {...loadMoreProps} />}	×
68	</div>
69	}
70
71	const SubscriptionsListComponent = registerComponent("SubscriptionsList", SubscriptionsList, {styles});	1✔
72
73	declare global {
74	interface ComponentTypes {
75	SubscriptionsList: typeof SubscriptionsListComponent
76	}
77	}
78
79	const SubscribedItem = ({collectionName, fragmentName, subscription, renderDocument, classes}: {	1✔
80	collectionName: CollectionNameString,
81	fragmentName: keyof FragmentTypes,
82	subscription: SubscriptionState,
83	renderDocument: (document: any) => ReactNode,
84	classes: ClassesType,
85	}) => {
UNCOV 86	const { Loading, NotifyMeButton } = Components;	×
87	const { document, loading } = useSingle({	×
88	documentId: subscription.documentId,
89	collectionName, fragmentName,
90	});
91
UNCOV 92	if (!document && !loading) return null	×
93	if (loading) return <Loading/>	×
94
UNCOV 95	return <div className={classes.subscribedItem}>	×
96	<div className={classes.subscribedItemDescription}>
97	{renderDocument(document)}
98	</div>
99	<NotifyMeButton
100	document={document}
101	subscriptionType={subscription.type}
102	subscribeMessage="Resubscribe"
103	unsubscribeMessage="Unsubscribe"
104	/>
105	</div>
106
107	}
108
109	const SubscribedItemComponent = registerComponent("SubscribedItem", SubscribedItem, {styles});	1✔
110
111	declare global {
112	interface ComponentTypes {
113	SubscribedItem: typeof SubscribedItemComponent
114	}
115	}
116
117	const ViewSubscriptionsPage = ({classes}: {	1✔
118	classes: ClassesType,
119	}) => {
UNCOV 120	const { SingleColumnSection, SubscriptionsList, UsersNameDisplay } = Components;	×
121	const currentUser = useCurrentUser();	×
122
UNCOV 123	if (!currentUser) {	×
124	return <SingleColumnSection>	×
125	Log in to manage your subscriptions.
126	</SingleColumnSection>;
127	}
128
UNCOV 129	return <SingleColumnSection>	×
130	<SubscriptionsList
131	title="Subscribed to Posts By Users"
132	collectionName="Users"
133	subscriptionType="newPosts"
134	fragmentName="UsersMinimumInfo"
UNCOV 135	renderDocument={(user: UsersMinimumInfo) => <UsersNameDisplay user={user}/>}	×
136	noSubscriptionsMessage="You are not subscribed to any users' posts."
137	/>
138	{allowSubscribeToUserComments && <SubscriptionsList	×
139	title="Subscribed to All Comments By Users"
140	collectionName="Users"
141	subscriptionType="newUserComments"
142	fragmentName="UsersMinimumInfo"
UNCOV 143	renderDocument={(user: UsersMinimumInfo) => <UsersNameDisplay user={user}/>}	×
144	noSubscriptionsMessage="You are not subscribed to any users' comments."
145	/>}
146
147	<SubscriptionsList
148	title="Subscribed to Comments on Posts"
149	collectionName="Posts"
150	subscriptionType="newComments"
151	fragmentName="PostsList"
152	renderDocument={(post: PostsList) => post.title}	×
153	noSubscriptionsMessage="You are not subscribed to comments on any posts."
154	/>
155
156	<SubscriptionsList
157	title="Subscribed to Dialogues (as a reader)"
158	collectionName="Posts"
159	subscriptionType="newPublishedDialogueMessages"
160	fragmentName="PostsList"
161	renderDocument={(post: PostsList) => post.title}	×
162	noSubscriptionsMessage="You are not subscribed to any dialogues as a reader."
163	/>
164
165	<SubscriptionsList
166	title="Subscribed to Dialogues (as a participant)"
167	collectionName="Posts"
168	subscriptionType="newDialogueMessages"
169	fragmentName="PostsList"
170	renderDocument={(post: PostsList) => post.title}	×
171	noSubscriptionsMessage="You are not subscribed to any dialogues as a participant."
172	/>
173
174	<SubscriptionsList
175	title="Subscribed to Old-Style Dialogues (as a reader)"
176	collectionName="Posts"
177	subscriptionType="newDebateComments"
178	fragmentName="PostsList"
179	renderDocument={(post: PostsList) => post.title}	×
180	noSubscriptionsMessage="You are not subscribed to any dialogues as a reader."
181	/>
182
183	<SubscriptionsList
184	title="Subscribed to Old-Style dialogues (as a participant)"
185	collectionName="Posts"
186	subscriptionType="newDebateReplies"
187	fragmentName="PostsList"
188	renderDocument={(post: PostsList) => post.title}	×
189	noSubscriptionsMessage="You are not subscribed to any dialogues as a participant."
190	/>
191
192	<SubscriptionsList
193	title="Subscribed to Comment Replies"
194	collectionName="Comments"
195	subscriptionType="newReplies"
196	fragmentName="CommentsListWithParentMetadata"
197	renderDocument={(comment: CommentsListWithParentMetadata) => <Link to={commentGetPageUrlFromIds({postId: comment?.post?._id, postSlug: comment?.post?.slug, tagSlug: comment?.tag?.slug, tagCommentType: comment?.tagCommentType, commentId: comment?._id, permalink: true})}>	×
198	author: {comment?.user?.displayName} post: {comment?.post?.title}	×
199	</Link>}
200	noSubscriptionsMessage="You are not subscribed to any comment replies."
201	/>
202
203	<SubscriptionsList
204	title="Subscribed to Local Groups"
205	collectionName="Localgroups"
206	subscriptionType="newEvents"
207	fragmentName="localGroupsBase"
UNCOV 208	renderDocument={(group: localGroupsBase) => group.name}	×
209	noSubscriptionsMessage="You are not subscribed to any local groups."
210	/>
211
212	<SubscriptionsList
213	title="Subscribed to Tags"
214	collectionName="Tags"
215	subscriptionType="newTagPosts"
216	fragmentName="TagPreviewFragment"
217	renderDocument={(tag: TagPreviewFragment) => <Link to={tagGetUrl(tag)}>{tag.name}</Link>}	×
218	noSubscriptionsMessage="You are not subscribed to any tags."
219	/>
220
221	{allowSubscribeToSequencePosts && <SubscriptionsList	×
222	title="Subscribed to Sequences"
223	collectionName="Sequences"
224	subscriptionType="newSequencePosts"
225	fragmentName="SequencesPageTitleFragment"
226	renderDocument={(sequence: SequencesPageTitleFragment) => <Link to={sequenceGetPageUrl(sequence)}>{sequence.title}</Link>}	×
227	noSubscriptionsMessage="You are not subscribed to any sequences."
228	/>}
229
230	</SingleColumnSection>;
231	}
232
233	const ViewSubscriptionsPageComponent = registerComponent("ViewSubscriptionsPage", ViewSubscriptionsPage, {styles});	1✔
234
235	declare global {
236	interface ComponentTypes {
237	ViewSubscriptionsPage: typeof ViewSubscriptionsPageComponent,
238	}
239	}

ForumMagnum / ForumMagnum / 9036393529

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous