9008712340

Committed 08 May 2024 09:20PM UTC coverage: 31.882% (-0.03%) from 31.911%

Build # 9008712340

Build Type

Pull #9252

github

Committed by

b0b3rt

Commit Message

accept migration

Pull Request Pull Request #9252: cache recombee recommendations

Run Details

4728 of 38775 branches covered (12.19%)

Branch coverage included in aggregate %.

24 of 56 new or added lines in 9 files covered. (42.86%)

790 existing lines in 48 files now uncovered.

27620 of 62687 relevant lines covered (44.06%)

178.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.0

/packages/lesswrong/components/hooks/useRecentOpportunities.ts

import moment from "moment";
import { useTimezone } from "../common/withTimezone";
import { UseMultiResult, useMulti } from "../../lib/crud/withMulti";
import difference from "lodash/difference";
import groupBy from "lodash/groupBy";

const requiredTags: string[] = [
  "z8qFsGt5iXyZiLbjN", // Opportunities to take action
];

const defaultSubscribedTags: string[] = [
  "fCcrMpyRbozMfwYPF", // Application announcements
  "be4pBryMKxLhkmgvE", // Funding opportunities
  "2BvgFyR85zX25osTT", // Fellowships and internships
  "54Ls7K7N53kYws9ja", // Job listing (open)
  "vgT4Fiybt4qjHLoBv", // Bounty (open)
  "ihpwNfh2ZxR4ZHaAK", // Prizes and contests
];

type KeyWithSubfield<T, S extends string> = {
  [K in keyof T]: S extends keyof T[K] ? K : never
}[keyof T];

export const useRecentOpportunities =<
  FragmentTypeName extends KeyWithSubfield<FragmentTypes, "tagRelevance">
> ({
  fragmentName,
  limit = 3,
  maxAgeInDays = 7,
  post,
  ssr,
}: {
  fragmentName: FragmentTypeName,
  limit?: number,
  maxAgeInDays?: number,
  post?: PostsWithNavigation | PostsWithNavigationAndRevision | PostsList,
  ssr?: boolean,
}): UseMultiResult<FragmentTypeName> & {coreTagLabel: string | null} => {
  const coreTags =
    post?.tags
      ?.filter((tag) => tag.core && !requiredTags.includes(tag._id))
      .sort((a, b) => (a.name < b.name ? -1 : 1)) ?? [];
  const coreTagIds = coreTags?.map(tag => tag._id) ?? [];
  const subscribedTags = difference(defaultSubscribedTags, coreTagIds);

  // For core tags, bump them to the top of the list by adding a karma multiplier,
  // don't make the modifier too high, so that very old or low karma posts will still be excluded
  const coreTagFilterSettings = coreTagIds.map((tagId) => ({
    tagId,
    filterMode: "x30",
  }));

  const {timezone} = useTimezone();
  const now = moment().tz(timezone);
  const dateCutoff = now.subtract(maxAgeInDays, "days").format("YYYY-MM-DD");
  const { results, ...useMultiResult } = useMulti<FragmentTypeName, "Posts">({
    collectionName: "Posts",
    terms: {
      view: "magic",
      filterSettings: {
        tags: [
          ...requiredTags.map((tagId) => ({ tagId, filterMode: "Required" })),
          ...subscribedTags.map((tagId) => ({ tagId, filterMode: "Subscribed" })),
          ...coreTagFilterSettings,
        ],
      },
      after: dateCutoff,
      limit,
    },
    fragmentName,
    enableTotal: false,
    ssr,
    fetchPolicy: "cache-and-network",
  });

  // If all results have the same core tag as one on the input post, set this as the coreTagLabel. If there are multiple that
  // satisfy this choose the lowest alphabetically
  const allResultsCoreTags = results
    ?.flatMap((result) => Object.keys(result.tagRelevance))
    .filter((tagId) => coreTagIds.includes(tagId));
  const tagCounts = groupBy(allResultsCoreTags, (tagId) => tagId);
  const allowedLabelIds = Object.keys(tagCounts).filter(k => tagCounts[k].length === results?.length)
  const allowedLabelTags = coreTags.filter(t => allowedLabelIds.includes(t._id))

  const coreTagLabel = allowedLabelTags.length ? allowedLabelTags[0].name : null;

  return {
    results,
    ...useMultiResult,
    coreTagLabel,
  };
}

1	import moment from "moment";	3✔
2	import { useTimezone } from "../common/withTimezone";	1✔
3	import { UseMultiResult, useMulti } from "../../lib/crud/withMulti";	1✔
4	import difference from "lodash/difference";	1✔
5	import groupBy from "lodash/groupBy";	1✔
6
7	const requiredTags: string[] = [	1✔
8	"z8qFsGt5iXyZiLbjN", // Opportunities to take action
9	];
10
11	const defaultSubscribedTags: string[] = [	1✔
12	"fCcrMpyRbozMfwYPF", // Application announcements
13	"be4pBryMKxLhkmgvE", // Funding opportunities
14	"2BvgFyR85zX25osTT", // Fellowships and internships
15	"54Ls7K7N53kYws9ja", // Job listing (open)
16	"vgT4Fiybt4qjHLoBv", // Bounty (open)
17	"ihpwNfh2ZxR4ZHaAK", // Prizes and contests
18	];
19
20	type KeyWithSubfield<T, S extends string> = {
21	[K in keyof T]: S extends keyof T[K] ? K : never
22	}[keyof T];
23
24	export const useRecentOpportunities =<	1✔
25	FragmentTypeName extends KeyWithSubfield<FragmentTypes, "tagRelevance">
26	> ({
27	fragmentName,
28	limit = 3,	×
29	maxAgeInDays = 7,	×
30	post,
31	ssr,
32	}: {
33	fragmentName: FragmentTypeName,
34	limit?: number,
35	maxAgeInDays?: number,
36	post?: PostsWithNavigation \| PostsWithNavigationAndRevision \| PostsList,
37	ssr?: boolean,
38	}): UseMultiResult<FragmentTypeName> & {coreTagLabel: string \| null} => {
39	const coreTags =	×
40	post?.tags	×
41	?.filter((tag) => tag.core && !requiredTags.includes(tag._id))	×
42	.sort((a, b) => (a.name < b.name ? -1 : 1)) ?? [];	×
43	const coreTagIds = coreTags?.map(tag => tag._id) ?? [];	×
44	const subscribedTags = difference(defaultSubscribedTags, coreTagIds);	×
45
46	// For core tags, bump them to the top of the list by adding a karma multiplier,
47	// don't make the modifier too high, so that very old or low karma posts will still be excluded
48	const coreTagFilterSettings = coreTagIds.map((tagId) => ({	×
49	tagId,
50	filterMode: "x30",
51	}));
52
53	const {timezone} = useTimezone();	×
54	const now = moment().tz(timezone);	×
55	const dateCutoff = now.subtract(maxAgeInDays, "days").format("YYYY-MM-DD");	×
UNCOV 56	const { results, ...useMultiResult } = useMulti<FragmentTypeName, "Posts">({	×
57	collectionName: "Posts",
58	terms: {
59	view: "magic",
60	filterSettings: {
61	tags: [
62	...requiredTags.map((tagId) => ({ tagId, filterMode: "Required" })),	×
UNCOV 63	...subscribedTags.map((tagId) => ({ tagId, filterMode: "Subscribed" })),	×
64	...coreTagFilterSettings,
65	],
66	},
67	after: dateCutoff,
68	limit,
69	},
70	fragmentName,
71	enableTotal: false,
72	ssr,
73	fetchPolicy: "cache-and-network",
74	});
75
76	// If all results have the same core tag as one on the input post, set this as the coreTagLabel. If there are multiple that
77	// satisfy this choose the lowest alphabetically
78	const allResultsCoreTags = results	×
79	?.flatMap((result) => Object.keys(result.tagRelevance))	×
80	.filter((tagId) => coreTagIds.includes(tagId));	×
81	const tagCounts = groupBy(allResultsCoreTags, (tagId) => tagId);	×
82	const allowedLabelIds = Object.keys(tagCounts).filter(k => tagCounts[k].length === results?.length)	×
UNCOV 83	const allowedLabelTags = coreTags.filter(t => allowedLabelIds.includes(t._id))	×
84
UNCOV 85	const coreTagLabel = allowedLabelTags.length ? allowedLabelTags[0].name : null;	×
86
UNCOV 87	return {	×
88	results,
89	...useMultiResult,
90	coreTagLabel,
91	};
92	}

ForumMagnum / ForumMagnum / 9008712340

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous