9005366850

Committed 08 May 2024 04:36PM UTC coverage: 31.914% (+0.03%) from 31.881%

Build # 9005366850

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9246 from ForumMagnum/master

[EA] deploy emoji banner, indexes in schema, time tag, date range fix, react user links

Run Details

4764 of 38919 branches covered (12.24%)

Branch coverage included in aggregate %.

181 of 429 new or added lines in 47 files covered. (42.19%)

15 existing lines in 13 files now uncovered.

27703 of 62814 relevant lines covered (44.1%)

177.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.33

/packages/lesswrong/components/hooks/useRecentOpportunities.ts

import moment from "moment";
import { UseMultiResult, useMulti } from "../../lib/crud/withMulti";
import difference from "lodash/difference";
import groupBy from "lodash/groupBy";
import { useCurrentTime } from "../../lib/utils/timeUtil";

const requiredTags: string[] = [
  "z8qFsGt5iXyZiLbjN", // Opportunities to take action
];

const defaultSubscribedTags: string[] = [
  "fCcrMpyRbozMfwYPF", // Application announcements
  "be4pBryMKxLhkmgvE", // Funding opportunities
  "2BvgFyR85zX25osTT", // Fellowships and internships
  "54Ls7K7N53kYws9ja", // Job listing (open)
  "vgT4Fiybt4qjHLoBv", // Bounty (open)
  "ihpwNfh2ZxR4ZHaAK", // Prizes and contests
];

type KeyWithSubfield<T, S extends string> = {
  [K in keyof T]: S extends keyof T[K] ? K : never
}[keyof T];

export const useRecentOpportunities =<
  FragmentTypeName extends KeyWithSubfield<FragmentTypes, "tagRelevance">
> ({
  fragmentName,
  limit = 3,
  maxAgeInDays = 7,
  post,
  ssr,
}: {
  fragmentName: FragmentTypeName,
  limit?: number,
  maxAgeInDays?: number,
  post?: PostsWithNavigation | PostsWithNavigationAndRevision | PostsList,
  ssr?: boolean,
}): UseMultiResult<FragmentTypeName> & {coreTagLabel: string | null} => {
  const coreTags =
    post?.tags
      ?.filter((tag) => tag.core && !requiredTags.includes(tag._id))
      .sort((a, b) => (a.name < b.name ? -1 : 1)) ?? [];
  const coreTagIds = coreTags?.map(tag => tag._id) ?? [];
  const subscribedTags = difference(defaultSubscribedTags, coreTagIds);

  // For core tags, bump them to the top of the list by adding a karma multiplier,
  // don't make the modifier too high, so that very old or low karma posts will still be excluded
  const coreTagFilterSettings = coreTagIds.map((tagId) => ({
    tagId,
    filterMode: "x30",
  }));

  const now = useCurrentTime();
  const dateCutoff = moment(now).subtract(maxAgeInDays, "days").startOf('hour').toISOString();
  const { results, ...useMultiResult } = useMulti<FragmentTypeName, "Posts">({
    collectionName: "Posts",
    terms: {
      view: "magic",
      filterSettings: {
        tags: [
          ...requiredTags.map((tagId) => ({ tagId, filterMode: "Required" })),
          ...subscribedTags.map((tagId) => ({ tagId, filterMode: "Subscribed" })),
          ...coreTagFilterSettings,
        ],
      },
      after: dateCutoff,
      limit,
    },
    fragmentName,
    enableTotal: false,
    ssr,
    fetchPolicy: "cache-and-network",
  });

  // If all results have the same core tag as one on the input post, set this as the coreTagLabel. If there are multiple that
  // satisfy this choose the lowest alphabetically
  const allResultsCoreTags = results
    ?.flatMap((result) => Object.keys(result.tagRelevance))
    .filter((tagId) => coreTagIds.includes(tagId));
  const tagCounts = groupBy(allResultsCoreTags, (tagId) => tagId);
  const allowedLabelIds = Object.keys(tagCounts).filter(k => tagCounts[k].length === results?.length)
  const allowedLabelTags = coreTags.filter(t => allowedLabelIds.includes(t._id))

  const coreTagLabel = allowedLabelTags.length ? allowedLabelTags[0].name : null;

  return {
    results,
    ...useMultiResult,
    coreTagLabel,
  };
}

1	import moment from "moment";	3✔
2	import { UseMultiResult, useMulti } from "../../lib/crud/withMulti";	1✔
3	import difference from "lodash/difference";	1✔
4	import groupBy from "lodash/groupBy";	1✔
5	import { useCurrentTime } from "../../lib/utils/timeUtil";	1✔
6
7	const requiredTags: string[] = [	1✔
8	"z8qFsGt5iXyZiLbjN", // Opportunities to take action
9	];
10
11	const defaultSubscribedTags: string[] = [	1✔
12	"fCcrMpyRbozMfwYPF", // Application announcements
13	"be4pBryMKxLhkmgvE", // Funding opportunities
14	"2BvgFyR85zX25osTT", // Fellowships and internships
15	"54Ls7K7N53kYws9ja", // Job listing (open)
16	"vgT4Fiybt4qjHLoBv", // Bounty (open)
17	"ihpwNfh2ZxR4ZHaAK", // Prizes and contests
18	];
19
20	type KeyWithSubfield<T, S extends string> = {
21	[K in keyof T]: S extends keyof T[K] ? K : never
22	}[keyof T];
23
24	export const useRecentOpportunities =<	1✔
25	FragmentTypeName extends KeyWithSubfield<FragmentTypes, "tagRelevance">
26	> ({
27	fragmentName,
28	limit = 3,	×
29	maxAgeInDays = 7,	×
30	post,
31	ssr,
32	}: {
33	fragmentName: FragmentTypeName,
34	limit?: number,
35	maxAgeInDays?: number,
36	post?: PostsWithNavigation \| PostsWithNavigationAndRevision \| PostsList,
37	ssr?: boolean,
38	}): UseMultiResult<FragmentTypeName> & {coreTagLabel: string \| null} => {
39	const coreTags =	×
40	post?.tags	×
41	?.filter((tag) => tag.core && !requiredTags.includes(tag._id))	×
42	.sort((a, b) => (a.name < b.name ? -1 : 1)) ?? [];	×
43	const coreTagIds = coreTags?.map(tag => tag._id) ?? [];	×
44	const subscribedTags = difference(defaultSubscribedTags, coreTagIds);	×
45
46	// For core tags, bump them to the top of the list by adding a karma multiplier,
47	// don't make the modifier too high, so that very old or low karma posts will still be excluded
48	const coreTagFilterSettings = coreTagIds.map((tagId) => ({	×
49	tagId,
50	filterMode: "x30",
51	}));
52
NEW 53	const now = useCurrentTime();	×
NEW 54	const dateCutoff = moment(now).subtract(maxAgeInDays, "days").startOf('hour').toISOString();	×
UNCOV 55	const { results, ...useMultiResult } = useMulti<FragmentTypeName, "Posts">({	×
56	collectionName: "Posts",
57	terms: {
58	view: "magic",
59	filterSettings: {
60	tags: [
61	...requiredTags.map((tagId) => ({ tagId, filterMode: "Required" })),	×
62	...subscribedTags.map((tagId) => ({ tagId, filterMode: "Subscribed" })),	×
63	...coreTagFilterSettings,
64	],
65	},
66	after: dateCutoff,
67	limit,
68	},
69	fragmentName,
70	enableTotal: false,
71	ssr,
72	fetchPolicy: "cache-and-network",
73	});
74
75	// If all results have the same core tag as one on the input post, set this as the coreTagLabel. If there are multiple that
76	// satisfy this choose the lowest alphabetically
77	const allResultsCoreTags = results	×
78	?.flatMap((result) => Object.keys(result.tagRelevance))	×
79	.filter((tagId) => coreTagIds.includes(tagId));	×
80	const tagCounts = groupBy(allResultsCoreTags, (tagId) => tagId);	×
81	const allowedLabelIds = Object.keys(tagCounts).filter(k => tagCounts[k].length === results?.length)	×
82	const allowedLabelTags = coreTags.filter(t => allowedLabelIds.includes(t._id))	×
83
84	const coreTagLabel = allowedLabelTags.length ? allowedLabelTags[0].name : null;	×
85
86	return {	×
87	results,
88	...useMultiResult,
89	coreTagLabel,
90	};
91	}

ForumMagnum / ForumMagnum / 9005366850

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous