9004300977

Committed 08 May 2024 03:16PM UTC coverage: 92.978% (+0.04%) from 92.939%

Build # 9004300977

Build Type

Pull #1527

github

Committed by

iamacook

Commit Message

Checksum `moduleAddress`

Pull Request Pull Request #1527: Authorise recovery module adding/deleting with JWT authentication

Run Details

1947 of 2367 branches covered (82.26%)

Branch coverage included in aggregate %.

18 of 20 new or added lines in 3 files covered. (90.0%)

2 existing lines in 1 file now uncovered.

6938 of 7189 relevant lines covered (96.51%)

322.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.75

/src/routes/recovery/recovery.service.ts

import { Inject, Injectable, UnauthorizedException } from '@nestjs/common';
import { IAlertsRepository } from '@/domain/alerts/alerts.repository.interface';
import { AlertsRepository } from '@/domain/alerts/alerts.repository';
import { AddRecoveryModuleDto } from '@/routes/recovery/entities/add-recovery-module.dto.entity';
import { AlertsRegistration } from '@/domain/alerts/entities/alerts-registration.entity';
import { AuthPayload } from '@/domain/auth/entities/auth-payload.entity';
import { ISafeRepository } from '@/domain/safe/safe.repository.interface';

@Injectable()
export class RecoveryService {
  constructor(
    @Inject(IAlertsRepository)
    private readonly alertsRepository: AlertsRepository,
    @Inject(ISafeRepository)
    private readonly safeRepository: ISafeRepository,
  ) {}

  async addRecoveryModule(args: {
    chainId: string;
    safeAddress: `0x${string}`;
    addRecoveryModuleDto: AddRecoveryModuleDto;
    authPayload: AuthPayload;
  }): Promise<void> {
    if (
      !args.authPayload.isForChain(args.chainId) ||
      !args.authPayload.signer_address
    ) {
      throw new UnauthorizedException();
    }

    // Check after AuthPayload check to avoid unnecessary request
    const isOwner = await this.safeRepository
      .isOwner({
        safeAddress: args.safeAddress,
        chainId: args.chainId,
        address: args.authPayload.signer_address,
      })
      // Swallow error to avoid leaking information
      .catch(() => false);
    if (!isOwner) {
      throw new UnauthorizedException();
    }

    const contract: AlertsRegistration = {
      chainId: args.chainId,
      address: args.addRecoveryModuleDto.moduleAddress,
      displayName: `${args.chainId}:${args.safeAddress}:${args.addRecoveryModuleDto.moduleAddress}`,
    };
    await this.alertsRepository.addContract(contract);
  }

  async deleteRecoveryModule(args: {
    chainId: string;
    moduleAddress: `0x${string}`;
    safeAddress: `0x${string}`;
    authPayload: AuthPayload;
  }): Promise<void> {
    if (
      !args.authPayload.isForChain(args.chainId) ||
      !args.authPayload.signer_address
    ) {
      throw new UnauthorizedException();
    }

    // Check after AuthPayload check to avoid unnecessary request
    const isOwner = await this.safeRepository
      .isOwner({
        safeAddress: args.safeAddress,
        chainId: args.chainId,
        address: args.authPayload.signer_address,
      })
      // Swallow error to avoid leaking information
      .catch(() => false);
    if (!isOwner) {
      throw new UnauthorizedException();
    }

    await this.alertsRepository.deleteContract({
      chainId: args.chainId,
      address: args.moduleAddress,
    });
  }
}

1	import { Inject, Injectable, UnauthorizedException } from '@nestjs/common';	96✔
2	import { IAlertsRepository } from '@/domain/alerts/alerts.repository.interface';	96✔
3	import { AlertsRepository } from '@/domain/alerts/alerts.repository';	96✔
4	import { AddRecoveryModuleDto } from '@/routes/recovery/entities/add-recovery-module.dto.entity';
5	import { AlertsRegistration } from '@/domain/alerts/entities/alerts-registration.entity';
6	import { AuthPayload } from '@/domain/auth/entities/auth-payload.entity';
7	import { ISafeRepository } from '@/domain/safe/safe.repository.interface';	96✔
8
9	@Injectable()
10	export class RecoveryService {	96✔
11	constructor(
12	@Inject(IAlertsRepository)
13	private readonly alertsRepository: AlertsRepository,	86✔
14	@Inject(ISafeRepository)
15	private readonly safeRepository: ISafeRepository,	86✔
16	) {}
17
18	async addRecoveryModule(args: {
19	chainId: string;
20	safeAddress: `0x${string}`;
21	addRecoveryModuleDto: AddRecoveryModuleDto;
22	authPayload: AuthPayload;
23	}): Promise<void> {
24	if (	6✔
25	!args.authPayload.isForChain(args.chainId) \|\|	5✔
26	!args.authPayload.signer_address
27	) {
28	throw new UnauthorizedException();	2✔
29	}
30
31	// Check after AuthPayload check to avoid unnecessary request
32	const isOwner = await this.safeRepository	4✔
33	.isOwner({
34	safeAddress: args.safeAddress,
35	chainId: args.chainId,
36	address: args.authPayload.signer_address,
37	})
38	// Swallow error to avoid leaking information
NEW 39	.catch(() => false);	×
40	if (!isOwner) {	4✔
41	throw new UnauthorizedException();	2✔
42	}
43
44	const contract: AlertsRegistration = {	2✔
45	chainId: args.chainId,
46	address: args.addRecoveryModuleDto.moduleAddress,
47	displayName: `${args.chainId}:${args.safeAddress}:${args.addRecoveryModuleDto.moduleAddress}`,
48	};
49	await this.alertsRepository.addContract(contract);	2✔
50	}
51
52	async deleteRecoveryModule(args: {
53	chainId: string;
54	moduleAddress: `0x${string}`;
55	safeAddress: `0x${string}`;
56	authPayload: AuthPayload;
57	}): Promise<void> {
58	if (	10✔
59	!args.authPayload.isForChain(args.chainId) \|\|	9✔
60	!args.authPayload.signer_address
61	) {
62	throw new UnauthorizedException();	2✔
63	}
64
65	// Check after AuthPayload check to avoid unnecessary request
66	const isOwner = await this.safeRepository	8✔
67	.isOwner({
68	safeAddress: args.safeAddress,
69	chainId: args.chainId,
70	address: args.authPayload.signer_address,
71	})
72	// Swallow error to avoid leaking information
NEW 73	.catch(() => false);	×
74	if (!isOwner) {	8✔
75	throw new UnauthorizedException();	2✔
76	}
77
78	await this.alertsRepository.deleteContract({	6✔
79	chainId: args.chainId,
80	address: args.moduleAddress,
81	});
82	}
83	}

safe-global / safe-client-gateway / 9004300977

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous