8997528243

Committed 08 May 2024 06:47AM UTC coverage: 93.006% (+0.02%) from 92.99%

Build # 8997528243

Build Type

push

github

Committed by

web-flow

Commit Message

Map historical transactions before grouping them (#1505)

Maps domain transactions before grouping them, as well as simplifying the grouping logic. (This will allow for simpler filtering of address poisoning attempts as all transactions will be the same type.)

- Change `mapGroupTransactions` to only map singular transaction (`mapTransaction`)
- Map previous transaction (for date label calculation) if it exists
- Map domain transactions before grouping them
- Simplify grouping logic
- Update tests accordingly (the mock data has always been wrong)

Run Details

1953 of 2377 branches covered (82.16%)

Branch coverage included in aggregate %.

28 of 33 new or added lines in 1 file covered. (84.85%)

1 existing line in 1 file now uncovered.

7010 of 7260 relevant lines covered (96.56%)

322.42 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/src/routes/transactions/entities/__tests__/human-description.builder.ts

import { Builder, IBuilder } from '@/__tests__/builder';
import {
  RichAddressFragment,
  RichTokenValueFragment,
  RichTextFragment,
  RichDecodedInfoFragment,
  RichFragmentType,
} from '@/routes/transactions/entities/human-description.entity';
import { faker } from '@faker-js/faker';

function richTokenValueFragmentBuilder(): IBuilder<RichTokenValueFragment> {
  return new Builder<RichTokenValueFragment>()
    .with('type', RichFragmentType.TokenValue)
    .with('value', faker.string.numeric())
    .with('symbol', faker.finance.currencySymbol())
    .with('logoUri', faker.image.avatar());
}

function richTextFragmentBuilder(): IBuilder<RichTextFragment> {
  return new Builder<RichTextFragment>()
    .with('type', RichFragmentType.Text)
    .with('value', faker.word.words());
}

function richAddressFragmentBuilder(): IBuilder<RichAddressFragment> {
  return new Builder<RichAddressFragment>()
    .with('type', RichFragmentType.Address)
    .with('value', faker.finance.ethereumAddress());
}

const humanDescriptionBuilders: Array<() => IBuilder<RichDecodedInfoFragment>> =
  [
    richTokenValueFragmentBuilder,
    richTextFragmentBuilder,
    richAddressFragmentBuilder,
  ];

export function buildHumanDescription(): RichDecodedInfoFragment[] {
  return Array.from({ length: faker.number.int({ min: 0, max: 6 }) }, () =>
    faker.helpers.arrayElement(humanDescriptionBuilders)().build(),
  );
}

1	import { Builder, IBuilder } from '@/__tests__/builder';	2✔
2	import {	2✔
3	RichAddressFragment,
4	RichTokenValueFragment,
5	RichTextFragment,
6	RichDecodedInfoFragment,
7	RichFragmentType,
8	} from '@/routes/transactions/entities/human-description.entity';
9	import { faker } from '@faker-js/faker';	2✔
10
11	function richTokenValueFragmentBuilder(): IBuilder<RichTokenValueFragment> {
12	return new Builder<RichTokenValueFragment>()	2✔
13	.with('type', RichFragmentType.TokenValue)
14	.with('value', faker.string.numeric())
15	.with('symbol', faker.finance.currencySymbol())
16	.with('logoUri', faker.image.avatar());
17	}
18
19	function richTextFragmentBuilder(): IBuilder<RichTextFragment> {
20	return new Builder<RichTextFragment>()	4✔
21	.with('type', RichFragmentType.Text)
22	.with('value', faker.word.words());
23	}
24
25	function richAddressFragmentBuilder(): IBuilder<RichAddressFragment> {
UNCOV 26	return new Builder<RichAddressFragment>()	×
27	.with('type', RichFragmentType.Address)
28	.with('value', faker.finance.ethereumAddress());
29	}
30
31	const humanDescriptionBuilders: Array<() => IBuilder<RichDecodedInfoFragment>> =
32	[	2✔
33	richTokenValueFragmentBuilder,
34	richTextFragmentBuilder,
35	richAddressFragmentBuilder,
36	];
37
38	export function buildHumanDescription(): RichDecodedInfoFragment[] {	2✔
39	return Array.from({ length: faker.number.int({ min: 0, max: 6 }) }, () =>	2✔
40	faker.helpers.arrayElement(humanDescriptionBuilders)().build(),	6✔
41	);
42	}

safe-global / safe-client-gateway / 8997528243

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous