8993935739

Committed 08 May 2024 12:05AM UTC coverage: 87.212% (-0.2%) from 87.405%

Build # 8993935739

Build Type

Pull #899

github

Committed by

pmcelhaney

Commit Message

fix #898, CJS files were getting loaded as modules hence more cache issues

Pull Request Pull Request #899: fix #898, CJS files were getting loaded as modules hence more cache issues

Run Details

941 of 1043 branches covered (90.22%)

Branch coverage included in aggregate %.

13 of 18 new or added lines in 2 files covered. (72.22%)

8 existing lines in 1 file now uncovered.

3076 of 3563 relevant lines covered (86.33%)

43.32 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.79

/src/server/determine-module-kind.ts

import { existsSync } from "node:fs";
import fs from "node:fs/promises";
import path from "node:path";

const DEFAULT_MODULE_KIND = "commonjs";

interface PackageJsonWithType {
  type?: string;
}
// eslint-disable-next-line max-statements
export async function determineModuleKind(modulePath: string) {
  if (modulePath.endsWith(".cjs")) {
    return "commonjs";
  }

  if (modulePath.endsWith(".mjs")) {
    return "module";
  }

  if (modulePath === path.parse(modulePath).root) {
    return DEFAULT_MODULE_KIND;
  }

  const packageJsonPath = path.join(modulePath, "package.json");

  if (existsSync(packageJsonPath)) {
    try {
      // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
      const packageJson: PackageJsonWithType = JSON.parse(
        await fs.readFile(packageJsonPath, "utf8"),
      ) as PackageJsonWithType;

      if (typeof packageJson.type !== "string") {
        return DEFAULT_MODULE_KIND;
      }

      return packageJson.type;
    } catch (error) {
      process.stderr.write(
        `Error reading or parsing package.json: ${String(error)}`,
      );
    }
  }

  return await determineModuleKind(path.dirname(modulePath));
}

1	import { existsSync } from "node:fs";	2✔
2	import fs from "node:fs/promises";	2✔
3	import path from "node:path";	2✔
4		2✔
5	const DEFAULT_MODULE_KIND = "commonjs";	2✔
6		2✔
7	interface PackageJsonWithType {	2✔
8	type?: string;	2✔
9	}	2✔
10	// eslint-disable-next-line max-statements	2✔
11	export async function determineModuleKind(modulePath: string) {	2✔
12	if (modulePath.endsWith(".cjs")) {	82!
NEW 13	return "commonjs";	×
NEW 14	}	×
15		82✔
16	if (modulePath.endsWith(".mjs")) {	82!
NEW 17	return "module";	×
NEW 18	}	×
19		82✔
20	if (modulePath === path.parse(modulePath).root) {	82✔
21	return DEFAULT_MODULE_KIND;	2✔
22	}	2✔
23		80✔
24	const packageJsonPath = path.join(modulePath, "package.json");	80✔
25		80✔
26	if (existsSync(packageJsonPath)) {	82✔
27	try {	44✔
28	// eslint-disable-next-line @typescript-eslint/consistent-type-assertions	44✔
29	const packageJson: PackageJsonWithType = JSON.parse(	44✔
30	await fs.readFile(packageJsonPath, "utf8"),	44✔
31	) as PackageJsonWithType;	44✔
32		44✔
33	if (typeof packageJson.type !== "string") {	44✔
34	return DEFAULT_MODULE_KIND;	2✔
35	}	2✔
36		42✔
37	return packageJson.type;	42✔
38	} catch (error) {	44!
39	process.stderr.write(	×
40	`Error reading or parsing package.json: ${String(error)}`,	×
41	);	×
42	}	×
43	}	44✔
44		36✔
45	return await determineModuleKind(path.dirname(modulePath));	36✔
46	}	36✔

pmcelhaney / counterfact / 8993935739

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous