8930533036

Committed 02 May 2024 09:12PM UTC coverage: 31.896% (+0.02%) from 31.875%

Build # 8930533036

Build Type

Pull #9216

github

Committed by

web-flow

Commit Message

Merge a8ee798d4 into 96f29fb3e

Pull Request Pull Request #9216: Merge master to lw-deploy 05 02 2024

Run Details

4726 of 38720 branches covered (12.21%)

Branch coverage included in aggregate %.

80 of 227 new or added lines in 33 files covered. (35.24%)

11 existing lines in 10 files now uncovered.

27585 of 62580 relevant lines covered (44.08%)

178.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

62.5

/packages/lesswrong/components/ea-forum/EAHomeMainContent.tsx

import React, {ComponentType, useState} from 'react'
import {Components, registerComponent} from '../../lib/vulcan-lib'
import {AnalyticsContext} from '../../lib/analyticsEvents'
import {tagPostTerms} from '../tagging/TagPage'
import {Link} from '../../lib/reactRouterWrapper'
import {TopicsBarTab} from '../common/HomeTagBar'
import {isNotNullOrUndefined} from '../../lib/utils/typeGuardUtils'
import { isFriendlyUI } from '../../themes/forumTheme'
import { PostsListViewProvider } from '../hooks/usePostsListView'

const FRONTPAGE_TAB_NAME = 'Frontpage'

const styles = (theme: ThemeType): JssStyles => ({
  spotlightMargin: {
    marginBottom: 24,
  },
  learnMoreLink: {
    fontSize: 14,
    color: theme.palette.grey[600],
    fontWeight: 600
  },
  postsListSettings: {
    display: "flex",
    alignItems: "center",
    gap: "6px",
  },
})

// The order in which the topics are displayed is slightly different from their default ordering
const topicTabsOrder = [
  'z8qFsGt5iXyZiLbjN', // Opportunities
  'sWcuTyTB5dP3nas2t', // Global health
  'QdH9f8TC6G8oGYdgt', // Animal welfare
  'oNiQsBHA3i837sySD', // AI safety
  'ZCihBFp5P64JCvQY6', // Community
  'H43gvLzBCacxxamPe', // Biosecurity & pandemics
  'ee66CtAMYurQreWBH', // Existential risk
  '4eyeLKC64Yvznzt6Z', // Philosophy
  'EHLmbEmJ2Qd5WfwTb', // Building effective altruism
  'of9xBvR3wpbp6qsZC', // Policy
  'psBzwdY8ipfCeExJ7', // Cause prioritization
  'L6NqHZkLc4xZ7YtDr', // Effective giving
  '4CH9vsvzyk4mSKwyZ', // Career choice
  'aJnrnnobcBNWRsfAw', // Forecasting & estimation
]

const sortTopics = (topics: Array<TopicsBarTab>) => 
  topicTabsOrder.map(topicId => topics.find(t => t._id === topicId)).filter(isNotNullOrUndefined)

const frontpageTab = {_id: '0', name: FRONTPAGE_TAB_NAME}

/**
 * This handles displaying the main content on the EA Forum home page,
 * which includes the topics bar and the topic-specific tabs.
 * The "Frontpage" tab content comes from EAHome.
 */
const EAHomeMainContent = ({FrontpageNode, classes}: {
  FrontpageNode: ComponentType,
  classes: ClassesType
}) => {
  const [activeTab, setActiveTab] = useState<TopicsBarTab>(frontpageTab)
  
  // 2024-01-10 SC: I've commented out this feature because we've never used it
  // and no one will tell me if they are interested in using it.
  // If you add this back in, consider refactoring to remove the useSingle.
  //
  // const {document: activeCoreTopic} = useSingle({
  //   skip: activeTab._id === frontpageTab._id,
  //   documentId: activeTab._id,
  //   collectionName: "Tags",
  //   fragmentName: "TagFragment"
  // })
  // const { results: spotLightResults } = useMulti({
  //   collectionName: 'Spotlights',
  //   fragmentName: 'SpotlightDisplay',
  //   terms: {
  //     view: 'spotlightForSequence',
  //     sequenceId: activeCoreTopic?.sequence?._id,
  //     limit: 1
  //   },
  //   skip: !activeCoreTopic?.sequence?._id,
  // });
  // const spotlight = spotLightResults?.[0]

  const topicPostTerms = {
    ...tagPostTerms(activeTab, {}),
    sortedBy: 'magic',
    limit: 30
  }

  const {
    SingleColumnSection, SectionTitle, PostsList2, HomeTagBar,
    PostsListViewToggle,
  } = Components;
  return (
    <PostsListViewProvider>
      <HomeTagBar onTagSelectionUpdated={setActiveTab} sortTopics={sortTopics} frontpageTab={frontpageTab}/>

      {activeTab.name === FRONTPAGE_TAB_NAME ? <FrontpageNode/> : <AnalyticsContext pageSectionContext="topicSpecificPosts">
        <SingleColumnSection>
          {/* {spotlight && <DismissibleSpotlightItem
            spotlight={spotlight}
            className={classes.spotlightMargin}
          />} */}
          <SectionTitle title="New & upvoted" noTopMargin>
            <div className={classes.postsListSettings}>
              <Link to={`/topics/${activeTab.slug}`} className={classes.learnMoreLink}>
                View more
              </Link>
              {isFriendlyUI && <PostsListViewToggle />}
            </div>
          </SectionTitle>
          <PostsList2
            terms={topicPostTerms}
            itemsPerPage={30}
            hideTag
            viewType="fromContext"
          />
        </SingleColumnSection>
      </AnalyticsContext>}
    </PostsListViewProvider>
  )
}

const EAHomeMainContentComponent = registerComponent('EAHomeMainContent', EAHomeMainContent, {styles});

declare global {
  interface ComponentTypes {
    EAHomeMainContent: typeof EAHomeMainContentComponent
  }
}

1	import React, {ComponentType, useState} from 'react'	1✔
2	import {Components, registerComponent} from '../../lib/vulcan-lib'	1✔
3	import {AnalyticsContext} from '../../lib/analyticsEvents'	1✔
4	import {tagPostTerms} from '../tagging/TagPage'	1✔
5	import {Link} from '../../lib/reactRouterWrapper'	1✔
6	import {TopicsBarTab} from '../common/HomeTagBar'
7	import {isNotNullOrUndefined} from '../../lib/utils/typeGuardUtils'	1✔
8	import { isFriendlyUI } from '../../themes/forumTheme'	1✔
9	import { PostsListViewProvider } from '../hooks/usePostsListView'	1✔
10
11	const FRONTPAGE_TAB_NAME = 'Frontpage'	1✔
12
13	const styles = (theme: ThemeType): JssStyles => ({	1✔
14	spotlightMargin: {
15	marginBottom: 24,
16	},
17	learnMoreLink: {
18	fontSize: 14,
19	color: theme.palette.grey[600],
20	fontWeight: 600
21	},
22	postsListSettings: {
23	display: "flex",
24	alignItems: "center",
25	gap: "6px",
26	},
27	})
28
29	// The order in which the topics are displayed is slightly different from their default ordering
30	const topicTabsOrder = [	1✔
31	'z8qFsGt5iXyZiLbjN', // Opportunities
32	'sWcuTyTB5dP3nas2t', // Global health
33	'QdH9f8TC6G8oGYdgt', // Animal welfare
34	'oNiQsBHA3i837sySD', // AI safety
35	'ZCihBFp5P64JCvQY6', // Community
36	'H43gvLzBCacxxamPe', // Biosecurity & pandemics
37	'ee66CtAMYurQreWBH', // Existential risk
38	'4eyeLKC64Yvznzt6Z', // Philosophy
39	'EHLmbEmJ2Qd5WfwTb', // Building effective altruism
40	'of9xBvR3wpbp6qsZC', // Policy
41	'psBzwdY8ipfCeExJ7', // Cause prioritization
42	'L6NqHZkLc4xZ7YtDr', // Effective giving
43	'4CH9vsvzyk4mSKwyZ', // Career choice
44	'aJnrnnobcBNWRsfAw', // Forecasting & estimation
45	]
46
47	const sortTopics = (topics: Array<TopicsBarTab>) =>	1✔
48	topicTabsOrder.map(topicId => topics.find(t => t._id === topicId)).filter(isNotNullOrUndefined)	×
49
50	const frontpageTab = {_id: '0', name: FRONTPAGE_TAB_NAME}	1✔
51
52	/**
53	* This handles displaying the main content on the EA Forum home page,
54	* which includes the topics bar and the topic-specific tabs.
55	* The "Frontpage" tab content comes from EAHome.
56	*/
57	const EAHomeMainContent = ({FrontpageNode, classes}: {	1✔
58	FrontpageNode: ComponentType,
59	classes: ClassesType
60	}) => {
61	const [activeTab, setActiveTab] = useState<TopicsBarTab>(frontpageTab)	×
62
63	// 2024-01-10 SC: I've commented out this feature because we've never used it
64	// and no one will tell me if they are interested in using it.
65	// If you add this back in, consider refactoring to remove the useSingle.
66	//
67	// const {document: activeCoreTopic} = useSingle({
68	// skip: activeTab._id === frontpageTab._id,
69	// documentId: activeTab._id,
70	// collectionName: "Tags",
71	// fragmentName: "TagFragment"
72	// })
73	// const { results: spotLightResults } = useMulti({
74	// collectionName: 'Spotlights',
75	// fragmentName: 'SpotlightDisplay',
76	// terms: {
77	// view: 'spotlightForSequence',
78	// sequenceId: activeCoreTopic?.sequence?._id,
79	// limit: 1
80	// },
81	// skip: !activeCoreTopic?.sequence?._id,
82	// });
83	// const spotlight = spotLightResults?.[0]
84
85	const topicPostTerms = {	×
86	...tagPostTerms(activeTab, {}),
87	sortedBy: 'magic',
88	limit: 30
89	}
90
91	const {
92	SingleColumnSection, SectionTitle, PostsList2, HomeTagBar,
93	PostsListViewToggle,
NEW 94	} = Components;	×
UNCOV 95	return (	×
96	<PostsListViewProvider>
97	<HomeTagBar onTagSelectionUpdated={setActiveTab} sortTopics={sortTopics} frontpageTab={frontpageTab}/>
98
99	{activeTab.name === FRONTPAGE_TAB_NAME ? <FrontpageNode/> : <AnalyticsContext pageSectionContext="topicSpecificPosts">	×
100	<SingleColumnSection>
101	{/* {spotlight && <DismissibleSpotlightItem
102	spotlight={spotlight}
103	className={classes.spotlightMargin}
104	/>} */}
105	<SectionTitle title="New & upvoted" noTopMargin>
106	<div className={classes.postsListSettings}>
107	<Link to={`/topics/${activeTab.slug}`} className={classes.learnMoreLink}>
108	View more
109	</Link>
110	{isFriendlyUI && <PostsListViewToggle />}	×
111	</div>
112	</SectionTitle>
113	<PostsList2
114	terms={topicPostTerms}
115	itemsPerPage={30}
116	hideTag
117	viewType="fromContext"
118	/>
119	</SingleColumnSection>
120	</AnalyticsContext>}
121	</PostsListViewProvider>
122	)
123	}
124
125	const EAHomeMainContentComponent = registerComponent('EAHomeMainContent', EAHomeMainContent, {styles});	1✔
126
127	declare global {
128	interface ComponentTypes {
129	EAHomeMainContent: typeof EAHomeMainContentComponent
130	}
131	}

ForumMagnum / ForumMagnum / 8930533036

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous