8908480348

Committed 01 May 2024 10:55AM UTC coverage: 31.936% (-0.002%) from 31.938%

Build # 8908480348

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #8980 from ForumMagnum/faster-login-token-lookup

Materialized view for BTREE login token lookup

Run Details

4726 of 38592 branches covered (12.25%)

Branch coverage included in aggregate %.

9 of 30 new or added lines in 6 files covered. (30.0%)

1 existing line in 1 file now uncovered.

27535 of 62425 relevant lines covered (44.11%)

178.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

36.67

/packages/lesswrong/server/postgresView.ts

import { getSqlClientOrThrow } from "../lib/sql/sqlClient";
import { queryWithLock } from "./queryWithLock";
import type { CronJobSpec } from "./cronUtil";

type PostgresViewRefreshSpec = {
  interval: string,
  query: string,
}

class PostgresView {
  constructor(
    private name: string,
    private createViewQuery: string,
    private createIndexQueries: string[] = [],
    private refreshSpec?: PostgresViewRefreshSpec,
    private queryTimeout = 60,
  ) {}

  getName(): string {
    return this.name;
  }

  getCreateViewQuery() {
    return this.createViewQuery;
  }

  async createView(db: SqlClient) {
    await queryWithLock(db, this.createViewQuery, this.queryTimeout);
  }

  async createIndexes(db: SqlClient) {
    await Promise.all(this.createIndexQueries.map((index) =>
      queryWithLock(db, index, this.queryTimeout),
    ));
  }

  async refresh(db: SqlClient) {
    if (this.refreshSpec) {
      await queryWithLock(db, this.refreshSpec.query, this.queryTimeout);
    }
  }

  registerCronJob(addCronJob: (options: CronJobSpec) => void) {
    if (this.refreshSpec) {
      addCronJob({
        name: `refreshPostgresView-${this.name}`,
        interval: this.refreshSpec.interval,
        job: () => this.refresh(getSqlClientOrThrow()),
      });
    }
  }
}

const postgresViews: PostgresView[] = [];

export const createPostgresView = (
  name: string,
  createViewQuery: string,
  createIndexQueries: string[] = [],
  refreshSpec?: PostgresViewRefreshSpec,
) => {
  for (const view of postgresViews) {
    if (view.getCreateViewQuery() === createViewQuery) {
      return;
    }
  }
  const view = new PostgresView(
    name,
    createViewQuery,
    createIndexQueries,
    refreshSpec,
  );
  postgresViews.push(view);
}

export const ensurePostgresViewsExist = async (
  db = getSqlClientOrThrow(),
  /** Dependency injected to avoid cycle. Should always be passed in unless in testing. */
  addCronJob?: (options: CronJobSpec) => void,
) => {
  await Promise.all(postgresViews.map((view) => view.createView(db)));
  await Promise.all(postgresViews.map((view) => view.createIndexes(db)));
  if (addCronJob) {
    for (const view of postgresViews) {
      view.registerCronJob(addCronJob);
    }
  }
}

export const getPostgresViewByName = (name: string): PostgresView => {
  const view = postgresViews.find((view) => view.getName() === name);
  if (!view) {
    throw new Error(`Postgres view not found: ${name}`);
  }
  return view;
}

1	import { getSqlClientOrThrow } from "../lib/sql/sqlClient";	19✔
2	import { queryWithLock } from "./queryWithLock";	19✔
3	import type { CronJobSpec } from "./cronUtil";
4
5	type PostgresViewRefreshSpec = {
6	interval: string,
7	query: string,
8	}
9
10	class PostgresView {
11	constructor(
12	private name: string,
13	private createViewQuery: string,
14	private createIndexQueries: string[] = [],
15	private refreshSpec?: PostgresViewRefreshSpec,
16	private queryTimeout = 60,
17	) {}	108!
18
19	getName(): string {
NEW 20	return this.name;	×
21	}
22
23	getCreateViewQuery() {
24	return this.createViewQuery;	54✔
25	}
26
27	async createView(db: SqlClient) {
28	await queryWithLock(db, this.createViewQuery, this.queryTimeout);	×
29	}
30
31	async createIndexes(db: SqlClient) {
32	await Promise.all(this.createIndexQueries.map((index) =>	×
33	queryWithLock(db, index, this.queryTimeout),
34	));
35	}
36
37	async refresh(db: SqlClient) {
38	if (this.refreshSpec) {
NEW 39	await queryWithLock(db, this.refreshSpec.query, this.queryTimeout);	×
40	}
41	}
42
NEW 43	registerCronJob(addCronJob: (options: CronJobSpec) => void) {	×
NEW 44	if (this.refreshSpec) {	×
NEW 45	addCronJob({	×
46	name: `refreshPostgresView-${this.name}`,
47	interval: this.refreshSpec.interval,
NEW 48	job: () => this.refresh(getSqlClientOrThrow()),	×
49	});
50	}
51	}
52	}
53
54	const postgresViews: PostgresView[] = [];	19✔
55
56	export const createPostgresView = (	19✔
57	name: string,
58	createViewQuery: string,
59	createIndexQueries: string[] = [],
60	refreshSpec?: PostgresViewRefreshSpec,
61	) => {	216✔
62	for (const view of postgresViews) {	54✔
63	if (view.getCreateViewQuery() === createViewQuery) {	54!
64	return;	×
65	}
66	}
67	const view = new PostgresView(	54✔
68	name,
69	createViewQuery,
70	createIndexQueries,
71	refreshSpec,
72	);
73	postgresViews.push(view);	54✔
74	}
75
76	export const ensurePostgresViewsExist = async (	57!
NEW 77	db = getSqlClientOrThrow(),	×
78	/** Dependency injected to avoid cycle. Should always be passed in unless in testing. */
NEW 79	addCronJob?: (options: CronJobSpec) => void,	×
80	) => {
81	await Promise.all(postgresViews.map((view) => view.createView(db)));	×
82	await Promise.all(postgresViews.map((view) => view.createIndexes(db)));	×
NEW 83	if (addCronJob) {	×
UNCOV 84	for (const view of postgresViews) {	×
NEW 85	view.registerCronJob(addCronJob);	×
86	}
87	}
88	}
89
90	export const getPostgresViewByName = (name: string): PostgresView => {	19✔
NEW 91	const view = postgresViews.find((view) => view.getName() === name);	×
NEW 92	if (!view) {	×
NEW 93	throw new Error(`Postgres view not found: ${name}`);	×
94	}
NEW 95	return view;	×
96	}

ForumMagnum / ForumMagnum / 8908480348

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous