8898131159

Committed 30 Apr 2024 04:13PM UTC coverage: 31.871% (-0.07%) from 31.937%

Build # 8898131159

Build Type

Pull #9186

github

Committed by

agnesstenlund

Commit Message

tiny padding change

Pull Request Pull Request #9186: [EA] Card view

Run Details

4721 of 38711 branches covered (12.2%)

Branch coverage included in aggregate %.

47 of 108 new or added lines in 17 files covered. (43.52%)

7 existing lines in 6 files now uncovered.

27553 of 62554 relevant lines covered (44.05%)

178.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

9.33

/packages/lesswrong/components/posts/usePostsItem.tsx

import React, { useState, useCallback, useMemo } from "react";
import { useHideRepeatedPosts } from "./HideRepeatedPostsContext";
import { RecommendationOptions, useRecordPostView } from "../hooks/useRecordPostView";
import { useCurrentUser } from "../common/withUser";
import {
  postCanDelete,
  postGetCommentCount,
  postGetLastCommentedAt,
  postGetLastCommentPromotedAt,
  postGetPageUrl,
  postGetPrimaryTag,
} from "../../lib/collections/posts/helpers";
import qs from "qs";
import type { PopperPlacementType } from "@material-ui/core/Popper"
import { AnnualReviewMarketInfo, getMarketInfo, highlightMarket } from "../../lib/annualReviewMarkets";
import { Link } from '../../lib/reactRouterWrapper';
import { commentGetPageUrl } from '../../lib/collections/comments/helpers';
import { RECOMBEE_RECOMM_ID_QUERY_PARAM, VERTEX_ATTRIBUTION_ID_QUERY_PARAM } from "./PostsPage/PostsPage";
import { recombeeEnabledSetting, vertexEnabledSetting } from "../../lib/publicSettings";
import type { PostsListViewType } from "../hooks/usePostsListView";

const isSticky = (post: PostsList, terms: PostsViewTerms) =>
  (post && terms && terms.forum)
    ? post.sticky || (terms.af && post.afSticky) || (terms.meta && post.metaSticky)
    : false;

export type PostsItemConfig = {
  /** post: The post displayed.*/
  post: PostsListWithVotes,
  /** tagRel: (Optional) The relationship between this post and a tag. If
  /* provided, UI will be shown with the score and voting on this post's
  /* relevance to that tag.*/
  tagRel?: WithVoteTagRel|null,
  /** defaultToShowComments: (bool) If set, comments will be expanded by default.*/
  defaultToShowComments?: boolean,
  /** sequenceId, chapter: If set, these will be used for making a nicer URL.*/
  sequenceId?: string,
  chapter?: any,
  /** index: If this is part of a list of PostsItems, its index (starting from
  /* zero) into that list. Used for special casing some styling at start of
  /* the list.*/
  index?: number,
  /**
   * terms: If this is part of a list generated from a query, the terms of that
   * query. Used for figuring out which sticky icons to apply, if any.
   */
  terms?: any,
  /** resumeReading: If this is a Resume Reading suggestion, the corresponding
  /* partiallyReadSequenceItem (see schema in users/schema). Used for
  /* the sequence-image background.*/
  resumeReading?: any,
  /** dismissRecommendation: If this is a Resume Reading suggestion, a callback to dismiss it.*/
  dismissRecommendation?: any,
  /** if this a draft, a callback to archive/unarchive it */
  toggleDeleteDraft?: (post: PostsList) => void,
  showBottomBorder?: boolean,
  showDraftTag?: boolean,
  showPersonalIcon?: boolean
  showIcons?: boolean,
  showPostedAt?: boolean,
  defaultToShowUnreadComments?: boolean,
  /** dense: (bool) Slightly reduce margins to make this denser. Used on the AllPosts page.*/
  dense?: boolean,
  /** bookmark: (bool) Whether this is a bookmark. Adds a clickable bookmark icon.*/
  bookmark?: boolean,
  /** showNominationCount: (bool) whether this should display it's number of Review nominations*/
  showNominationCount?: boolean,
  showReviewCount?: boolean,
  /** hideAuthor: hide the post author. Used on user-profile pages
   * where there's a list of posts all by the same author, to avoid the redundancy. */
  hideAuthor?: boolean,
  hideTag?: boolean,
  hideTrailingButtons?: boolean,
  tooltipPlacement?: PopperPlacementType,
  curatedIconLeft?: boolean,
  strikethroughTitle?: boolean,
  translucentBackground?: boolean,
  forceSticky?: boolean,
  showReadCheckbox?: boolean,
  showKarma?: boolean,
  /** If the post is curated, whether to show the curation date instead of the postedAt date. Default true. */
  useCuratedDate?: boolean,
  annualReviewMarketInfo?: AnnualReviewMarketInfo,
  showMostValuableCheckbox?: boolean,
  viewType?: PostsListViewType,
  /** Whether or not to show interactive voting arrows */
  isVoteable?: boolean,
  recombeeRecommId?: string,
  vertexAttributionId?: string,
  className?: string,
}

export type UsePostsItem = ReturnType<typeof usePostsItem>;

const areNewComments = (lastCommentedAt: Date | null, lastVisitedAt: Date | null) => {
  if (!lastCommentedAt) return false;
  if (!lastVisitedAt) return true;
  return lastVisitedAt < lastCommentedAt;
}

export const usePostsItem = ({
  post,
  tagRel = null,
  defaultToShowComments = false,
  sequenceId,
  chapter,
  terms,
  resumeReading,
  dismissRecommendation,
  toggleDeleteDraft,
  showBottomBorder = true,
  showDraftTag = true,
  showPersonalIcon = true,
  showIcons = true,
  showPostedAt = true,
  defaultToShowUnreadComments = false,
  dense = false,
  bookmark = false,
  showNominationCount = false,
  showReviewCount = false,
  hideAuthor = false,
  hideTag = false,
  hideTrailingButtons = false,
  tooltipPlacement = "bottom-end",
  curatedIconLeft = false,
  strikethroughTitle = false,
  translucentBackground = false,
  forceSticky = false,
  showReadCheckbox = false,
  showMostValuableCheckbox = false,
  viewType = "list",
  showKarma = true,
  useCuratedDate = true,
  isVoteable = false,
  recombeeRecommId,
  vertexAttributionId,
  className,
}: PostsItemConfig) => {
  const [showComments, setShowComments] = useState(defaultToShowComments);
  const [readComments, setReadComments] = useState(false);
  const [showDialogueMessages, setShowDialogueMessages] = useState(false);
  const {isRead, recordPostView} = useRecordPostView(post);
  const {isPostRepeated, addPost} = useHideRepeatedPosts();

  const currentUser = useCurrentUser();

  const recommendationEventOptions: RecommendationOptions = useMemo(() => ({
    recombeeOptions: { recommId: recombeeRecommId },
    vertexOptions: { attributionId: vertexAttributionId },
  }), [recombeeRecommId, vertexAttributionId]);

  const toggleComments = useCallback(
    () => {
      void recordPostView({ post, extraEventProperties: { type: "toggleComments" }, recommendationOptions: recommendationEventOptions });
      setShowComments(!showComments);
      setReadComments(true);
    },
    [post, recordPostView, setShowComments, showComments, setReadComments, recommendationEventOptions],
  );

  const toggleDialogueMessages = useCallback(
    () => {
      void recordPostView({ post, extraEventProperties: { type: "toggleDialogueMessages" }, recommendationOptions: recommendationEventOptions });
      setShowDialogueMessages(!showDialogueMessages);
    },
    [post, recordPostView, setShowDialogueMessages, showDialogueMessages, recommendationEventOptions],
  );

  const compareVisitedAndCommentedAt = (
    lastVisitedAt: Date | null,
    lastCommentedAt: Date | null,
  ) => {
    const newComments = areNewComments(lastCommentedAt, lastVisitedAt)
    return (isRead && newComments && !readComments);
  }

  const lastCommentedAt = postGetLastCommentedAt(post);
  const lastCommentPromotedAt = postGetLastCommentPromotedAt(post);
  const hasUnreadComments =  compareVisitedAndCommentedAt(post.lastVisitedAt, lastCommentedAt);
  const hadUnreadComments =  compareVisitedAndCommentedAt(post.lastVisitedAt, lastCommentedAt);
  const hasNewPromotedComments =  compareVisitedAndCommentedAt(post.lastVisitedAt, lastCommentPromotedAt);

  let postLink = post.draft && !post.debate
    ? `/editPost?${qs.stringify({postId: post._id, eventForm: post.isEvent})}`
    : postGetPageUrl(post, false, sequenceId || chapter?.sequenceId);

  if (recombeeRecommId && recombeeEnabledSetting.get()) {
    postLink = `${postLink}?${RECOMBEE_RECOMM_ID_QUERY_PARAM}=${recombeeRecommId}`
    // These shouldn't ever both be present at the same time
  } else if (vertexAttributionId && vertexEnabledSetting.get()) {
    postLink = `${postLink}?${VERTEX_ATTRIBUTION_ID_QUERY_PARAM}=${vertexAttributionId}`
  }

  const showDismissButton = Boolean(currentUser && resumeReading);
  const onArchive = toggleDeleteDraft && (() => toggleDeleteDraft(post));
  const showArchiveButton = Boolean(currentUser && post.draft && postCanDelete(currentUser, post) && onArchive);

  const commentTerms: CommentsViewTerms = {
    view: "postsItemComments",
    limit:7,
    postId: post._id,
    after: (defaultToShowUnreadComments && !showComments) ? post.lastVisitedAt : null
  }

  const isRepeated = isPostRepeated(post._id);
  if (!isRepeated) {
    addPost(post._id);
  }

  const analyticsProps = {
    pageElementContext: "postItem",
    postId: post._id,
    isSticky: isSticky(post, terms),
  };

  const annualReviewMarketInfo = getMarketInfo(post)

  const annualReviewMarketComment = post.annualReviewMarketComment

  const highlightMarketForLinking = !!annualReviewMarketInfo && highlightMarket(annualReviewMarketInfo) && !!annualReviewMarketComment

  const marketLink = highlightMarketForLinking && annualReviewMarketComment &&
    <Link to={commentGetPageUrl(annualReviewMarketComment)}>
      <span>{annualReviewMarketInfo.year} Top Fifty: {parseFloat((annualReviewMarketInfo.probability*100).toFixed(0))}%</span>
    </Link>

  return {
    post,
    postLink,
    commentsLink: postLink + "#comments",
    commentCount: postGetCommentCount(post),
    primaryTag: hideTag ? null : postGetPrimaryTag(post),
    tagRel,
    resumeReading,
    sticky: forceSticky || isSticky(post, terms),
    renderComments: showComments || (defaultToShowUnreadComments && hadUnreadComments),
    renderDialogueMessages: showDialogueMessages,
    condensedAndHiddenComments: defaultToShowUnreadComments && !showComments,
    toggleComments,
    toggleDialogueMessages,
    showAuthor: !post.isEvent && !hideAuthor,
    showDate: showPostedAt && !resumeReading,
    showTrailingButtons: !hideTrailingButtons,
    showMostValuableCheckbox,
    showNominationCount,
    showReviewCount,
    showIcons,
    showKarma,
    useCuratedDate,
    annualReviewMarketInfo,
    marketLink,
    showReadCheckbox,
    showDraftTag,
    showPersonalIcon,
    showBottomBorder,
    showDismissButton,
    showArchiveButton,
    onDismiss: dismissRecommendation,
    onArchive,
    hasUnreadComments,
    hasNewPromotedComments,
    commentTerms,
    isRepeated,
    analyticsProps,
    translucentBackground,
    isRead,
    tooltipPlacement,
    dense,
    curatedIconLeft,
    strikethroughTitle,
    viewType,
    bookmark,
    isVoteable,
    className,
  };
}

1	import React, { useState, useCallback, useMemo } from "react";	3✔
2	import { useHideRepeatedPosts } from "./HideRepeatedPostsContext";	1✔
3	import { RecommendationOptions, useRecordPostView } from "../hooks/useRecordPostView";	1✔
4	import { useCurrentUser } from "../common/withUser";	1✔
5	import {
6	postCanDelete,
7	postGetCommentCount,
8	postGetLastCommentedAt,
9	postGetLastCommentPromotedAt,
10	postGetPageUrl,
11	postGetPrimaryTag,
12	} from "../../lib/collections/posts/helpers";	1✔
13	import qs from "qs";	1✔
14	import type { PopperPlacementType } from "@material-ui/core/Popper"
15	import { AnnualReviewMarketInfo, getMarketInfo, highlightMarket } from "../../lib/annualReviewMarkets";	1✔
16	import { Link } from '../../lib/reactRouterWrapper';	1✔
17	import { commentGetPageUrl } from '../../lib/collections/comments/helpers';	1✔
18	import { RECOMBEE_RECOMM_ID_QUERY_PARAM, VERTEX_ATTRIBUTION_ID_QUERY_PARAM } from "./PostsPage/PostsPage";	1✔
19	import { recombeeEnabledSetting, vertexEnabledSetting } from "../../lib/publicSettings";	1✔
20	import type { PostsListViewType } from "../hooks/usePostsListView";
21
22	const isSticky = (post: PostsList, terms: PostsViewTerms) =>	1✔
23	(post && terms && terms.forum)	×
24	? post.sticky \|\| (terms.af && post.afSticky) \|\| (terms.meta && post.metaSticky)	×
25	: false;
26
27	export type PostsItemConfig = {
28	/** post: The post displayed.*/
29	post: PostsListWithVotes,
30	/** tagRel: (Optional) The relationship between this post and a tag. If
31	/* provided, UI will be shown with the score and voting on this post's
32	/* relevance to that tag.*/
33	tagRel?: WithVoteTagRel\|null,
34	/** defaultToShowComments: (bool) If set, comments will be expanded by default.*/
35	defaultToShowComments?: boolean,
36	/** sequenceId, chapter: If set, these will be used for making a nicer URL.*/
37	sequenceId?: string,
38	chapter?: any,
39	/** index: If this is part of a list of PostsItems, its index (starting from
40	/* zero) into that list. Used for special casing some styling at start of
41	/* the list.*/
42	index?: number,
43	/**
44	* terms: If this is part of a list generated from a query, the terms of that
45	* query. Used for figuring out which sticky icons to apply, if any.
46	*/
47	terms?: any,
48	/** resumeReading: If this is a Resume Reading suggestion, the corresponding
49	/* partiallyReadSequenceItem (see schema in users/schema). Used for
50	/* the sequence-image background.*/
51	resumeReading?: any,
52	/** dismissRecommendation: If this is a Resume Reading suggestion, a callback to dismiss it.*/
53	dismissRecommendation?: any,
54	/** if this a draft, a callback to archive/unarchive it */
55	toggleDeleteDraft?: (post: PostsList) => void,
56	showBottomBorder?: boolean,
57	showDraftTag?: boolean,
58	showPersonalIcon?: boolean
59	showIcons?: boolean,
60	showPostedAt?: boolean,
61	defaultToShowUnreadComments?: boolean,
62	/** dense: (bool) Slightly reduce margins to make this denser. Used on the AllPosts page.*/
63	dense?: boolean,
64	/** bookmark: (bool) Whether this is a bookmark. Adds a clickable bookmark icon.*/
65	bookmark?: boolean,
66	/** showNominationCount: (bool) whether this should display it's number of Review nominations*/
67	showNominationCount?: boolean,
68	showReviewCount?: boolean,
69	/** hideAuthor: hide the post author. Used on user-profile pages
70	* where there's a list of posts all by the same author, to avoid the redundancy. */
71	hideAuthor?: boolean,
72	hideTag?: boolean,
73	hideTrailingButtons?: boolean,
74	tooltipPlacement?: PopperPlacementType,
75	curatedIconLeft?: boolean,
76	strikethroughTitle?: boolean,
77	translucentBackground?: boolean,
78	forceSticky?: boolean,
79	showReadCheckbox?: boolean,
80	showKarma?: boolean,
81	/** If the post is curated, whether to show the curation date instead of the postedAt date. Default true. */
82	useCuratedDate?: boolean,
83	annualReviewMarketInfo?: AnnualReviewMarketInfo,
84	showMostValuableCheckbox?: boolean,
85	viewType?: PostsListViewType,
86	/** Whether or not to show interactive voting arrows */
87	isVoteable?: boolean,
88	recombeeRecommId?: string,
89	vertexAttributionId?: string,
90	className?: string,
91	}
92
93	export type UsePostsItem = ReturnType<typeof usePostsItem>;
94
95	const areNewComments = (lastCommentedAt: Date \| null, lastVisitedAt: Date \| null) => {	1✔
96	if (!lastCommentedAt) return false;	×
97	if (!lastVisitedAt) return true;	×
98	return lastVisitedAt < lastCommentedAt;	×
99	}
100
101	export const usePostsItem = ({	1✔
102	post,
103	tagRel = null,	×
104	defaultToShowComments = false,	×
105	sequenceId,
106	chapter,
107	terms,
108	resumeReading,
109	dismissRecommendation,
110	toggleDeleteDraft,
111	showBottomBorder = true,	×
112	showDraftTag = true,	×
113	showPersonalIcon = true,	×
114	showIcons = true,	×
115	showPostedAt = true,	×
116	defaultToShowUnreadComments = false,	×
117	dense = false,	×
118	bookmark = false,	×
119	showNominationCount = false,	×
120	showReviewCount = false,	×
121	hideAuthor = false,	×
122	hideTag = false,	×
123	hideTrailingButtons = false,	×
124	tooltipPlacement = "bottom-end",	×
125	curatedIconLeft = false,	×
126	strikethroughTitle = false,	×
127	translucentBackground = false,	×
128	forceSticky = false,	×
129	showReadCheckbox = false,	×
130	showMostValuableCheckbox = false,	×
131	viewType = "list",	×
132	showKarma = true,	×
133	useCuratedDate = true,	×
134	isVoteable = false,	×
135	recombeeRecommId,
136	vertexAttributionId,
137	className,
138	}: PostsItemConfig) => {
139	const [showComments, setShowComments] = useState(defaultToShowComments);	×
140	const [readComments, setReadComments] = useState(false);	×
141	const [showDialogueMessages, setShowDialogueMessages] = useState(false);	×
142	const {isRead, recordPostView} = useRecordPostView(post);	×
143	const {isPostRepeated, addPost} = useHideRepeatedPosts();	×
144
145	const currentUser = useCurrentUser();	×
146
147	const recommendationEventOptions: RecommendationOptions = useMemo(() => ({	×
148	recombeeOptions: { recommId: recombeeRecommId },
149	vertexOptions: { attributionId: vertexAttributionId },
150	}), [recombeeRecommId, vertexAttributionId]);
151
152	const toggleComments = useCallback(	×
153	() => {
154	void recordPostView({ post, extraEventProperties: { type: "toggleComments" }, recommendationOptions: recommendationEventOptions });	×
155	setShowComments(!showComments);	×
156	setReadComments(true);	×
157	},
158	[post, recordPostView, setShowComments, showComments, setReadComments, recommendationEventOptions],
159	);
160
161	const toggleDialogueMessages = useCallback(	×
162	() => {
163	void recordPostView({ post, extraEventProperties: { type: "toggleDialogueMessages" }, recommendationOptions: recommendationEventOptions });	×
164	setShowDialogueMessages(!showDialogueMessages);	×
165	},
166	[post, recordPostView, setShowDialogueMessages, showDialogueMessages, recommendationEventOptions],
167	);
168
169	const compareVisitedAndCommentedAt = (	×
170	lastVisitedAt: Date \| null,
171	lastCommentedAt: Date \| null,
172	) => {
173	const newComments = areNewComments(lastCommentedAt, lastVisitedAt)	×
174	return (isRead && newComments && !readComments);	×
175	}
176
177	const lastCommentedAt = postGetLastCommentedAt(post);	×
178	const lastCommentPromotedAt = postGetLastCommentPromotedAt(post);	×
179	const hasUnreadComments = compareVisitedAndCommentedAt(post.lastVisitedAt, lastCommentedAt);	×
180	const hadUnreadComments = compareVisitedAndCommentedAt(post.lastVisitedAt, lastCommentedAt);	×
181	const hasNewPromotedComments = compareVisitedAndCommentedAt(post.lastVisitedAt, lastCommentPromotedAt);	×
182
183	let postLink = post.draft && !post.debate	×
184	? `/editPost?${qs.stringify({postId: post._id, eventForm: post.isEvent})}`	×
185	: postGetPageUrl(post, false, sequenceId \|\| chapter?.sequenceId);	×
186
187	if (recombeeRecommId && recombeeEnabledSetting.get()) {	×
188	postLink = `${postLink}?${RECOMBEE_RECOMM_ID_QUERY_PARAM}=${recombeeRecommId}`	×
189	// These shouldn't ever both be present at the same time
190	} else if (vertexAttributionId && vertexEnabledSetting.get()) {	×
191	postLink = `${postLink}?${VERTEX_ATTRIBUTION_ID_QUERY_PARAM}=${vertexAttributionId}`	×
192	}
193
194	const showDismissButton = Boolean(currentUser && resumeReading);	×
195	const onArchive = toggleDeleteDraft && (() => toggleDeleteDraft(post));	×
196	const showArchiveButton = Boolean(currentUser && post.draft && postCanDelete(currentUser, post) && onArchive);	×
197
198	const commentTerms: CommentsViewTerms = {	×
199	view: "postsItemComments",
200	limit:7,
201	postId: post._id,
202	after: (defaultToShowUnreadComments && !showComments) ? post.lastVisitedAt : null	×
203	}
204
205	const isRepeated = isPostRepeated(post._id);	×
206	if (!isRepeated) {	×
207	addPost(post._id);	×
208	}
209
210	const analyticsProps = {	×
211	pageElementContext: "postItem",
212	postId: post._id,
213	isSticky: isSticky(post, terms),
214	};
215
216	const annualReviewMarketInfo = getMarketInfo(post)	×
217
218	const annualReviewMarketComment = post.annualReviewMarketComment	×
219
220	const highlightMarketForLinking = !!annualReviewMarketInfo && highlightMarket(annualReviewMarketInfo) && !!annualReviewMarketComment	×
221
222	const marketLink = highlightMarketForLinking && annualReviewMarketComment &&	×
223	<Link to={commentGetPageUrl(annualReviewMarketComment)}>
224	<span>{annualReviewMarketInfo.year} Top Fifty: {parseFloat((annualReviewMarketInfo.probability*100).toFixed(0))}%</span>
225	</Link>
226
UNCOV 227	return {	×
228	post,
229	postLink,
230	commentsLink: postLink + "#comments",
231	commentCount: postGetCommentCount(post),
232	primaryTag: hideTag ? null : postGetPrimaryTag(post),	×
233	tagRel,
234	resumeReading,
235	sticky: forceSticky \|\| isSticky(post, terms),	×
236	renderComments: showComments \|\| (defaultToShowUnreadComments && hadUnreadComments),	×
237	renderDialogueMessages: showDialogueMessages,
238	condensedAndHiddenComments: defaultToShowUnreadComments && !showComments,	×
239	toggleComments,
240	toggleDialogueMessages,
241	showAuthor: !post.isEvent && !hideAuthor,	×
242	showDate: showPostedAt && !resumeReading,	×
243	showTrailingButtons: !hideTrailingButtons,
244	showMostValuableCheckbox,
245	showNominationCount,
246	showReviewCount,
247	showIcons,
248	showKarma,
249	useCuratedDate,
250	annualReviewMarketInfo,
251	marketLink,
252	showReadCheckbox,
253	showDraftTag,
254	showPersonalIcon,
255	showBottomBorder,
256	showDismissButton,
257	showArchiveButton,
258	onDismiss: dismissRecommendation,
259	onArchive,
260	hasUnreadComments,
261	hasNewPromotedComments,
262	commentTerms,
263	isRepeated,
264	analyticsProps,
265	translucentBackground,
266	isRead,
267	tooltipPlacement,
268	dense,
269	curatedIconLeft,
270	strikethroughTitle,
271	viewType,
272	bookmark,
273	isVoteable,
274	className,
275	};
276	}

ForumMagnum / ForumMagnum / 8898131159

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous