8897425903

Committed 30 Apr 2024 03:23PM UTC coverage: 31.984% (+0.03%) from 31.952%

Build # 8897425903

Build Type

Pull #9197

github

Committed by

Will-Howard

Commit Message

comments

Pull Request Pull Request #9197: [Draft] Standardise rendering of dates and times

Run Details

4746 of 38553 branches covered (12.31%)

Branch coverage included in aggregate %.

60 of 106 new or added lines in 27 files covered. (56.6%)

24 existing lines in 9 files now uncovered.

27538 of 62385 relevant lines covered (44.14%)

179.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

19.57

/packages/lesswrong/components/posts/PostsItemMeta.tsx

import { Components, registerComponent} from '../../lib/vulcan-lib';
import React, { FC } from 'react';
import classNames from 'classnames';
import { isAF } from '../../lib/instanceSettings';
import { AnalyticsContext } from '../../lib/analyticsEvents'

const styles = (theme: ThemeType): JssStyles => ({
  read: {
    opacity: ".8"
  },
  karma: {
    minWidth:20,
    textAlign: "center",
    display: "inline-block",
  },
  info: {
    display: "inline",
    color: theme.palette.text.dim3,
    marginRight: theme.spacing.unit,
    fontSize: "1.1rem",
    ...theme.typography.commentStyle
  },
  calendarIcon: {
    marginRight: theme.spacing.unit
  }
})

export const DateWithoutTime: FC<{date: Date}> = ({date}) => {
  const { FormatDate } = Components;
  return <FormatDate date={date} format={"MMM Do"} />
}

const PostsItemMeta = ({post, read, hideTags, classes}: {
  post: PostsList,
  read?: boolean,
  hideTags?: boolean,
  classes: ClassesType,
}) => {
  const baseScore = isAF ? post.afBaseScore : post.baseScore
  const showAfScore = (!isAF && post.af);
  const afBaseScore = showAfScore ? post.afBaseScore : null
  const { FormatDate, FooterTagList, PostsUserAndCoauthors, LWTooltip, AddToCalendarButton } = Components;
  return <span className={classNames({[classes.read]:read})}>

      {!post.shortform && !post.isEvent && <span className={classes.info}>
        <LWTooltip title={<div>
          This post has { baseScore || 0 } karma<br/>
          ({ post.voteCount} votes)
        </div>}>
          <span className={classes.karma}>
            { baseScore || 0 }
          </span>
        </LWTooltip>
      </span>}

      { post.isEvent && <span className={classes.info}>
        {post.startTime && (
          <span className={classes.calendarIcon}>
            <AddToCalendarButton post={post} />
          </span>
        )}
        {post.startTime
          ? <LWTooltip title={<Components.EventTime post={post} />}>
              <DateWithoutTime date={post.startTime} />
            </LWTooltip>
          : <LWTooltip title={<span>To Be Determined</span>}>
              <span>TBD</span>
            </LWTooltip>}
      </span>}

      { post.isEvent && !post.onlineEvent && <span className={classes.info}>
        <Components.EventVicinity post={post} />
      </span>}

      <span className={classes.info}>
        <PostsUserAndCoauthors post={post} showMarkers />
      </span>

      { showAfScore && <span className={classes.info}>
        <LWTooltip title={<div>
          { afBaseScore } karma on alignmentforum.org
        </div>}>
          <span>Ω { afBaseScore }</span>
        </LWTooltip>
      </span>}

      {!post.isEvent && !hideTags && <span className={classes.info}>
        <AnalyticsContext pageElementContext="tagsList">
          <FooterTagList post={post} hideScore hideAddTag smallText/>
        </AnalyticsContext>
      </span>}

      {post.postedAt && !post.isEvent && <span className={classes.info}>
        <FormatDate date={post.postedAt}/>
      </span>}
    </span>
};

const PostsItemMetaComponent = registerComponent('PostsItemMeta', PostsItemMeta, {styles});

declare global {
  interface ComponentTypes {
    PostsItemMeta: typeof PostsItemMetaComponent
  }
}

1	import { Components, registerComponent} from '../../lib/vulcan-lib';	3✔
2	import React, { FC } from 'react';	1✔
3	import classNames from 'classnames';	1✔
4	import { isAF } from '../../lib/instanceSettings';	1✔
5	import { AnalyticsContext } from '../../lib/analyticsEvents'	1✔
6
7	const styles = (theme: ThemeType): JssStyles => ({	1✔
8	read: {
9	opacity: ".8"
10	},
11	karma: {
12	minWidth:20,
13	textAlign: "center",
14	display: "inline-block",
15	},
16	info: {
17	display: "inline",
18	color: theme.palette.text.dim3,
19	marginRight: theme.spacing.unit,
20	fontSize: "1.1rem",
21	...theme.typography.commentStyle
22	},
23	calendarIcon: {
24	marginRight: theme.spacing.unit
25	}
26	})
27
28	export const DateWithoutTime: FC<{date: Date}> = ({date}) => {	1✔
NEW 29	const { FormatDate } = Components;	×
NEW 30	return <FormatDate date={date} format={"MMM Do"} />	×
31	}
32
33	const PostsItemMeta = ({post, read, hideTags, classes}: {	1✔
34	post: PostsList,
35	read?: boolean,
36	hideTags?: boolean,
37	classes: ClassesType,
38	}) => {
39	const baseScore = isAF ? post.afBaseScore : post.baseScore	×
40	const showAfScore = (!isAF && post.af);	×
41	const afBaseScore = showAfScore ? post.afBaseScore : null	×
42	const { FormatDate, FooterTagList, PostsUserAndCoauthors, LWTooltip, AddToCalendarButton } = Components;	×
43	return <span className={classNames({[classes.read]:read})}>	×
44
45	{!post.shortform && !post.isEvent && <span className={classes.info}>	×
46	<LWTooltip title={<div>
47	This post has { baseScore \|\| 0 } karma<br/>	×
48	({ post.voteCount} votes)
49	</div>}>
50	<span className={classes.karma}>
51	{ baseScore \|\| 0 }	×
52	</span>
53	</LWTooltip>
54	</span>}
55
56	{ post.isEvent && <span className={classes.info}>	×
57	{post.startTime && (	×
58	<span className={classes.calendarIcon}>
59	<AddToCalendarButton post={post} />
60	</span>
61	)}
62	{post.startTime
63	? <LWTooltip title={<Components.EventTime post={post} />}>	×
64	<DateWithoutTime date={post.startTime} />
65	</LWTooltip>
66	: <LWTooltip title={<span>To Be Determined</span>}>
67	<span>TBD</span>
68	</LWTooltip>}
69	</span>}
70
71	{ post.isEvent && !post.onlineEvent && <span className={classes.info}>	×
72	<Components.EventVicinity post={post} />
73	</span>}
74
75	<span className={classes.info}>
76	<PostsUserAndCoauthors post={post} showMarkers />
77	</span>
78
79	{ showAfScore && <span className={classes.info}>	×
80	<LWTooltip title={<div>
81	{ afBaseScore } karma on alignmentforum.org
82	</div>}>
83	<span>Ω { afBaseScore }</span>
84	</LWTooltip>
85	</span>}
86
87	{!post.isEvent && !hideTags && <span className={classes.info}>	×
88	<AnalyticsContext pageElementContext="tagsList">
89	<FooterTagList post={post} hideScore hideAddTag smallText/>
90	</AnalyticsContext>
91	</span>}
92
93	{post.postedAt && !post.isEvent && <span className={classes.info}>	×
94	<FormatDate date={post.postedAt}/>
95	</span>}
96	</span>
97	};
98
99	const PostsItemMetaComponent = registerComponent('PostsItemMeta', PostsItemMeta, {styles});	1✔
100
101	declare global {
102	interface ComponentTypes {
103	PostsItemMeta: typeof PostsItemMetaComponent
104	}
105	}

ForumMagnum / ForumMagnum / 8897425903

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous