8895536479

Committed 30 Apr 2024 12:32PM UTC coverage: 92.164% (-0.02%) from 92.18%

Build # 8895536479

Build Type

push

github

Committed by

web-flow

Commit Message

Change AddressInfo empty string values to explicit nulls (#1494)

Changes the behavior of `AddressInfo` to explicitly return `null` instead of an empty string for `AddressInfo.name` and `AddressInfo.logoUri`.

Run Details

1923 of 2356 branches covered (81.62%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

6898 of 7215 relevant lines covered (95.61%)

308.24 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.41

/src/routes/transactions/mappers/common/transaction-info.mapper.ts

import { Inject, Injectable } from '@nestjs/common';
import { IConfigurationService } from '@/config/configuration.service.interface';
import { ModuleTransaction } from '@/domain/safe/entities/module-transaction.entity';
import { MultisigTransaction } from '@/domain/safe/entities/multisig-transaction.entity';
import { Operation } from '@/domain/safe/entities/operation.entity';
import { TokenRepository } from '@/domain/tokens/token.repository';
import { ITokenRepository } from '@/domain/tokens/token.repository.interface';
import { TokenType } from '@/routes/balances/entities/token-type.entity';
import { DataDecodedParameter } from '@/routes/data-decode/entities/data-decoded-parameter.entity';
import { DataDecoded } from '@/routes/data-decode/entities/data-decoded.entity';
import { SettingsChangeTransaction } from '@/routes/transactions/entities/settings-change-transaction.entity';
import { TransactionInfo } from '@/routes/transactions/entities/transaction-info.entity';
import { CustomTransactionMapper } from '@/routes/transactions/mappers/common/custom-transaction.mapper';
import { DataDecodedParamHelper } from '@/routes/transactions/mappers/common/data-decoded-param.helper';
import { Erc20TransferMapper } from '@/routes/transactions/mappers/common/erc20-transfer.mapper';
import { Erc721TransferMapper } from '@/routes/transactions/mappers/common/erc721-transfer.mapper';
import { HumanDescriptionMapper } from '@/routes/transactions/mappers/common/human-description.mapper';
import { NativeCoinTransferMapper } from '@/routes/transactions/mappers/common/native-coin-transfer.mapper';
import { SettingsChangeMapper } from '@/routes/transactions/mappers/common/settings-change.mapper';
import { SwapOrderMapper } from '@/routes/transactions/mappers/common/swap-order.mapper';
import { isHex } from 'viem';
import { ILoggingService, LoggingService } from '@/logging/logging.interface';
import { SwapOrderTransactionInfo } from '@/routes/transactions/entities/swaps/swap-order-info.entity';
import { SwapOrderHelper } from '@/routes/transactions/helpers/swap-order.helper';

@Injectable()
export class MultisigTransactionInfoMapper {
  private readonly TRANSFER_METHOD = 'transfer';
  private readonly TRANSFER_FROM_METHOD = 'transferFrom';
  private readonly SAFE_TRANSFER_FROM_METHOD = 'safeTransferFrom';
  private readonly isRichFragmentsEnabled: boolean;
  private readonly isSwapsDecodingEnabled: boolean;

  private readonly ERC20_TRANSFER_METHODS = [
    this.TRANSFER_METHOD,
    this.TRANSFER_FROM_METHOD,
  ];

  private readonly ERC721_TRANSFER_METHODS = [
    this.TRANSFER_METHOD,
    this.TRANSFER_FROM_METHOD,
    this.SAFE_TRANSFER_FROM_METHOD,
  ];

  constructor(
    @Inject(ITokenRepository) private readonly tokenRepository: TokenRepository,
    @Inject(IConfigurationService)
    private readonly configurationService: IConfigurationService,
    @Inject(LoggingService) private readonly loggingService: ILoggingService,
    private readonly dataDecodedParamHelper: DataDecodedParamHelper,
    private readonly customTransactionMapper: CustomTransactionMapper,
    private readonly settingsChangeMapper: SettingsChangeMapper,
    private readonly nativeCoinTransferMapper: NativeCoinTransferMapper,
    private readonly erc20TransferMapper: Erc20TransferMapper,
    private readonly erc721TransferMapper: Erc721TransferMapper,
    private readonly humanDescriptionMapper: HumanDescriptionMapper,
    private readonly swapOrderMapper: SwapOrderMapper,
    private readonly swapOrderHelper: SwapOrderHelper,
  ) {
    this.isRichFragmentsEnabled = this.configurationService.getOrThrow(
      'features.richFragments',
    );
    this.isSwapsDecodingEnabled = this.configurationService.getOrThrow(
      'features.swapsDecoding',
    );
  }

  async mapTransactionInfo(
    chainId: string,
    transaction: MultisigTransaction | ModuleTransaction,
  ): Promise<TransactionInfo> {
    const value = Number(transaction?.value) || 0;
    const dataByteLength = transaction.data
      ? Buffer.byteLength(transaction.data)
      : 0;

    const dataSize =
      dataByteLength >= 2 ? Math.floor((dataByteLength - 2) / 2) : 0;

    const richDecodedInfo =
      await this.humanDescriptionMapper.mapRichDecodedInfo(
        transaction,
        chainId,
      );

    const humanDescription =
      this.humanDescriptionMapper.mapHumanDescription(richDecodedInfo);

    // If the rich fragment feature is disabled, we set it as undefined.
    // Undefined properties are not rendered on the response
    const richDecodedInfoApiProperty = this.isRichFragmentsEnabled
      ? richDecodedInfo
      : undefined;

    if (this.isSwapsDecodingEnabled) {
      const swapOrder: SwapOrderTransactionInfo | null =
        await this.mapSwapOrder(chainId, transaction);
      // If the transaction is a swap order, we return it immediately
      if (swapOrder) return swapOrder;
    }

    if (this.isCustomTransaction(value, dataSize, transaction.operation)) {
      return await this.customTransactionMapper.mapCustomTransaction(
        transaction,
        dataSize,
        chainId,
        humanDescription,
        richDecodedInfoApiProperty,
      );
    }

    if (this.isNativeCoinTransfer(value, dataSize)) {
      return this.nativeCoinTransferMapper.mapNativeCoinTransfer(
        chainId,
        transaction,
        humanDescription,
        richDecodedInfoApiProperty,
      );
    }

    if (this.isSettingsChange(transaction, value, dataSize)) {
      const settingsInfo = await this.settingsChangeMapper.mapSettingsChange(
        chainId,
        transaction,
      );

      if (!transaction.dataDecoded) {
        throw new Error(
          `Data decoded is null. txHash=${transaction.transactionHash}`,
        );
      }

      const dataDecodedParameters: DataDecodedParameter[] | null =
        transaction.dataDecoded.parameters?.map(
          (parameter) =>
            new DataDecodedParameter(
              parameter.name,
              parameter.type,
              parameter.value,
              parameter.valueDecoded,
            ),
        ) ?? null;

      return new SettingsChangeTransaction(
        new DataDecoded(transaction.dataDecoded.method, dataDecodedParameters),
        settingsInfo,
        humanDescription,
        richDecodedInfoApiProperty,
      );
    }

    if (this.isValidTokenTransfer(transaction)) {
      const token = await this.tokenRepository
        .getToken({ chainId, address: transaction.to })
        .catch(() => null);

      switch (token?.type) {
        case TokenType.Erc20:
          return this.erc20TransferMapper.mapErc20Transfer(
            token,
            chainId,
            transaction,
            humanDescription,
            richDecodedInfoApiProperty,
          );
        case TokenType.Erc721:
          return this.erc721TransferMapper.mapErc721Transfer(
            token,
            chainId,
            transaction,
            humanDescription,
            richDecodedInfoApiProperty,
          );
      }
    }

    return this.customTransactionMapper.mapCustomTransaction(
      transaction,
      dataSize,
      chainId,
      humanDescription,
      richDecodedInfoApiProperty,
    );
  }

  /**
   * Maps a swap order transaction.
   * If the transaction is not a swap order, it returns null.
   *
   * @param chainId
   * @param transaction
   * @private
   */
  private async mapSwapOrder(
    chainId: string,
    transaction: MultisigTransaction | ModuleTransaction,
  ): Promise<SwapOrderTransactionInfo | null> {
    if (!transaction?.data || !isHex(transaction.data)) {
      return null;
    }

    const orderData: `0x${string}` | null = this.swapOrderHelper.findSwapOrder(
      transaction.data,
    );

    if (!orderData) {
      return null;
    }

    try {
      return await this.swapOrderMapper.mapSwapOrder(chainId, {
        data: orderData,
      });
    } catch (error) {
      // The transaction is a swap order, but we couldn't decode it successfully.
      this.loggingService.warn(error);
      return null;
    }
  }

  private isCustomTransaction(
    value: number,
    dataSize: number,
    operation: Operation,
  ): boolean {
    return (value > 0 && dataSize > 0) || operation !== 0;
  }

  private isNativeCoinTransfer(value: number, dataSize: number): boolean {
    return value > 0 && dataSize === 0;
  }

  private isSettingsChange(
    transaction: MultisigTransaction | ModuleTransaction,
    value: number,
    dataSize: number,
  ): boolean {
    const isSettingsChangeMethod: boolean = transaction.dataDecoded
      ? SettingsChangeMapper.SETTINGS_CHANGE_METHODS.includes(
          transaction.dataDecoded.method,
        )
      : false;

    return (
      value === 0 &&
      dataSize > 0 &&
      transaction.safe === transaction.to &&
      isSettingsChangeMethod
    );
  }

  private isValidTokenTransfer(
    transaction: MultisigTransaction | ModuleTransaction,
  ): boolean {
    return (
      (this.isErc20Transfer(transaction) ||
        this.isErc721Transfer(transaction)) &&
      this.isSafeSenderOrReceiver(transaction)
    );
  }

  private isErc20Transfer(
    transaction: MultisigTransaction | ModuleTransaction,
  ): boolean {
    const { dataDecoded } = transaction;
    return this.ERC20_TRANSFER_METHODS.some(
      (method) => method === dataDecoded?.method,
    );
  }

  private isErc721Transfer(
    transaction: MultisigTransaction | ModuleTransaction,
  ): boolean {
    const { dataDecoded } = transaction;
    return this.ERC721_TRANSFER_METHODS.some(
      (method) => method === dataDecoded?.method,
    );
  }

  private isSafeSenderOrReceiver(
    transaction: MultisigTransaction | ModuleTransaction,
  ): boolean {
    const { dataDecoded } = transaction;
    if (!dataDecoded) return false;
    return (
      this.TRANSFER_METHOD == dataDecoded.method ||
      this.dataDecodedParamHelper.getFromParam(dataDecoded, '') ===
        transaction.safe ||
      this.dataDecodedParamHelper.getToParam(dataDecoded, '') ===
        transaction.safe
    );
  }
}

1	import { Inject, Injectable } from '@nestjs/common';	102✔
2	import { IConfigurationService } from '@/config/configuration.service.interface';	102✔
3	import { ModuleTransaction } from '@/domain/safe/entities/module-transaction.entity';
4	import { MultisigTransaction } from '@/domain/safe/entities/multisig-transaction.entity';
5	import { Operation } from '@/domain/safe/entities/operation.entity';
6	import { TokenRepository } from '@/domain/tokens/token.repository';	102✔
7	import { ITokenRepository } from '@/domain/tokens/token.repository.interface';	102✔
8	import { TokenType } from '@/routes/balances/entities/token-type.entity';	102✔
9	import { DataDecodedParameter } from '@/routes/data-decode/entities/data-decoded-parameter.entity';	102✔
10	import { DataDecoded } from '@/routes/data-decode/entities/data-decoded.entity';	102✔
11	import { SettingsChangeTransaction } from '@/routes/transactions/entities/settings-change-transaction.entity';	102✔
12	import { TransactionInfo } from '@/routes/transactions/entities/transaction-info.entity';
13	import { CustomTransactionMapper } from '@/routes/transactions/mappers/common/custom-transaction.mapper';	102✔
14	import { DataDecodedParamHelper } from '@/routes/transactions/mappers/common/data-decoded-param.helper';	102✔
15	import { Erc20TransferMapper } from '@/routes/transactions/mappers/common/erc20-transfer.mapper';	102✔
16	import { Erc721TransferMapper } from '@/routes/transactions/mappers/common/erc721-transfer.mapper';	102✔
17	import { HumanDescriptionMapper } from '@/routes/transactions/mappers/common/human-description.mapper';	102✔
18	import { NativeCoinTransferMapper } from '@/routes/transactions/mappers/common/native-coin-transfer.mapper';	102✔
19	import { SettingsChangeMapper } from '@/routes/transactions/mappers/common/settings-change.mapper';	102✔
20	import { SwapOrderMapper } from '@/routes/transactions/mappers/common/swap-order.mapper';	102✔
21	import { isHex } from 'viem';	102✔
22	import { ILoggingService, LoggingService } from '@/logging/logging.interface';	102✔
23	import { SwapOrderTransactionInfo } from '@/routes/transactions/entities/swaps/swap-order-info.entity';
24	import { SwapOrderHelper } from '@/routes/transactions/helpers/swap-order.helper';	102✔
25
26	@Injectable()
27	export class MultisigTransactionInfoMapper {	102✔
28	private readonly TRANSFER_METHOD = 'transfer';	1,236✔
29	private readonly TRANSFER_FROM_METHOD = 'transferFrom';	1,236✔
30	private readonly SAFE_TRANSFER_FROM_METHOD = 'safeTransferFrom';	1,236✔
31	private readonly isRichFragmentsEnabled: boolean;
32	private readonly isSwapsDecodingEnabled: boolean;
33
34	private readonly ERC20_TRANSFER_METHODS = [	1,236✔
35	this.TRANSFER_METHOD,
36	this.TRANSFER_FROM_METHOD,
37	];
38
39	private readonly ERC721_TRANSFER_METHODS = [	1,236✔
40	this.TRANSFER_METHOD,
41	this.TRANSFER_FROM_METHOD,
42	this.SAFE_TRANSFER_FROM_METHOD,
43	];
44
45	constructor(
46	@Inject(ITokenRepository) private readonly tokenRepository: TokenRepository,	1,236✔
47	@Inject(IConfigurationService)
48	private readonly configurationService: IConfigurationService,	1,236✔
49	@Inject(LoggingService) private readonly loggingService: ILoggingService,	1,236✔
50	private readonly dataDecodedParamHelper: DataDecodedParamHelper,	1,236✔
51	private readonly customTransactionMapper: CustomTransactionMapper,	1,236✔
52	private readonly settingsChangeMapper: SettingsChangeMapper,	1,236✔
53	private readonly nativeCoinTransferMapper: NativeCoinTransferMapper,	1,236✔
54	private readonly erc20TransferMapper: Erc20TransferMapper,	1,236✔
55	private readonly erc721TransferMapper: Erc721TransferMapper,	1,236✔
56	private readonly humanDescriptionMapper: HumanDescriptionMapper,	1,236✔
57	private readonly swapOrderMapper: SwapOrderMapper,	1,236✔
58	private readonly swapOrderHelper: SwapOrderHelper,	1,236✔
59	) {
60	this.isRichFragmentsEnabled = this.configurationService.getOrThrow(	1,236✔
61	'features.richFragments',
62	);
63	this.isSwapsDecodingEnabled = this.configurationService.getOrThrow(	1,236✔
64	'features.swapsDecoding',
65	);
66	}
67
68	async mapTransactionInfo(
69	chainId: string,
70	transaction: MultisigTransaction \| ModuleTransaction,
71	): Promise<TransactionInfo> {
72	const value = Number(transaction?.value) \|\| 0;	78✔
73	const dataByteLength = transaction.data	78✔
74	? Buffer.byteLength(transaction.data)
75	: 0;
76
77	const dataSize =
78	dataByteLength >= 2 ? Math.floor((dataByteLength - 2) / 2) : 0;	78✔
79
80	const richDecodedInfo =
81	await this.humanDescriptionMapper.mapRichDecodedInfo(	78✔
82	transaction,
83	chainId,
84	);
85
86	const humanDescription =
87	this.humanDescriptionMapper.mapHumanDescription(richDecodedInfo);	78✔
88
89	// If the rich fragment feature is disabled, we set it as undefined.
90	// Undefined properties are not rendered on the response
91	const richDecodedInfoApiProperty = this.isRichFragmentsEnabled	78!
92	? richDecodedInfo
93	: undefined;
94
95	if (this.isSwapsDecodingEnabled) {	78✔
96	const swapOrder: SwapOrderTransactionInfo \| null =
97	await this.mapSwapOrder(chainId, transaction);	78✔
98	// If the transaction is a swap order, we return it immediately
99	if (swapOrder) return swapOrder;	78!
100	}
101
102	if (this.isCustomTransaction(value, dataSize, transaction.operation)) {	78✔
103	return await this.customTransactionMapper.mapCustomTransaction(	44✔
104	transaction,
105	dataSize,
106	chainId,
107	humanDescription,
108	richDecodedInfoApiProperty,
109	);
110	}
111
112	if (this.isNativeCoinTransfer(value, dataSize)) {	34✔
113	return this.nativeCoinTransferMapper.mapNativeCoinTransfer(	28✔
114	chainId,
115	transaction,
116	humanDescription,
117	richDecodedInfoApiProperty,
118	);
119	}
120
121	if (this.isSettingsChange(transaction, value, dataSize)) {	6!
122	const settingsInfo = await this.settingsChangeMapper.mapSettingsChange(	×
123	chainId,
124	transaction,
125	);
126
127	if (!transaction.dataDecoded) {	×
128	throw new Error(	×
129	`Data decoded is null. txHash=${transaction.transactionHash}`,
130	);
131	}
132
133	const dataDecodedParameters: DataDecodedParameter[] \| null =
134	transaction.dataDecoded.parameters?.map(	×
135	(parameter) =>
136	new DataDecodedParameter(	×
137	parameter.name,
138	parameter.type,
139	parameter.value,
140	parameter.valueDecoded,
141	),
142	) ?? null;
143
144	return new SettingsChangeTransaction(	×
145	new DataDecoded(transaction.dataDecoded.method, dataDecodedParameters),
146	settingsInfo,
147	humanDescription,
148	richDecodedInfoApiProperty,
149	);
150	}
151
152	if (this.isValidTokenTransfer(transaction)) {	6✔
153	const token = await this.tokenRepository	6✔
154	.getToken({ chainId, address: transaction.to })
155	.catch(() => null);	×
156
157	switch (token?.type) {	6!
158	case TokenType.Erc20:
159	return this.erc20TransferMapper.mapErc20Transfer(	4✔
160	token,
161	chainId,
162	transaction,
163	humanDescription,
164	richDecodedInfoApiProperty,
165	);
166	case TokenType.Erc721:
167	return this.erc721TransferMapper.mapErc721Transfer(	2✔
168	token,
169	chainId,
170	transaction,
171	humanDescription,
172	richDecodedInfoApiProperty,
173	);
174	}
175	}
176
UNCOV 177	return this.customTransactionMapper.mapCustomTransaction(	×
178	transaction,
179	dataSize,
180	chainId,
181	humanDescription,
182	richDecodedInfoApiProperty,
183	);
184	}
185
186	/**
187	* Maps a swap order transaction.
188	* If the transaction is not a swap order, it returns null.
189	*
190	* @param chainId
191	* @param transaction
192	* @private
193	*/
194	private async mapSwapOrder(
195	chainId: string,
196	transaction: MultisigTransaction \| ModuleTransaction,
197	): Promise<SwapOrderTransactionInfo \| null> {
198	if (!transaction?.data \|\| !isHex(transaction.data)) {	78!
199	return null;	4✔
200	}
201
202	const orderData: `0x${string}` \| null = this.swapOrderHelper.findSwapOrder(	74✔
203	transaction.data,
204	);
205
206	if (!orderData) {	74✔
207	return null;	74✔
208	}
209
210	try {	×
211	return await this.swapOrderMapper.mapSwapOrder(chainId, {	×
212	data: orderData,
213	});
214	} catch (error) {
215	// The transaction is a swap order, but we couldn't decode it successfully.
216	this.loggingService.warn(error);	×
217	return null;	×
218	}
219	}
220
221	private isCustomTransaction(
222	value: number,
223	dataSize: number,
224	operation: Operation,
225	): boolean {
226	return (value > 0 && dataSize > 0) \|\| operation !== 0;	78✔
227	}
228
229	private isNativeCoinTransfer(value: number, dataSize: number): boolean {
230	return value > 0 && dataSize === 0;	34✔
231	}
232
233	private isSettingsChange(
234	transaction: MultisigTransaction \| ModuleTransaction,
235	value: number,
236	dataSize: number,
237	): boolean {
238	const isSettingsChangeMethod: boolean = transaction.dataDecoded	6!
239	? SettingsChangeMapper.SETTINGS_CHANGE_METHODS.includes(
240	transaction.dataDecoded.method,
241	)
242	: false;
243
244	return (	6✔
245	value === 0 &&	6!
246	dataSize > 0 &&
247	transaction.safe === transaction.to &&
248	isSettingsChangeMethod
249	);
250	}
251
252	private isValidTokenTransfer(
253	transaction: MultisigTransaction \| ModuleTransaction,
254	): boolean {
255	return (	6✔
256	(this.isErc20Transfer(transaction) \|\|	7✔
257	this.isErc721Transfer(transaction)) &&
258	this.isSafeSenderOrReceiver(transaction)
259	);
260	}
261
262	private isErc20Transfer(
263	transaction: MultisigTransaction \| ModuleTransaction,
264	): boolean {
265	const { dataDecoded } = transaction;	6✔
266	return this.ERC20_TRANSFER_METHODS.some(	6✔
267	(method) => method === dataDecoded?.method,	8!
268	);
269	}
270
271	private isErc721Transfer(
272	transaction: MultisigTransaction \| ModuleTransaction,
273	): boolean {
274	const { dataDecoded } = transaction;	2✔
275	return this.ERC721_TRANSFER_METHODS.some(	2✔
276	(method) => method === dataDecoded?.method,	6!
277	);
278	}
279
280	private isSafeSenderOrReceiver(
281	transaction: MultisigTransaction \| ModuleTransaction,
282	): boolean {
283	const { dataDecoded } = transaction;	6✔
284	if (!dataDecoded) return false;	6!
285	return (	6✔
286	this.TRANSFER_METHOD == dataDecoded.method \|\|	4!
287	this.dataDecodedParamHelper.getFromParam(dataDecoded, '') ===
288	transaction.safe \|\|
289	this.dataDecodedParamHelper.getToParam(dataDecoded, '') ===
290	transaction.safe
291	);
292	}
293	}

safe-global / safe-client-gateway / 8895536479

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous