8892572235

Committed 30 Apr 2024 09:33AM UTC coverage: 31.948% (+0.01%) from 31.937%

Build # 8892572235

Build Type

Pull #9198

github

Committed by

oetherington

Commit Message

Update comment and sequence search document selectors to account for deleted user names

Pull Request Pull Request #9198: Reindex content in elastic for deleted users

Run Details

4716 of 38555 branches covered (12.23%)

Branch coverage included in aggregate %.

13 of 42 new or added lines in 6 files covered. (30.95%)

445 existing lines in 10 files now uncovered.

27511 of 62317 relevant lines covered (44.15%)

179.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

27.78

/packages/lesswrong/server/search/elastic/elasticCallbacks.ts

import {
  SearchIndexCollectionName,
  searchIndexedCollectionNames,
} from "../../../lib/search/searchUtil";
import { getCollectionHooks } from "../../mutationCallbacks";
import { UsersRepo } from "../../repos";
import ElasticClient from "./ElasticClient";
import ElasticExporter from "./ElasticExporter";
import { isElasticEnabled } from "./elasticSettings";

export const elasticSyncDocument = (
  collectionName: SearchIndexCollectionName,
  documentId: string,
) => {
  try {
    const client = new ElasticClient();
    const exporter = new ElasticExporter(client);
    void exporter.updateDocument(collectionName, documentId);
  } catch (e) {
    // eslint-disable-next-line no-console
    console.error(`[${collectionName}] Failed to index Elasticsearch document:`, e);
  }
}

if (isElasticEnabled) {
  for (const collectionName of searchIndexedCollectionNames) {
    const callback = ({_id}: DbObject) => elasticSyncDocument(collectionName, _id);
    getCollectionHooks(collectionName).createAfter.add(callback);
    getCollectionHooks(collectionName).updateAfter.add(callback);
  }

  getCollectionHooks("Users").editAsync.add(async function reindexDeletedUserContent(
    newUser: DbUser,
    oldUser: DbUser,
  ) {
    if (newUser.deleted && !oldUser.deleted) {
      const repo = new UsersRepo();
      const [
        postIds,
        commentIds,
        sequenceIds,
      ] = await Promise.all([
        repo.getAllUserPostIds(newUser._id),
        repo.getAllUserCommentIds(newUser._id),
        repo.getAllUserSequenceIds(newUser._id),
      ]);

      const client = new ElasticClient();
      const exporter = new ElasticExporter(client);

      for (const id of postIds) {
        await exporter.updateDocument("Posts", id);
      }

      for (const id of commentIds) {
        await exporter.updateDocument("Comments", id);
      }

      for (const id of sequenceIds) {
        await exporter.updateDocument("Sequences", id);
      }
    }
  });
}

1	import {	54✔
2	SearchIndexCollectionName,
3	searchIndexedCollectionNames,
4	} from "../../../lib/search/searchUtil";	18✔
5	import { getCollectionHooks } from "../../mutationCallbacks";	18✔
6	import { UsersRepo } from "../../repos";	18✔
7	import ElasticClient from "./ElasticClient";	18✔
8	import ElasticExporter from "./ElasticExporter";	18✔
9	import { isElasticEnabled } from "./elasticSettings";	18✔
10
11	export const elasticSyncDocument = (	18✔
12	collectionName: SearchIndexCollectionName,
13	documentId: string,
14	) => {
15	try {	×
16	const client = new ElasticClient();	×
17	const exporter = new ElasticExporter(client);	×
18	void exporter.updateDocument(collectionName, documentId);	×
19	} catch (e) {
20	// eslint-disable-next-line no-console
21	console.error(`[${collectionName}] Failed to index Elasticsearch document:`, e);	×
22	}
23	}
24
25	if (isElasticEnabled) {	18!
26	for (const collectionName of searchIndexedCollectionNames) {	×
27	const callback = ({_id}: DbObject) => elasticSyncDocument(collectionName, _id);	×
28	getCollectionHooks(collectionName).createAfter.add(callback);	×
29	getCollectionHooks(collectionName).updateAfter.add(callback);	×
30	}
31
NEW 32	getCollectionHooks("Users").editAsync.add(async function reindexDeletedUserContent(	×
33	newUser: DbUser,
34	oldUser: DbUser,
35	) {
NEW 36	if (newUser.deleted && !oldUser.deleted) {	×
NEW 37	const repo = new UsersRepo();	×
38	const [
39	postIds,
40	commentIds,
41	sequenceIds,
NEW 42	] = await Promise.all([	×
43	repo.getAllUserPostIds(newUser._id),
44	repo.getAllUserCommentIds(newUser._id),
45	repo.getAllUserSequenceIds(newUser._id),
46	]);
47
NEW 48	const client = new ElasticClient();	×
NEW 49	const exporter = new ElasticExporter(client);	×
50
NEW 51	for (const id of postIds) {	×
NEW 52	await exporter.updateDocument("Posts", id);	×
53	}
54
NEW 55	for (const id of commentIds) {	×
NEW 56	await exporter.updateDocument("Comments", id);	×
57	}
58
NEW 59	for (const id of sequenceIds) {	×
NEW 60	await exporter.updateDocument("Sequences", id);	×
61	}
62	}
63	});
64	}

ForumMagnum / ForumMagnum / 8892572235

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous