8884119429

Committed 29 Apr 2024 07:12PM UTC coverage: 31.958% (-0.01%) from 31.971%

Build # 8884119429

Build Type

Pull #9194

github

Committed by

b0b3rt

Commit Message

switch admin gate to logged in

Pull Request Pull Request #9194: add google vertex real-time events and attribution id handling

Run Details

4720 of 38518 branches covered (12.25%)

Branch coverage included in aggregate %.

37 of 145 new or added lines in 16 files covered. (25.52%)

6 existing lines in 4 files now uncovered.

27517 of 62355 relevant lines covered (44.13%)

179.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

10.53

/packages/lesswrong/components/recentDiscussion/useRecentDiscussionThread.ts

import { useCallback, useState } from "react";
import { useRecordPostView } from "../hooks/useRecordPostView";
import { ThreadableCommentType, unflattenComments } from "../../lib/utils/unflatten";
import type { CommentTreeOptions } from "../comments/commentTree";

export const useRecentDiscussionThread = <T extends ThreadableCommentType>({
  post,
  comments,
  refetch,
  commentTreeOptions = {},
  initialExpandAllThreads,
}: {
  post: PostsRecentDiscussion,
  comments?: T[],
  refetch: () => void,
  commentTreeOptions?: CommentTreeOptions,
  initialExpandAllThreads?: boolean,
}) => {
  const [highlightVisible, setHighlightVisible] = useState(false);
  const [markedAsVisitedAt, setMarkedAsVisitedAt] = useState<Date|null>(null);
  const [expandAllThreads, setExpandAllThreads] = useState(initialExpandAllThreads ?? false);
  const {recordPostView} = useRecordPostView(post);

  const markAsRead = useCallback(
    () => {
      setMarkedAsVisitedAt(new Date());
      setExpandAllThreads(true);
      void recordPostView({post, extraEventProperties: {type: "recentDiscussionClick"}, recommendationOptions: {skip: true}})
    },
    [setMarkedAsVisitedAt, setExpandAllThreads, recordPostView, post],
  );
  const showHighlight = useCallback(
    () => {
      setHighlightVisible(!highlightVisible);
      markAsRead();
    },
    [setHighlightVisible, highlightVisible, markAsRead],
  );

  const lastCommentId = comments && comments[0]?._id;
  const nestedComments = unflattenComments<T>(comments ?? []);

  const lastVisitedAt = markedAsVisitedAt || post.lastVisitedAt

  // For posts that have never been commented on, we do want to show them in the
  // recent discussion feed. For posts which have been commented on, but the comments
  // have been deleted, we don't want to show them (these are usually spam).
  //
  // There is no completely reliable way to tell the difference, but this is a fairly conservative
  // (in favour of showing a post) heuristic.
  const probablyNeverCommentedOn =
    new Date(post.lastCommentedAt).getTime() - new Date(post.postedAt).getTime() < 30_000;

  // TODO verify whether/how this should be interacting with afCommentCount
  // New posts should render (to display their highlight).
  // Posts with at least one comment should only render if those comments
  // meet the frontpage filter requirements
  const isSkippable = comments && !comments.length && !probablyNeverCommentedOn;

  const treeOptions: CommentTreeOptions = {
    scrollOnExpand: true,
    lastCommentId: lastCommentId,
    highlightDate: lastVisitedAt ?? undefined,
    refetch: refetch,
    condensed: true,
    post,
    ...commentTreeOptions
  };

  return {
    isSkippable,
    showHighlight,
    expandAllThreads,
    lastVisitedAt,
    nestedComments,
    treeOptions,
  };
}

1	import { useCallback, useState } from "react";	3✔
2	import { useRecordPostView } from "../hooks/useRecordPostView";	1✔
3	import { ThreadableCommentType, unflattenComments } from "../../lib/utils/unflatten";	1✔
4	import type { CommentTreeOptions } from "../comments/commentTree";
5
6	export const useRecentDiscussionThread = <T extends ThreadableCommentType>({	1✔
7	post,
8	comments,
9	refetch,
10	commentTreeOptions = {},	×
11	initialExpandAllThreads,
12	}: {
13	post: PostsRecentDiscussion,
14	comments?: T[],
15	refetch: () => void,
16	commentTreeOptions?: CommentTreeOptions,
17	initialExpandAllThreads?: boolean,
18	}) => {
19	const [highlightVisible, setHighlightVisible] = useState(false);	×
20	const [markedAsVisitedAt, setMarkedAsVisitedAt] = useState<Date\|null>(null);	×
21	const [expandAllThreads, setExpandAllThreads] = useState(initialExpandAllThreads ?? false);	×
22	const {recordPostView} = useRecordPostView(post);	×
23
24	const markAsRead = useCallback(	×
25	() => {
26	setMarkedAsVisitedAt(new Date());	×
27	setExpandAllThreads(true);	×
NEW 28	void recordPostView({post, extraEventProperties: {type: "recentDiscussionClick"}, recommendationOptions: {skip: true}})	×
29	},
30	[setMarkedAsVisitedAt, setExpandAllThreads, recordPostView, post],
31	);
32	const showHighlight = useCallback(	×
33	() => {
34	setHighlightVisible(!highlightVisible);	×
35	markAsRead();	×
36	},
37	[setHighlightVisible, highlightVisible, markAsRead],
38	);
39
40	const lastCommentId = comments && comments[0]?._id;	×
41	const nestedComments = unflattenComments<T>(comments ?? []);	×
42
43	const lastVisitedAt = markedAsVisitedAt \|\| post.lastVisitedAt	×
44
45	// For posts that have never been commented on, we do want to show them in the
46	// recent discussion feed. For posts which have been commented on, but the comments
47	// have been deleted, we don't want to show them (these are usually spam).
48	//
49	// There is no completely reliable way to tell the difference, but this is a fairly conservative
50	// (in favour of showing a post) heuristic.
51	const probablyNeverCommentedOn =
52	new Date(post.lastCommentedAt).getTime() - new Date(post.postedAt).getTime() < 30_000;	×
53
54	// TODO verify whether/how this should be interacting with afCommentCount
55	// New posts should render (to display their highlight).
56	// Posts with at least one comment should only render if those comments
57	// meet the frontpage filter requirements
58	const isSkippable = comments && !comments.length && !probablyNeverCommentedOn;	×
59
60	const treeOptions: CommentTreeOptions = {	×
61	scrollOnExpand: true,
62	lastCommentId: lastCommentId,
63	highlightDate: lastVisitedAt ?? undefined,	×
64	refetch: refetch,
65	condensed: true,
66	post,
67	...commentTreeOptions
68	};
69
70	return {	×
71	isSkippable,
72	showHighlight,
73	expandAllThreads,
74	lastVisitedAt,
75	nestedComments,
76	treeOptions,
77	};
78	}

ForumMagnum / ForumMagnum / 8884119429

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous