8855424247

Committed 26 Apr 2024 11:29PM UTC coverage: 31.952% (-0.02%) from 31.971%

Build # 8855424247

Build Type

push

github

Committed by

b0b3rt

Commit Message

add google vertex real-time events and attribution id handling

Run Details

4709 of 38509 branches covered (12.23%)

Branch coverage included in aggregate %.

25 of 105 new or added lines in 13 files covered. (23.81%)

6 existing lines in 4 files now uncovered.

27513 of 62337 relevant lines covered (44.14%)

179.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

20.0

/packages/lesswrong/components/posts/VertexPostsList.tsx

import React, { useState } from 'react';
import { Components, fragmentTextForQuery, registerComponent } from '../../lib/vulcan-lib';
import { NetworkStatus, gql, useQuery } from '@apollo/client';
import { VertexConfiguration } from '../../lib/collections/users/recommendationSettings';
import { useOnMountTracking } from '../../lib/analyticsEvents';
import { isServer } from '../../lib/executionEnvironment';

// Would be nice not to duplicate in postResolvers.ts but unfortunately the post types are different
interface VertexRecommendedPost {
  post: PostsListWithVotes,
  attributionId?: string,
}

const styles = (theme: ThemeType) => ({
  root: {

  }
});

const DEFAULT_RESOLVER_NAME = 'GoogleVertexPosts';

type VertexResolver = typeof DEFAULT_RESOLVER_NAME;

const getVertexPostsQuery = (resolverName: VertexResolver) => gql`
  query get${resolverName}($limit: Int) {
    ${resolverName}(limit: $limit) {
      results {
        post {
          ...PostsListWithVotes
        }
        attributionId
      }
    }
  }
  ${fragmentTextForQuery('PostsListWithVotes')}
`;

const getLoadMoreSettings = (resolverName: VertexResolver, results: VertexRecommendedPost[]): VertexConfiguration['loadMore'] => {
  switch (resolverName) {
    case DEFAULT_RESOLVER_NAME:
      const prevAttributionId = results.find(result => result.attributionId)?.attributionId;
      if (!prevAttributionId) {
        return undefined;
      }
      return { prevAttributionId };  
  }
}

export const stickiedPostTerms: PostsViewTerms = {
  view: 'stickied',
  limit: 4, // seriously, shouldn't have more than 4 stickied posts
  forum: true
};

export const VertexPostsList = ({ limit = 100, classes }: {
  limit?: number,
  classes: ClassesType<typeof styles>,
}) => {
  const { LoadMore, PostsItem, SectionFooter, PostsLoading } = Components;

  const [displayCount, setDisplayCount] = useState(15);

  const resolverName = DEFAULT_RESOLVER_NAME;

  const query = getVertexPostsQuery(resolverName);
  const { data, loading, networkStatus } = useQuery(query, {
    ssr: false || !isServer,
    notifyOnNetworkStatusChange: true,
    pollInterval: 0,
    variables: {
      limit,
    },
  });

  const results: VertexRecommendedPost[] | undefined = data?.[resolverName]?.results;
  const postIds = results?.map(({post}) => post._id) ?? [];

  useOnMountTracking({
    eventType: "postList",
    eventProps: { postIds },
    captureOnMount: (eventProps) => eventProps.postIds.length > 0,
    skip: !postIds.length || loading,
  });

  if (loading && !results) {
    return <PostsLoading placeholderCount={limit} />;
  }

  if (!results) {
    return null;
  }

  return <div>
    <div className={classes.root}>
      {results.slice(0, displayCount).map(({ post, attributionId }) => <PostsItem 
        key={post._id} 
        post={post} 
        vertexAttributionId={attributionId} 
      />)}
    </div>
    <SectionFooter>
      <LoadMore
        loading={loading || networkStatus === NetworkStatus.fetchMore}
        loadMore={() => {
          // Purely for admin testing, see e.g. RecombeePostsList for a custom loadMore implementation if we figure one out for Vertex
          if (displayCount < 100) {
            setDisplayCount(Math.min(100, displayCount + 15));
          }
        }}
        sectionFooterStyles
      />
    </SectionFooter>
  </div>;
}

const VertexPostsListComponent = registerComponent('VertexPostsList', VertexPostsList, {styles});

declare global {
  interface ComponentTypes {
    VertexPostsList: typeof VertexPostsListComponent
  }
}

1	import React, { useState } from 'react';	3✔
2	import { Components, fragmentTextForQuery, registerComponent } from '../../lib/vulcan-lib';	1✔
3	import { NetworkStatus, gql, useQuery } from '@apollo/client';	1✔
4	import { VertexConfiguration } from '../../lib/collections/users/recommendationSettings';
5	import { useOnMountTracking } from '../../lib/analyticsEvents';	1✔
6	import { isServer } from '../../lib/executionEnvironment';	1✔
7
8	// Would be nice not to duplicate in postResolvers.ts but unfortunately the post types are different
9	interface VertexRecommendedPost {
10	post: PostsListWithVotes,
11	attributionId?: string,
12	}
13
14	const styles = (theme: ThemeType) => ({	1✔
15	root: {
16
17	}
18	});
19
20	const DEFAULT_RESOLVER_NAME = 'GoogleVertexPosts';	1✔
21
22	type VertexResolver = typeof DEFAULT_RESOLVER_NAME;
23
24	const getVertexPostsQuery = (resolverName: VertexResolver) => gql`	1✔
25	query get${resolverName}($limit: Int) {
26	${resolverName}(limit: $limit) {
27	results {
28	post {
29	...PostsListWithVotes
30	}
31	attributionId
32	}
33	}
34	}
35	${fragmentTextForQuery('PostsListWithVotes')}
36	`;
37
38	const getLoadMoreSettings = (resolverName: VertexResolver, results: VertexRecommendedPost[]): VertexConfiguration['loadMore'] => {	1✔
39	switch (resolverName) {	×
40	case DEFAULT_RESOLVER_NAME:
41	const prevAttributionId = results.find(result => result.attributionId)?.attributionId;	×
42	if (!prevAttributionId) {	×
43	return undefined;	×
44	}
45	return { prevAttributionId };	×
46	}
47	}
48
49	export const stickiedPostTerms: PostsViewTerms = {	1✔
50	view: 'stickied',
51	limit: 4, // seriously, shouldn't have more than 4 stickied posts
52	forum: true
53	};
54
55	export const VertexPostsList = ({ limit = 100, classes }: {	1!
56	limit?: number,
57	classes: ClassesType<typeof styles>,
58	}) => {
59	const { LoadMore, PostsItem, SectionFooter, PostsLoading } = Components;	×
60
61	const [displayCount, setDisplayCount] = useState(15);	×
62
63	const resolverName = DEFAULT_RESOLVER_NAME;	×
64
65	const query = getVertexPostsQuery(resolverName);	×
NEW 66	const { data, loading, networkStatus } = useQuery(query, {	×
67	ssr: false \|\| !isServer,
68	notifyOnNetworkStatusChange: true,
69	pollInterval: 0,
70	variables: {
71	limit,
72	},
73	});
74
75	const results: VertexRecommendedPost[] \| undefined = data?.[resolverName]?.results;	×
76	const postIds = results?.map(({post}) => post._id) ?? [];	×
77
78	useOnMountTracking({	×
79	eventType: "postList",
80	eventProps: { postIds },
81	captureOnMount: (eventProps) => eventProps.postIds.length > 0,	×
82	skip: !postIds.length \|\| loading,	×
83	});
84
85	if (loading && !results) {	×
86	return <PostsLoading placeholderCount={limit} />;	×
87	}
88
89	if (!results) {	×
90	return null;	×
91	}
92
93	return <div>	×
94	<div className={classes.root}>
NEW 95	{results.slice(0, displayCount).map(({ post, attributionId }) => <PostsItem	×
96	key={post._id}
97	post={post}
98	vertexAttributionId={attributionId}
99	/>)}
100	</div>
101	<SectionFooter>
102	<LoadMore
103	loading={loading \|\| networkStatus === NetworkStatus.fetchMore}	×
104	loadMore={() => {
105	// Purely for admin testing, see e.g. RecombeePostsList for a custom loadMore implementation if we figure one out for Vertex
106	if (displayCount < 100) {	×
107	setDisplayCount(Math.min(100, displayCount + 15));	×
108	}
109	}}
110	sectionFooterStyles
111	/>
112	</SectionFooter>
113	</div>;
114	}
115
116	const VertexPostsListComponent = registerComponent('VertexPostsList', VertexPostsList, {styles});	1✔
117
118	declare global {
119	interface ComponentTypes {
120	VertexPostsList: typeof VertexPostsListComponent
121	}
122	}

ForumMagnum / ForumMagnum / 8855424247

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous