8855211899

Committed 26 Apr 2024 11:00PM UTC coverage: 31.957% (-0.01%) from 31.967%

Build # 8855211899

Build Type

Pull #9186

github

Committed by

oetherington

Commit Message

Disable persisting posts list view type for logged out users

Pull Request Pull Request #9186: [EA] Card view

Run Details

4709 of 38535 branches covered (12.22%)

Branch coverage included in aggregate %.

47 of 108 new or added lines in 17 files covered. (43.52%)

7 existing lines in 6 files now uncovered.

27533 of 62356 relevant lines covered (44.15%)

179.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

35.48

/packages/lesswrong/components/hooks/usePostsListView.tsx

import React, { FC, ReactNode, createContext, useCallback, useContext, useState } from "react";
import { TupleSet, UnionOf } from "../../lib/utils/typeGuardUtils";
import { useCookiesWithConsent } from "./useCookiesWithConsent";
import { POSTS_LIST_VIEW_TYPE_COOKIE } from "../../lib/cookies/cookies";
import { useCurrentUser } from "../common/withUser";

const postsListViewTypes = new TupleSet(["list", "card"] as const);

export type PostsListViewType = UnionOf<typeof postsListViewTypes>;

export const isPostsListViewType = (value: string): value is PostsListViewType =>
  postsListViewTypes.has(value);

type PostsListViewContext = {
  view: PostsListViewType,
  setView: (view: PostsListViewType) => void,
}

const postsListViewContext = createContext<PostsListViewContext>({
  view: "list",
  // eslint-disable-next-line no-console
  setView: () => console.error("Can't set view outside of PostsListViewProvider"),
});

const useCookieValue = (): {
  cookieValue: PostsListViewType | null,
    setCookieValue: (value: PostsListViewType) => void,
} => {
  const currentUser = useCurrentUser();
  const [cookies, setCookie] = useCookiesWithConsent([POSTS_LIST_VIEW_TYPE_COOKIE]);
  const setCookieValue = useCallback((newValue: PostsListViewType) => {
    setCookie(POSTS_LIST_VIEW_TYPE_COOKIE, newValue);
  }, [setCookie]);

  // TODO: We currently need to disable persisting the card view for logged out
  // users because it plays really badly with the page cache
  const value = currentUser ? cookies[POSTS_LIST_VIEW_TYPE_COOKIE] : "list";
  return {
    cookieValue: isPostsListViewType(value) ? value : null,
    setCookieValue,
  };
}

export const PostsListViewProvider: FC<{children: ReactNode}> = ({children}) => {
  const {cookieValue, setCookieValue} = useCookieValue();
  const [view, setView_] = useState<PostsListViewType>(cookieValue ?? "list");

  const setView = useCallback((newValue: PostsListViewType) => {
    setView_(newValue);
    setCookieValue(newValue);
  }, [setCookieValue]);

  return (
    <postsListViewContext.Provider value={{view, setView}}>
      {children}
    </postsListViewContext.Provider>
  );
}

export const usePostsListView = () => useContext(postsListViewContext);

1	import React, { FC, ReactNode, createContext, useCallback, useContext, useState } from "react";	3✔
2	import { TupleSet, UnionOf } from "../../lib/utils/typeGuardUtils";	1✔
3	import { useCookiesWithConsent } from "./useCookiesWithConsent";	1✔
4	import { POSTS_LIST_VIEW_TYPE_COOKIE } from "../../lib/cookies/cookies";	1✔
5	import { useCurrentUser } from "../common/withUser";	1✔
6
7	const postsListViewTypes = new TupleSet(["list", "card"] as const);	1✔
8
9	export type PostsListViewType = UnionOf<typeof postsListViewTypes>;
10
11	export const isPostsListViewType = (value: string): value is PostsListViewType =>	1✔
NEW 12	postsListViewTypes.has(value);	×
13
14	type PostsListViewContext = {
15	view: PostsListViewType,
16	setView: (view: PostsListViewType) => void,
17	}
18
19	const postsListViewContext = createContext<PostsListViewContext>({	1✔
20	view: "list",
21	// eslint-disable-next-line no-console
NEW 22	setView: () => console.error("Can't set view outside of PostsListViewProvider"),	×
23	});
24
25	const useCookieValue = (): {	1✔
26	cookieValue: PostsListViewType \| null,
27	setCookieValue: (value: PostsListViewType) => void,
28	} => {
NEW 29	const currentUser = useCurrentUser();	×
NEW 30	const [cookies, setCookie] = useCookiesWithConsent([POSTS_LIST_VIEW_TYPE_COOKIE]);	×
NEW 31	const setCookieValue = useCallback((newValue: PostsListViewType) => {	×
NEW 32	setCookie(POSTS_LIST_VIEW_TYPE_COOKIE, newValue);	×
33	}, [setCookie]);
34
35	// TODO: We currently need to disable persisting the card view for logged out
36	// users because it plays really badly with the page cache
NEW 37	const value = currentUser ? cookies[POSTS_LIST_VIEW_TYPE_COOKIE] : "list";	×
NEW 38	return {	×
39	cookieValue: isPostsListViewType(value) ? value : null,	×
40	setCookieValue,
41	};
42	}
43
44	export const PostsListViewProvider: FC<{children: ReactNode}> = ({children}) => {	1✔
NEW 45	const {cookieValue, setCookieValue} = useCookieValue();	×
NEW 46	const [view, setView_] = useState<PostsListViewType>(cookieValue ?? "list");	×
47
NEW 48	const setView = useCallback((newValue: PostsListViewType) => {	×
NEW 49	setView_(newValue);	×
NEW 50	setCookieValue(newValue);	×
51	}, [setCookieValue]);
52
NEW 53	return (	×
54	<postsListViewContext.Provider value={{view, setView}}>
55	{children}
56	</postsListViewContext.Provider>
57	);
58	}
59
60	export const usePostsListView = () => useContext(postsListViewContext);	1✔

ForumMagnum / ForumMagnum / 8855211899

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous