8849743498

Committed 26 Apr 2024 02:18PM UTC coverage: 31.96% (-0.007%) from 31.967%

Build # 8849743498

Build Type

Pull #9186

github

Committed by

oetherington

Commit Message

Add logic to hide posts list view toggle "NEW" flag

Hide when any of the following is true:
  - The user clicks the toggle
  - The user sees it three times without clicking
  - One month passes from when the user first saw it

Pull Request Pull Request #9186: [EA] Card view

Run Details

4709 of 38523 branches covered (12.22%)

Branch coverage included in aggregate %.

42 of 94 new or added lines in 17 files covered. (44.68%)

6 existing lines in 5 files now uncovered.

27527 of 62341 relevant lines covered (44.16%)

179.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

32.26

/packages/lesswrong/components/ea-forum/EAHome.tsx

import React, { useCallback } from 'react'
import { PublicInstanceSetting, isEAForum } from '../../lib/instanceSettings'
import { DatabasePublicSetting } from '../../lib/publicSettings'
import { Components, combineUrls, getSiteUrl, registerComponent } from '../../lib/vulcan-lib'
import { useCurrentUser } from '../common/withUser'
import { reviewIsActive, REVIEW_YEAR } from '../../lib/reviewUtils'
import { maintenanceTime } from '../common/MaintenanceBanner'
import { AnalyticsContext } from '../../lib/analyticsEvents'
import ForumNoSSR from '../common/ForumNoSSR'

const eaHomeSequenceIdSetting = new PublicInstanceSetting<string | null>('eaHomeSequenceId', null, "optional") // Sequence ID for the EAHomeHandbook sequence
const showSmallpoxSetting = new DatabasePublicSetting<boolean>('showSmallpox', false)
const showHandbookBannerSetting = new DatabasePublicSetting<boolean>('showHandbookBanner', false)
const showEventBannerSetting = new DatabasePublicSetting<boolean>('showEventBanner', false)
const showMaintenanceBannerSetting = new DatabasePublicSetting<boolean>('showMaintenanceBanner', false)
const isBotSiteSetting = new PublicInstanceSetting<boolean>('botSite.isBotSite', false, 'optional');

/**
 * Build structured data to help with SEO.
 */
const getStructuredData = () => ({
  "@context": "http://schema.org",
  "@type": "WebSite",
  "url": `${getSiteUrl()}`,
  "potentialAction": {
    "@type": "SearchAction",
    "target": `${combineUrls(getSiteUrl(), '/search')}?query={search_term_string}`,
    "query-input": "required name=search_term_string"
  },
  "mainEntityOfPage": {
    "@type": "WebPage",
    "@id": `${getSiteUrl()}`,
  },
  ...(isEAForum && {
    "description": [
      "A forum for discussions and updates on effective altruism. Topics covered include",
      "global health, AI safety, biosecurity, animal welfare, philosophy, policy, forecasting,",
      "and effective giving. Users can explore new posts, engage with the community,",
      "participate in recent discussions, and discover topics, events,",
      "and groups. An accessible space for sharing and learning about approaches to tackling",
      "the world's most pressing problems."
    ].join(' ')
  }),
})

const styles = (_theme: ThemeType) => ({
  spotlightMargin: {
    marginBottom: 24,
  },
});

const FrontpageNode = ({classes}: {classes: ClassesType<typeof styles>}) => {
  const currentUser = useCurrentUser();
  const recentDiscussionCommentsPerPost = currentUser && currentUser.isAdmin ? 4 : 3;
  const {
    RecentDiscussionFeed, QuickTakesSection, DismissibleSpotlightItem,
    HomeLatestPosts, EAHomeCommunityPosts, EAPopularCommentsSection,
  } = Components
  return (
    <>
      <DismissibleSpotlightItem current className={classes.spotlightMargin} />
      <HomeLatestPosts />
      {!currentUser?.hideCommunitySection && <EAHomeCommunityPosts />}
      {isEAForum && <QuickTakesSection />}
      <ForumNoSSR if={!!currentUser}>
        <EAPopularCommentsSection />
      </ForumNoSSR>
      <ForumNoSSR if={!!currentUser}>
        <RecentDiscussionFeed
          title="Recent discussion"
          af={false}
          commentsLimit={recentDiscussionCommentsPerPost}
          maxAgeHours={18}
        />
      </ForumNoSSR>
    </>
  );
}

const EAHome = ({classes}: {classes: ClassesType<typeof styles>}) => {
  const shouldRenderEventBanner = showEventBannerSetting.get()
  const shouldRenderSmallpox = showSmallpoxSetting.get()
  // Only show the maintenance banner if the the current time is before the maintenance time (plus 5 minutes leeway),
  // this is just so we don't have to rush to change the server settings as soon as the maintenance is done
  const maintenanceTimeValue = maintenanceTime.get()
  const isBeforeMaintenanceTime = maintenanceTimeValue && Date.now() < new Date(maintenanceTimeValue).getTime() + (5*60*1000)
  const shouldRenderMaintenanceBanner = showMaintenanceBannerSetting.get() && isBeforeMaintenanceTime
  const shouldRenderBotSiteBanner = isBotSiteSetting.get() && isEAForum

  const FrontpageNodeWithClasses = useCallback(
    () => <FrontpageNode classes={classes} />,
    [classes],
  );

  const {
    EAHomeMainContent, SmallpoxBanner, EventBanner, MaintenanceBanner,
    FrontpageReviewWidget, SingleColumnSection, HeadTags, BotSiteBanner,
  } = Components
  return (
    <AnalyticsContext pageContext="homePage">
      <HeadTags structuredData={getStructuredData()}/>
      {shouldRenderMaintenanceBanner && <MaintenanceBanner />}
      {shouldRenderSmallpox && <SmallpoxBanner/>}
      {shouldRenderEventBanner && <EventBanner />}
      {shouldRenderBotSiteBanner && <BotSiteBanner />}

      {reviewIsActive() && <SingleColumnSection>
        <FrontpageReviewWidget reviewYear={REVIEW_YEAR}/>
      </SingleColumnSection>}

      <EAHomeMainContent FrontpageNode={FrontpageNodeWithClasses} />
    </AnalyticsContext>
  )
}

const EAHomeComponent = registerComponent('EAHome', EAHome, {styles});

declare global {
  interface ComponentTypes {
    EAHome: typeof EAHomeComponent
  }
}

1	import React, { useCallback } from 'react'	1✔
2	import { PublicInstanceSetting, isEAForum } from '../../lib/instanceSettings'	1✔
3	import { DatabasePublicSetting } from '../../lib/publicSettings'	1✔
4	import { Components, combineUrls, getSiteUrl, registerComponent } from '../../lib/vulcan-lib'	1✔
5	import { useCurrentUser } from '../common/withUser'	1✔
6	import { reviewIsActive, REVIEW_YEAR } from '../../lib/reviewUtils'	1✔
7	import { maintenanceTime } from '../common/MaintenanceBanner'	1✔
8	import { AnalyticsContext } from '../../lib/analyticsEvents'	1✔
9	import ForumNoSSR from '../common/ForumNoSSR'	1✔
10
11	const eaHomeSequenceIdSetting = new PublicInstanceSetting<string \| null>('eaHomeSequenceId', null, "optional") // Sequence ID for the EAHomeHandbook sequence	1✔
12	const showSmallpoxSetting = new DatabasePublicSetting<boolean>('showSmallpox', false)	1✔
13	const showHandbookBannerSetting = new DatabasePublicSetting<boolean>('showHandbookBanner', false)	1✔
14	const showEventBannerSetting = new DatabasePublicSetting<boolean>('showEventBanner', false)	1✔
15	const showMaintenanceBannerSetting = new DatabasePublicSetting<boolean>('showMaintenanceBanner', false)	1✔
16	const isBotSiteSetting = new PublicInstanceSetting<boolean>('botSite.isBotSite', false, 'optional');	1✔
17
18	/**
19	* Build structured data to help with SEO.
20	*/
21	const getStructuredData = () => ({	1✔
22	"@context": "http://schema.org",
23	"@type": "WebSite",
24	"url": `${getSiteUrl()}`,
25	"potentialAction": {
26	"@type": "SearchAction",
27	"target": `${combineUrls(getSiteUrl(), '/search')}?query={search_term_string}`,
28	"query-input": "required name=search_term_string"
29	},
30	"mainEntityOfPage": {
31	"@type": "WebPage",
32	"@id": `${getSiteUrl()}`,
33	},
34	...(isEAForum && {	×
35	"description": [
36	"A forum for discussions and updates on effective altruism. Topics covered include",
37	"global health, AI safety, biosecurity, animal welfare, philosophy, policy, forecasting,",
38	"and effective giving. Users can explore new posts, engage with the community,",
39	"participate in recent discussions, and discover topics, events,",
40	"and groups. An accessible space for sharing and learning about approaches to tackling",
41	"the world's most pressing problems."
42	].join(' ')
43	}),
44	})
45
46	const styles = (_theme: ThemeType) => ({	1✔
47	spotlightMargin: {
48	marginBottom: 24,
49	},
50	});
51
52	const FrontpageNode = ({classes}: {classes: ClassesType<typeof styles>}) => {	1✔
53	const currentUser = useCurrentUser();	×
NEW 54	const recentDiscussionCommentsPerPost = currentUser && currentUser.isAdmin ? 4 : 3;	×
55	const {
56	RecentDiscussionFeed, QuickTakesSection, DismissibleSpotlightItem,
57	HomeLatestPosts, EAHomeCommunityPosts, EAPopularCommentsSection,
UNCOV 58	} = Components	×
NEW 59	return (	×
60	<>
61	<DismissibleSpotlightItem current className={classes.spotlightMargin} />
62	<HomeLatestPosts />
63	{!currentUser?.hideCommunitySection && <EAHomeCommunityPosts />}	×
64	{isEAForum && <QuickTakesSection />}	×
65	<ForumNoSSR if={!!currentUser}>
66	<EAPopularCommentsSection />
67	</ForumNoSSR>
68	<ForumNoSSR if={!!currentUser}>
69	<RecentDiscussionFeed
70	title="Recent discussion"
71	af={false}
72	commentsLimit={recentDiscussionCommentsPerPost}
73	maxAgeHours={18}
74	/>
75	</ForumNoSSR>
76	</>
77	);
78	}
79
80	const EAHome = ({classes}: {classes: ClassesType<typeof styles>}) => {	1✔
81	const shouldRenderEventBanner = showEventBannerSetting.get()	×
82	const shouldRenderSmallpox = showSmallpoxSetting.get()	×
83	// Only show the maintenance banner if the the current time is before the maintenance time (plus 5 minutes leeway),
84	// this is just so we don't have to rush to change the server settings as soon as the maintenance is done
85	const maintenanceTimeValue = maintenanceTime.get()	×
86	const isBeforeMaintenanceTime = maintenanceTimeValue && Date.now() < new Date(maintenanceTimeValue).getTime() + (5601000)	×
87	const shouldRenderMaintenanceBanner = showMaintenanceBannerSetting.get() && isBeforeMaintenanceTime	×
88	const shouldRenderBotSiteBanner = isBotSiteSetting.get() && isEAForum	×
89
NEW 90	const FrontpageNodeWithClasses = useCallback(	×
NEW 91	() => <FrontpageNode classes={classes} />,	×
92	[classes],
93	);
94
95	const {
96	EAHomeMainContent, SmallpoxBanner, EventBanner, MaintenanceBanner,
97	FrontpageReviewWidget, SingleColumnSection, HeadTags, BotSiteBanner,
NEW 98	} = Components	×
UNCOV 99	return (	×
100	<AnalyticsContext pageContext="homePage">
101	<HeadTags structuredData={getStructuredData()}/>
102	{shouldRenderMaintenanceBanner && <MaintenanceBanner />}	×
103	{shouldRenderSmallpox && <SmallpoxBanner/>}	×
104	{shouldRenderEventBanner && <EventBanner />}	×
105	{shouldRenderBotSiteBanner && <BotSiteBanner />}	×
106
107	{reviewIsActive() && <SingleColumnSection>
108	<FrontpageReviewWidget reviewYear={REVIEW_YEAR}/>
109	</SingleColumnSection>}
110
111	<EAHomeMainContent FrontpageNode={FrontpageNodeWithClasses} />
112	</AnalyticsContext>
113	)
114	}
115
116	const EAHomeComponent = registerComponent('EAHome', EAHome, {styles});	1✔
117
118	declare global {
119	interface ComponentTypes {
120	EAHome: typeof EAHomeComponent
121	}
122	}

ForumMagnum / ForumMagnum / 8849743498

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous