8840084058

Committed 25 Apr 2024 10:15PM UTC coverage: 32.005% (-0.04%) from 32.041%

Build # 8840084058

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9180 from ForumMagnum/master

[EA] Deploy people directory

Run Details

4707 of 38386 branches covered (12.26%)

Branch coverage included in aggregate %.

259 of 634 new or added lines in 57 files covered. (40.85%)

11 existing lines in 6 files now uncovered.

27436 of 62046 relevant lines covered (44.22%)

180.63 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

63.33

/packages/lesswrong/lib/betas.ts

// Centralized control of beta-gated features. If a feature is restricted to
// admins or to users with the opt-in flag, implement that by defining a
// function here which returns whether a given user has access to that feature.
// That way, we can look here to see what features are currently beta-gated,
// and have an easy way to un-gate in all the relevant places at once.
//
// Beta-feature test functions must handle the case where user is null.

import {
  testServerSetting,
  isEAForum,
  isLWorAF,
  hasCommentsTableOfContentSetting,
  hasSideCommentsSetting, 
  hasDialoguesSetting, 
  hasPostInlineReactionsSetting,
  isLW,
} from './instanceSettings'
import { isAdmin, userOverNKarmaOrApproved } from "./vulcan-users/permissions";
import {isFriendlyUI} from '../themes/forumTheme'
import { recombeeEnabledSetting } from './publicSettings';
import { useLocation } from './routeUtil';

// States for in-progress features
const adminOnly = (user: UsersCurrent|DbUser|null): boolean => !!user?.isAdmin; // eslint-disable-line no-unused-vars
const moderatorOnly = (user: UsersCurrent|DbUser|null): boolean => !!(user?.isAdmin || user?.groups?.includes('sunshineRegiment'))
const optInOnly = (user: UsersCurrent|DbUser|null): boolean => !!user?.beta; // eslint-disable-line no-unused-vars
const shippedFeature = (user: UsersCurrent|DbUser|null): boolean => true; // eslint-disable-line no-unused-vars
const disabled = (user: UsersCurrent|DbUser|null): boolean => false; // eslint-disable-line no-unused-vars
const testServerOnly = (_: UsersCurrent|DbUser|null): boolean => testServerSetting.get();
const adminOrBeta = (user: UsersCurrent|DbUser|null): boolean => adminOnly(user) || optInOnly(user);

//////////////////////////////////////////////////////////////////////////////
// Features in progress                                                     //
//////////////////////////////////////////////////////////////////////////////

export const userCanEditTagPortal = isEAForum ? moderatorOnly : adminOnly;
export const userHasBoldPostItems = disabled
export const userHasEAHomeHandbook = adminOnly
export const userCanCreateCommitMessages = moderatorOnly;
export const userHasRedesignedSettingsPage = disabled;
export const userCanUseSharing = (user: UsersCurrent|DbUser|null): boolean => moderatorOnly(user) || userOverNKarmaOrApproved(1)(user);
export const userHasNewTagSubscriptions =  isEAForum ? shippedFeature : disabled
export const userHasDefaultProfilePhotos = disabled

export const userHasAutosummarize = adminOnly

export const userHasThemePicker = isFriendlyUI ? adminOnly : shippedFeature;

export const userHasShortformTags = isEAForum ? shippedFeature : disabled;

export const userHasCommentProfileImages = disabled;

export const userHasEagProfileImport = disabled;

export const userHasEAHomeRHS = isEAForum ? shippedFeature : disabled;

export const visitorGetsDynamicFrontpage = isLW ? shippedFeature : disabled;

export const userHasPeopleDirectory = (user: UsersCurrent|DbUser|null) =>
  false;// isEAForum && !!user?.beta;

//defining as Hook so as to combine with ABTest
export const useRecombeeFrontpage = (currentUser: UsersCurrent|DbUser|null) => {
  // TODO: figure out what went wrong with the AB tests causing caching issues, beyond `affectsLoggedOut` being set to false
  // const recombeeOptInABTest = useABTest(newFrontpagePostFeedsWithRecommendationsOptIn)
  // const optedIntoRecombee = (recombeeOptInABTest === "frontpageWithTabs")
  const { query } = useLocation();
  
  const manualOptIn = currentUser && query.recExperiment === 'true';

  return isLW && (isAdmin(currentUser) || manualOptIn) && recombeeEnabledSetting.get()
}

export const userHasDarkModeHotkey = isEAForum ? adminOnly : shippedFeature;

// Non-user-specific features
export const dialoguesEnabled = hasDialoguesSetting.get();
export const ckEditorUserSessionsEnabled = isLWorAF;
export const inlineReactsHoverEnabled = hasPostInlineReactionsSetting.get();
export const allowSubscribeToUserComments = true;
export const allowSubscribeToSequencePosts = isFriendlyUI;
/** On the post page, do we show users other content they might want to read */
export const hasPostRecommendations = isEAForum;
/** Some Forums, notably the EA Forum, have a weekly digest that users can sign up to receive */
export const hasDigests = isEAForum;
export const hasSideComments = hasSideCommentsSetting.get();
export const useElicitApi = false;
export const commentsTableOfContentsEnabled = hasCommentsTableOfContentSetting.get();
export const fullHeightToCEnabled = isLWorAF;
export const hasForumEvents = isEAForum;
export const useCurationEmailsCron = isLW;

// Shipped Features
export const userCanManageTags = shippedFeature;
export const userCanCreateTags = shippedFeature;
export const userCanUseTags = shippedFeature;
export const userCanViewRevisionHistory = shippedFeature;
export const userHasPingbacks = shippedFeature;
export const userHasElasticsearch = shippedFeature;

1	// Centralized control of beta-gated features. If a feature is restricted to	290✔
2	// admins or to users with the opt-in flag, implement that by defining a
3	// function here which returns whether a given user has access to that feature.
4	// That way, we can look here to see what features are currently beta-gated,
5	// and have an easy way to un-gate in all the relevant places at once.
6	//
7	// Beta-feature test functions must handle the case where user is null.
8
9	import {
10	testServerSetting,
11	isEAForum,
12	isLWorAF,
13	hasCommentsTableOfContentSetting,
14	hasSideCommentsSetting,
15	hasDialoguesSetting,
16	hasPostInlineReactionsSetting,
17	isLW,
18	} from './instanceSettings'	24✔
19	import { isAdmin, userOverNKarmaOrApproved } from "./vulcan-users/permissions";	24✔
20	import {isFriendlyUI} from '../themes/forumTheme'	24✔
21	import { recombeeEnabledSetting } from './publicSettings';	24✔
22	import { useLocation } from './routeUtil';	24✔
23
24	// States for in-progress features
25	const adminOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!user?.isAdmin; // eslint-disable-line no-unused-vars	24!
26	const moderatorOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!(user?.isAdmin \|\| user?.groups?.includes('sunshineRegiment'))	24!
27	const optInOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!user?.beta; // eslint-disable-line no-unused-vars	24!
28	const shippedFeature = (user: UsersCurrent\|DbUser\|null): boolean => true; // eslint-disable-line no-unused-vars	24✔
29	const disabled = (user: UsersCurrent\|DbUser\|null): boolean => false; // eslint-disable-line no-unused-vars	24✔
30	const testServerOnly = (_: UsersCurrent\|DbUser\|null): boolean => testServerSetting.get();	24✔
31	const adminOrBeta = (user: UsersCurrent\|DbUser\|null): boolean => adminOnly(user) \|\| optInOnly(user);	24!
32
33	//////////////////////////////////////////////////////////////////////////////
34	// Features in progress //
35	//////////////////////////////////////////////////////////////////////////////
36
37	export const userCanEditTagPortal = isEAForum ? moderatorOnly : adminOnly;	24!
38	export const userHasBoldPostItems = disabled	24✔
39	export const userHasEAHomeHandbook = adminOnly	24✔
40	export const userCanCreateCommitMessages = moderatorOnly;	24✔
41	export const userHasRedesignedSettingsPage = disabled;	24✔
42	export const userCanUseSharing = (user: UsersCurrent\|DbUser\|null): boolean => moderatorOnly(user) \|\| userOverNKarmaOrApproved(1)(user);	24!
43	export const userHasNewTagSubscriptions = isEAForum ? shippedFeature : disabled	24!
44	export const userHasDefaultProfilePhotos = disabled	24✔
45
46	export const userHasAutosummarize = adminOnly	24✔
47
48	export const userHasThemePicker = isFriendlyUI ? adminOnly : shippedFeature;	24!
49
50	export const userHasShortformTags = isEAForum ? shippedFeature : disabled;	24!
51
52	export const userHasCommentProfileImages = disabled;	24✔
53
54	export const userHasEagProfileImport = disabled;	24✔
55
56	export const userHasEAHomeRHS = isEAForum ? shippedFeature : disabled;	24!
57
58	export const visitorGetsDynamicFrontpage = isLW ? shippedFeature : disabled;	24!
59
60	export const userHasPeopleDirectory = (user: UsersCurrent\|DbUser\|null) =>	24✔
NEW 61	false;// isEAForum && !!user?.beta;	×
62
63	//defining as Hook so as to combine with ABTest
64	export const useRecombeeFrontpage = (currentUser: UsersCurrent\|DbUser\|null) => {	24✔
65	// TODO: figure out what went wrong with the AB tests causing caching issues, beyond `affectsLoggedOut` being set to false
66	// const recombeeOptInABTest = useABTest(newFrontpagePostFeedsWithRecommendationsOptIn)
67	// const optedIntoRecombee = (recombeeOptInABTest === "frontpageWithTabs")
68	const { query } = useLocation();	×
69
70	const manualOptIn = currentUser && query.recExperiment === 'true';	×
71
72	return isLW && (isAdmin(currentUser) \|\| manualOptIn) && recombeeEnabledSetting.get()	×
73	}
74
75	export const userHasDarkModeHotkey = isEAForum ? adminOnly : shippedFeature;	24!
76
77	// Non-user-specific features
78	export const dialoguesEnabled = hasDialoguesSetting.get();	24✔
79	export const ckEditorUserSessionsEnabled = isLWorAF;	24✔
80	export const inlineReactsHoverEnabled = hasPostInlineReactionsSetting.get();	24✔
81	export const allowSubscribeToUserComments = true;	24✔
82	export const allowSubscribeToSequencePosts = isFriendlyUI;	24✔
83	/** On the post page, do we show users other content they might want to read */
84	export const hasPostRecommendations = isEAForum;	24✔
85	/** Some Forums, notably the EA Forum, have a weekly digest that users can sign up to receive */
86	export const hasDigests = isEAForum;	24✔
87	export const hasSideComments = hasSideCommentsSetting.get();	24✔
88	export const useElicitApi = false;	24✔
89	export const commentsTableOfContentsEnabled = hasCommentsTableOfContentSetting.get();	24✔
90	export const fullHeightToCEnabled = isLWorAF;	24✔
91	export const hasForumEvents = isEAForum;	24✔
92	export const useCurationEmailsCron = isLW;	24✔
93
94	// Shipped Features
95	export const userCanManageTags = shippedFeature;	24✔
96	export const userCanCreateTags = shippedFeature;	24✔
97	export const userCanUseTags = shippedFeature;	24✔
98	export const userCanViewRevisionHistory = shippedFeature;	24✔
99	export const userHasPingbacks = shippedFeature;	24✔
100	export const userHasElasticsearch = shippedFeature;	24✔

ForumMagnum / ForumMagnum / 8840084058

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous