openSUSE / agama / 8835155659

push

github

web: Add file systems for arbitrary mount points (#1154)

The storage UI only allows adding file systems for the mount points
predefined by the product (typicaly */home*, *swap* or */var*). This PR
extends the storage UI making possible to add file systems for any mount
point.

Main changes:

* The *Add file system* button is now a menu button, which allows to
select either a predefined mount point (if the mount point was not added
yet) or an arbitrary one (the *Other* option).
* The *Add file system* button turns into a regular button if only the
*Other* option is available.
* The *Add file system* button is disabled if the product does not admit
arbitrary mount points (i.e., transactional system) and there is no
pending predefined mount point to be added (i.e., all the predefined
mount points were already added).
* The *Add file system* is hidden if the product does not admit optional
file systems (i.e., transactinal system without predefined mount
points).
* The file system form validates the mount point:
  * Validates mount point presence on accept.
  * Validates mount point format on accept.
* Validates whether the entered mount point is already added and offers
to edit such a file system.
* Validates whether the entered mount point maches any of the predefined
mount points and offers to add the predefined mount point.
 
Note:

This PR introduces a new validation pattern which was previoulsy
discussed and agreed. The form validates its fields on accept and the
field error is gone when the field value changes (independently on the
field is now valid or not). The rationale of this behavior is:

* The form should not complain on the fly (while typing) because the
user has not finished until clicking on accept.
* If the field shows an error, then remove the error with the first
change on its value. We can consider the user has started fixing the
field, but the form will not bother the user untill pressing on acce... (continued)

1935 of 2785 branches covered (69.48%)

Branch coverage included in aggregate %.

215 of 222 new or added lines in 6 files covered. (96.85%)

18457 of 24385 relevant lines covered (75.69%)

33.09 hits per line