8823918904

Committed 24 Apr 2024 10:06PM UTC coverage: 32.048% (-0.005%) from 32.053%

Build # 8823918904

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9160 from ForumMagnum/recommendations-small-fixes

Continue Reading accepts limit and shuffle params + recommendationsTab stickied posts

Run Details

4699 of 38091 branches covered (12.34%)

Branch coverage included in aggregate %.

4 of 17 new or added lines in 4 files covered. (23.53%)

2 existing lines in 1 file now uncovered.

27204 of 61457 relevant lines covered (44.27%)

181.96 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

12.5

/packages/lesswrong/components/recommendations/ContinueReadingList.tsx

import React, { useState } from 'react';
import { Components, registerComponent } from '../../lib/vulcan-lib';
import { useDismissRecommendation } from './withDismissRecommendation';
import { captureEvent, AnalyticsContext } from '../../lib/analyticsEvents';
import * as _ from 'underscore';
import { ContinueReading } from './withContinueReading';


const ContinueReadingList = ({ continueReading, continueReadingLoading, limit=3, shuffle }: {
  continueReading: ContinueReading[],
  continueReadingLoading?: boolean,
  limit?: number,
  // randomly select posts from your reading list if your reading list is longer than the limit
  shuffle?: boolean,
}) => {
  const dismissRecommendation = useDismissRecommendation();
  const [dismissedRecommendations, setDismissedRecommendations] = useState<any>({});
  const [showAll, setShowAll] = useState(false);
  
  const dismissAndHideRecommendation = (postId: string) => {
    void dismissRecommendation(postId);
    setDismissedRecommendations({
      ...dismissedRecommendations,
      [postId]: true
    });
    captureEvent("continueReadingDismissed", {"postId": postId});
  }
  
  const limitResumeReading = (resumeReadingList: ContinueReading[]): { entries: ContinueReading[], showAllLink: boolean } => {
    // Filter out dismissed recommendations
    const filtered = _.filter(resumeReadingList, r=>!dismissedRecommendations[r.nextPost._id]);
    
    // Sort by last-interaction time
    let sorted = _.sortBy(filtered, r=>r.lastReadTime);
    sorted.reverse(); //in-place
    
    // Limit to the three most recent
    if (showAll || sorted.length <= limit) {
      return {
        entries: sorted,
        showAllLink: false,
      };
    } else if (shuffle) {
      const sampled = _.sample(sorted, limit) as ContinueReading[]; // _.sample doesn't preserve type
      sorted = _.sortBy(sampled, r =>r.lastReadTime); // need to sort again because _.sample doesn't guarantee order
      sorted.reverse();
      return {
        entries: sorted,
        showAllLink: true,
      }
    } else {
      return {
        entries: sorted.slice(0, limit),
        showAllLink: true,
      }
    }
  }

  const { PostsItem, PostsLoading, SectionFooter } = Components;
  if (continueReadingLoading || !continueReading)
    return <PostsLoading/>

  const { entries, showAllLink } = limitResumeReading(continueReading);

  return <div>
    <AnalyticsContext pageSubSectionContext="continueReadingList" capturePostItemOnMount>
      {entries.map(resumeReading => {
        const { nextPost, sequence, collection } = resumeReading;
        return <PostsItem
          post={nextPost}
          sequenceId={sequence?._id}
          resumeReading={resumeReading}
          dismissRecommendation={() => dismissAndHideRecommendation(nextPost._id)}
          key={sequence?._id || collection?._id}
        />
      })}
      {showAllLink && <SectionFooter>
        <a onClick={() => setShowAll(true)}>
          Show All
        </a>
      </SectionFooter>}
    </AnalyticsContext>
  </div>
}

const ContinueReadingListComponent = registerComponent('ContinueReadingList', ContinueReadingList);

declare global {
  interface ComponentTypes {
    ContinueReadingList: typeof ContinueReadingListComponent
  }
}



1	import React, { useState } from 'react';	1✔
2	import { Components, registerComponent } from '../../lib/vulcan-lib';	1✔
3	import { useDismissRecommendation } from './withDismissRecommendation';	1✔
4	import { captureEvent, AnalyticsContext } from '../../lib/analyticsEvents';	1✔
5	import * as _ from 'underscore';	1✔
6	import { ContinueReading } from './withContinueReading';
7
8
9	const ContinueReadingList = ({ continueReading, continueReadingLoading, limit=3, shuffle }: {	1!
10	continueReading: ContinueReading[],
11	continueReadingLoading?: boolean,
12	limit?: number,
13	// randomly select posts from your reading list if your reading list is longer than the limit
14	shuffle?: boolean,
15	}) => {
16	const dismissRecommendation = useDismissRecommendation();	×
17	const [dismissedRecommendations, setDismissedRecommendations] = useState<any>({});	×
18	const [showAll, setShowAll] = useState(false);	×
19
20	const dismissAndHideRecommendation = (postId: string) => {	×
21	void dismissRecommendation(postId);	×
22	setDismissedRecommendations({	×
23	...dismissedRecommendations,
24	[postId]: true
25	});
26	captureEvent("continueReadingDismissed", {"postId": postId});	×
27	}
28
NEW 29	const limitResumeReading = (resumeReadingList: ContinueReading[]): { entries: ContinueReading[], showAllLink: boolean } => {	×
30	// Filter out dismissed recommendations
31	const filtered = _.filter(resumeReadingList, r=>!dismissedRecommendations[r.nextPost._id]);	×
32
33	// Sort by last-interaction time
34	let sorted = _.sortBy(filtered, r=>r.lastReadTime);	×
35	sorted.reverse(); //in-place	×
36
37	// Limit to the three most recent
NEW 38	if (showAll \|\| sorted.length <= limit) {	×
39	return {	×
40	entries: sorted,
41	showAllLink: false,
42	};
NEW 43	} else if (shuffle) {	×
NEW 44	const sampled = _.sample(sorted, limit) as ContinueReading[]; // _.sample doesn't preserve type	×
NEW 45	sorted = _.sortBy(sampled, r =>r.lastReadTime); // need to sort again because _.sample doesn't guarantee order	×
NEW 46	sorted.reverse();	×
NEW 47	return {	×
48	entries: sorted,
49	showAllLink: true,
50	}
51	} else {
52	return {	×
53	entries: sorted.slice(0, limit),
54	showAllLink: true,
55	}
56	}
57	}
58
59	const { PostsItem, PostsLoading, SectionFooter } = Components;	×
60	if (continueReadingLoading \|\| !continueReading)	×
61	return <PostsLoading/>	×
62
63	const { entries, showAllLink } = limitResumeReading(continueReading);	×
64
65	return <div>	×
66	<AnalyticsContext pageSubSectionContext="continueReadingList" capturePostItemOnMount>
67	{entries.map(resumeReading => {
68	const { nextPost, sequence, collection } = resumeReading;	×
69	return <PostsItem	×
70	post={nextPost}
71	sequenceId={sequence?._id}	×
72	resumeReading={resumeReading}
73	dismissRecommendation={() => dismissAndHideRecommendation(nextPost._id)}	×
74	key={sequence?._id \|\| collection?._id}	×
75	/>
76	})}
77	{showAllLink && <SectionFooter>	×
78	<a onClick={() => setShowAll(true)}>	×
79	Show All
80	</a>
81	</SectionFooter>}
82	</AnalyticsContext>
83	</div>
84	}
85
86	const ContinueReadingListComponent = registerComponent('ContinueReadingList', ContinueReadingList);	1✔
87
88	declare global {
89	interface ComponentTypes {
90	ContinueReadingList: typeof ContinueReadingListComponent
91	}
92	}
93
94

ForumMagnum / ForumMagnum / 8823918904

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous