8789411561

Committed 22 Apr 2024 06:58PM UTC coverage: 32.057% (-0.01%) from 32.069%

Build # 8789411561

Build Type

Pull #8981

github

Committed by

oetherington

Commit Message

Fix missing import

Pull Request Pull Request #8981: [EA] People directory

Run Details

4691 of 38171 branches covered (12.29%)

Branch coverage included in aggregate %.

251 of 599 new or added lines in 52 files covered. (41.9%)

11 existing lines in 6 files now uncovered.

27370 of 61840 relevant lines covered (44.26%)

181.09 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

23.33

/packages/lesswrong/components/peopleDirectory/PeopleDirectoryHeading.tsx

import React, { useCallback } from "react";
import { Components, registerComponent } from "../../lib/vulcan-lib";
import { PeopleDirectoryColumn } from "./peopleDirectoryColumns";
import { usePeopleDirectory } from "./usePeopleDirectory";
import { COLUMN_HORIZONTAL_PADDING } from "./PeopleDirectoryResultRow";

const styles = (theme: ThemeType) => ({
  root: {
    display: "flex",
    alignItems: "center",
    fontSize: 14,
    fontWeight: 600,
    padding: `8px ${COLUMN_HORIZONTAL_PADDING}px`,
    whiteSpace: "nowrap",
    color: theme.palette.grey[600],
  },
  icon: {
    cursor: "pointer",
    width: 16,
  },
});

export const PeopleDirectoryHeading = ({column, classes}: {
  column: PeopleDirectoryColumn,
  classes: ClassesType<typeof styles>,
}) => {
  const {sorting, setSorting} = usePeopleDirectory();

  const onToggleSort = useCallback(() => {
    if (!column.sortField) {
      return;
    } else if (sorting?.field === column.sortField) {
      if (sorting.direction === "asc") {
        setSorting({
          field: column.sortField,
          direction: "desc",
        });
      } else {
        setSorting(null);
      }
    } else {
      setSorting({
        field: column.sortField,
        direction: "asc",
      });
    }
  }, [sorting, setSorting, column.sortField]);

  const {ForumIcon} = Components;
  return (
    <div className={classes.root}>
      {column.shortLabel ?? column.label}
      {column.sortField &&
        <ForumIcon
          icon="ChevronUpDown"
          onClick={onToggleSort}
          className={classes.icon}
        />
      }
    </div>
  );
}

const PeopleDirectoryHeadingComponent = registerComponent(
  "PeopleDirectoryHeading",
  PeopleDirectoryHeading,
  {styles},
);

declare global {
  interface ComponentTypes {
    PeopleDirectoryHeading: typeof PeopleDirectoryHeadingComponent
  }
}

1	import React, { useCallback } from "react";	3✔
2	import { Components, registerComponent } from "../../lib/vulcan-lib";	1✔
3	import { PeopleDirectoryColumn } from "./peopleDirectoryColumns";
4	import { usePeopleDirectory } from "./usePeopleDirectory";	1✔
5	import { COLUMN_HORIZONTAL_PADDING } from "./PeopleDirectoryResultRow";	1✔
6
7	const styles = (theme: ThemeType) => ({	1✔
8	root: {
9	display: "flex",
10	alignItems: "center",
11	fontSize: 14,
12	fontWeight: 600,
13	padding: `8px ${COLUMN_HORIZONTAL_PADDING}px`,
14	whiteSpace: "nowrap",
15	color: theme.palette.grey[600],
16	},
17	icon: {
18	cursor: "pointer",
19	width: 16,
20	},
21	});
22
23	export const PeopleDirectoryHeading = ({column, classes}: {	1✔
24	column: PeopleDirectoryColumn,
25	classes: ClassesType<typeof styles>,
26	}) => {
NEW 27	const {sorting, setSorting} = usePeopleDirectory();	×
28
NEW 29	const onToggleSort = useCallback(() => {	×
NEW 30	if (!column.sortField) {	×
NEW 31	return;	×
NEW 32	} else if (sorting?.field === column.sortField) {	×
NEW 33	if (sorting.direction === "asc") {	×
NEW 34	setSorting({	×
35	field: column.sortField,
36	direction: "desc",
37	});
38	} else {
NEW 39	setSorting(null);	×
40	}
41	} else {
NEW 42	setSorting({	×
43	field: column.sortField,
44	direction: "asc",
45	});
46	}
47	}, [sorting, setSorting, column.sortField]);
48
NEW 49	const {ForumIcon} = Components;	×
NEW 50	return (	×
51	<div className={classes.root}>
52	{column.shortLabel ?? column.label}	×
53	{column.sortField &&	×
54	<ForumIcon
55	icon="ChevronUpDown"
56	onClick={onToggleSort}
57	className={classes.icon}
58	/>
59	}
60	</div>
61	);
62	}
63
64	const PeopleDirectoryHeadingComponent = registerComponent(	1✔
65	"PeopleDirectoryHeading",
66	PeopleDirectoryHeading,
67	{styles},
68	);
69
70	declare global {
71	interface ComponentTypes {
72	PeopleDirectoryHeading: typeof PeopleDirectoryHeadingComponent
73	}
74	}

ForumMagnum / ForumMagnum / 8789411561

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous