8781927745

Committed 22 Apr 2024 09:42AM UTC coverage: 46.508% (-46.5%) from 92.966%

Build # 8781927745

Build Type

Pull #1434

github

Committed by

web-flow

Commit Message

Merge 8213b362a into 417fc6a52

Pull Request Pull Request #1434: Add SwapOrderHelper

Run Details

321 of 2224 branches covered (14.43%)

Branch coverage included in aggregate %.

33 of 60 new or added lines in 7 files covered. (55.0%)

2468 existing lines in 238 files now uncovered.

3695 of 6411 relevant lines covered (57.64%)

8.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.67

/src/routes/common/guards/only-safe-owner.guard.ts

import {
  CanActivate,
  ExecutionContext,
  Inject,
  Injectable,
} from '@nestjs/common';
import { ISafeRepository } from '@/domain/safe/safe.repository.interface';

/**
 * The OnlySafeOwner guard can be applied to any route that requires
 * that a provided 'signer' (owner) is part of a Safe
 *
 * This guard does not validate that a message came from said owner.
 *
 * To use this guard, the route should have:
 * - the 'chainId' as part of the path parameters
 * - the 'safeAddress' as part of the path parameters
 * - the 'signer' as part of the path parameters or as part of the JSON body (top level)
 */
@Injectable()
export class OnlySafeOwnerGuard implements CanActivate {
  constructor(
    @Inject(ISafeRepository) private readonly safeRepository: ISafeRepository,
  ) {}

  async canActivate(context: ExecutionContext): Promise<boolean> {
    const request = context.switchToHttp().getRequest();

    const chainId = request.params['chainId'];
    const safe = request.params['safeAddress'];
    const signer = request.params['signer'] ?? request.body['signer'];

    // Required fields
    if (!chainId || !safe || !signer) return false;

    return await this.safeRepository.isOwner({
      chainId,
      safeAddress: safe,
      address: signer,
    });
  }
}

1	import {	14✔
2	CanActivate,
3	ExecutionContext,
4	Inject,
5	Injectable,
6	} from '@nestjs/common';
7	import { ISafeRepository } from '@/domain/safe/safe.repository.interface';	14✔
8
9	/**
10	* The OnlySafeOwner guard can be applied to any route that requires
11	* that a provided 'signer' (owner) is part of a Safe
12	*
13	* This guard does not validate that a message came from said owner.
14	*
15	* To use this guard, the route should have:
16	* - the 'chainId' as part of the path parameters
17	* - the 'safeAddress' as part of the path parameters
18	* - the 'signer' as part of the path parameters or as part of the JSON body (top level)
19	*/
20	@Injectable()
21	export class OnlySafeOwnerGuard implements CanActivate {	14✔
22	constructor(
UNCOV 23	@Inject(ISafeRepository) private readonly safeRepository: ISafeRepository,	×
24	) {}
25
26	async canActivate(context: ExecutionContext): Promise<boolean> {
UNCOV 27	const request = context.switchToHttp().getRequest();	×
28
UNCOV 29	const chainId = request.params['chainId'];	×
UNCOV 30	const safe = request.params['safeAddress'];	×
UNCOV 31	const signer = request.params['signer'] ?? request.body['signer'];	×
32
33	// Required fields
UNCOV 34	if (!chainId \|\| !safe \|\| !signer) return false;	×
35
UNCOV 36	return await this.safeRepository.isOwner({	×
37	chainId,
38	safeAddress: safe,
39	address: signer,
40	});
41	}
42	}

safe-global / safe-client-gateway / 8781927745

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous