8766121206

Committed 20 Apr 2024 03:45PM UTC coverage: 83.956% (-2.9%) from 86.892%

Build # 8766121206

Build Type

push

github

Committed by

andgineer

Commit Message

upgrade reqs

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

89 existing lines in 23 files now uncovered.

1057 of 1259 relevant lines covered (83.96%)

0.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.67

/src/controllers/users/update.py

from typing import Any, Dict

import controllers.models
import db.conn
import db.models
from controllers.auth import AuthUser
from controllers.helper import api_result, token_to_auth_user, transaction
from journaling import log


# mypy: disallow_untyped_decorators=False
@api_result
@transaction
@token_to_auth_user
def update_user(auth_user: AuthUser, user_id: str, update_user: Dict[str, Any]) -> Dict[str, Any]:
    """Update user."""
    update_user_obj = controllers.models.UpdateUser(update_user)
    update_user_obj.validate()
    user = db.models.User.by_id(user_id)
    if user.email.lower() != auth_user.email.lower() and not auth_user.is_admin:
        return (  # type: ignore
            f"Only user himself or admin can update user <{user.email}> properties, not <{auth_user.email}>.",
            controllers.models.HttpCode.unauthorized,
        )
    if update_user_obj.email.lower() != user.email.lower():
        return (  # type: ignore
            f"You cannot change user email (current <{user.email}>, new <{update_user_obj.email}>)",
            controllers.models.HttpCode.logic_error,
        )
    update_user_db = update_user_obj.to_orm
    for field in update_user_db:
        setattr(user, field, update_user_db[field])
    db.conn.session.commit()
    log.info(f"Updated user [{user}]")
    return update_user_obj.as_dict

1	from typing import Any, Dict	1✔
2
3	import controllers.models	1✔
4	import db.conn	1✔
5	import db.models	1✔
6	from controllers.auth import AuthUser	1✔
7	from controllers.helper import api_result, token_to_auth_user, transaction	1✔
8	from journaling import log	1✔
9
10
11	# mypy: disallow_untyped_decorators=False
12	@api_result	1✔
13	@transaction	1✔
14	@token_to_auth_user	1✔
15	def update_user(auth_user: AuthUser, user_id: str, update_user: Dict[str, Any]) -> Dict[str, Any]:	1✔
16	"""Update user."""
17	update_user_obj = controllers.models.UpdateUser(update_user)	1✔
18	update_user_obj.validate()	1✔
19	user = db.models.User.by_id(user_id)	1✔
20	if user.email.lower() != auth_user.email.lower() and not auth_user.is_admin:	1✔
UNCOV 21	return ( # type: ignore	×
22	f"Only user himself or admin can update user <{user.email}> properties, not <{auth_user.email}>.",
23	controllers.models.HttpCode.unauthorized,
24	)
25	if update_user_obj.email.lower() != user.email.lower():	1✔
UNCOV 26	return ( # type: ignore	×
27	f"You cannot change user email (current <{user.email}>, new <{update_user_obj.email}>)",
28	controllers.models.HttpCode.logic_error,
29	)
30	update_user_db = update_user_obj.to_orm	1✔
31	for field in update_user_db:	1✔
32	setattr(user, field, update_user_db[field])	1✔
33	db.conn.session.commit()	1✔
34	log.info(f"Updated user [{user}]")	1✔
35	return update_user_obj.as_dict	1✔

andgineer / api-db-prototype / 8766121206

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous