8758732291

Committed 19 Apr 2024 07:37PM UTC coverage: 32.054% (-0.03%) from 32.08%

Build # 8758732291

Build Type

Pull #9130

github

Committed by

b0b3rt

Commit Message

remove unused hook

Pull Request Pull Request #9130: [LW] Frontpage Tabs for the masses (including a recommendations one)

Run Details

4683 of 38018 branches covered (12.32%)

Branch coverage included in aggregate %.

45 of 161 new or added lines in 14 files covered. (27.95%)

3 existing lines in 3 files now uncovered.

27185 of 61402 relevant lines covered (44.27%)

182.03 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

18.18

/packages/lesswrong/components/posts/PostsList2.tsx

import React from 'react';
import { Components, registerComponent } from '../../lib/vulcan-lib/components';
import { decodeIntlError } from '../../lib/vulcan-lib/utils';
import classNames from 'classnames';
import { PostsListConfig, usePostsList } from './usePostsList';
import FormattedMessage from '../../lib/vulcan-i18n/message';
import moment from 'moment';
import { isEAForum } from '../../lib/instanceSettings';

const Error = ({error}: any) => <div>
  <FormattedMessage id={error.id} values={{value: error.value}}/>{error.message}
</div>;

const styles = (theme: ThemeType): JssStyles => ({
  itemIsLoading: {
    opacity: .4,
  },
  posts: {
    boxShadow: theme.palette.boxShadow.default,
  },
});

type PostsList2Props = PostsListConfig & {classes: ClassesType};

/** A list of posts, defined by a query that returns them. */
const PostsList2 = ({classes, ...props}: PostsList2Props) => {
  const {
    children,
    showNoResults,
    hideLastUnread,
    showLoadMore,
    showLoading,
    dimWhenLoading,
    loading,
    topLoading,
    boxShadow,
    error,
    loadMore,
    loadMoreProps,
    maybeMorePosts,
    orderedResults,
    itemProps,
    limit,
    placeholderCount,
    showFinalBottomBorder,
  } = usePostsList(props);

  const { Loading, LoadMore, PostsNoResults, SectionFooter, PostsItem, PostsLoading } = Components;

  if (!orderedResults && loading) {
    return <PostsLoading placeholderCount={placeholderCount || limit} showFinalBottomBorder={showFinalBottomBorder} />
  }

  if (!orderedResults?.length && !showNoResults) {
    return null
  }
  
  // If this is the EA Forum frontpage pinned curated posts list,
  // and we haven't curated a post in the last 5 days,
  // then hide this entire section.
  if (
    isEAForum &&
    hideLastUnread &&
    !!orderedResults?.[0].curatedDate &&
    moment(orderedResults[0].curatedDate).isBefore(moment().subtract(5, 'days'))
  ) {
    return null
  }

  return (
    <div className={classNames({[classes.itemIsLoading]: loading && dimWhenLoading})}>
      {error && <Error error={decodeIntlError(error)} />}
      {loading && showLoading && (topLoading || dimWhenLoading) && <PostsLoading placeholderCount={placeholderCount || limit} />}
      {orderedResults && !orderedResults.length && <PostsNoResults />}

      <div className={boxShadow ? classes.posts : undefined}>
        {itemProps?.map((props) => <PostsItem key={props.post._id} {...props} />)}
      </div>
      {showLoadMore && <SectionFooter>
        <LoadMore
          {...loadMoreProps}
          loading={loading}
          loadMore={loadMore}
          hideLoading={dimWhenLoading || !showLoading}
          // It's important to use hidden here rather than not rendering the component,
          // because LoadMore has an "isFirstRender" check that prevents it from showing loading dots
          // on the first render. Not rendering resets this
          hidden={!maybeMorePosts && !loading}
          sectionFooterStyles
        />
        { children }
      </SectionFooter>}
    </div>
  )
}

const PostsList2Component = registerComponent('PostsList2', PostsList2, {
  styles,
  areEqual: {
    terms: "deep",
  },
});

declare global {
  interface ComponentTypes {
    PostsList2: typeof PostsList2Component
  }
}

1	import React from 'react';	1✔
2	import { Components, registerComponent } from '../../lib/vulcan-lib/components';	1✔
3	import { decodeIntlError } from '../../lib/vulcan-lib/utils';	1✔
4	import classNames from 'classnames';	1✔
5	import { PostsListConfig, usePostsList } from './usePostsList';	1✔
6	import FormattedMessage from '../../lib/vulcan-i18n/message';	1✔
7	import moment from 'moment';	1✔
8	import { isEAForum } from '../../lib/instanceSettings';	1✔
9
10	const Error = ({error}: any) => <div>	1✔
11	<FormattedMessage id={error.id} values={{value: error.value}}/>{error.message}
12	</div>;
13
14	const styles = (theme: ThemeType): JssStyles => ({	1✔
15	itemIsLoading: {
16	opacity: .4,
17	},
18	posts: {
19	boxShadow: theme.palette.boxShadow.default,
20	},
21	});
22
23	type PostsList2Props = PostsListConfig & {classes: ClassesType};
24
25	/** A list of posts, defined by a query that returns them. */
26	const PostsList2 = ({classes, ...props}: PostsList2Props) => {	1✔
27	const {
28	children,
29	showNoResults,
30	hideLastUnread,
31	showLoadMore,
32	showLoading,
33	dimWhenLoading,
34	loading,
35	topLoading,
36	boxShadow,
37	error,
38	loadMore,
39	loadMoreProps,
40	maybeMorePosts,
41	orderedResults,
42	itemProps,
43	limit,
44	placeholderCount,
45	showFinalBottomBorder,
NEW 46	} = usePostsList(props);	×
47
NEW 48	const { Loading, LoadMore, PostsNoResults, SectionFooter, PostsItem, PostsLoading } = Components;	×
49
50	if (!orderedResults && loading) {	×
NEW 51	return <PostsLoading placeholderCount={placeholderCount \|\| limit} showFinalBottomBorder={showFinalBottomBorder} />	×
52	}
53
54	if (!orderedResults?.length && !showNoResults) {	×
55	return null	×
56	}
57
58	// If this is the EA Forum frontpage pinned curated posts list,
59	// and we haven't curated a post in the last 5 days,
60	// then hide this entire section.
61	if (	×
62	isEAForum &&	×
63	hideLastUnread &&
64	!!orderedResults?.[0].curatedDate &&	×
65	moment(orderedResults[0].curatedDate).isBefore(moment().subtract(5, 'days'))
66	) {
67	return null	×
68	}
69
70	return (	×
71	<div className={classNames({[classes.itemIsLoading]: loading && dimWhenLoading})}>	×
72	{error && <Error error={decodeIntlError(error)} />}	×
73	{loading && showLoading && (topLoading \|\| dimWhenLoading) && <PostsLoading placeholderCount={placeholderCount \|\| limit} />}	×
74	{orderedResults && !orderedResults.length && <PostsNoResults />}	×
75
76	<div className={boxShadow ? classes.posts : undefined}>	×
77	{itemProps?.map((props) => <PostsItem key={props.post._id} {...props} />)}	×
78	</div>
79	{showLoadMore && <SectionFooter>	×
80	<LoadMore
81	{...loadMoreProps}
82	loading={loading}
83	loadMore={loadMore}
84	hideLoading={dimWhenLoading \|\| !showLoading}	×
85	// It's important to use hidden here rather than not rendering the component,
86	// because LoadMore has an "isFirstRender" check that prevents it from showing loading dots
87	// on the first render. Not rendering resets this
88	hidden={!maybeMorePosts && !loading}	×
89	sectionFooterStyles
90	/>
91	{ children }
92	</SectionFooter>}
93	</div>
94	)
95	}
96
97	const PostsList2Component = registerComponent('PostsList2', PostsList2, {	1✔
98	styles,
99	areEqual: {
100	terms: "deep",
101	},
102	});
103
104	declare global {
105	interface ComponentTypes {
106	PostsList2: typeof PostsList2Component
107	}
108	}

ForumMagnum / ForumMagnum / 8758732291

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous