#391

Committed 19 Apr 2024 02:19PM UTC coverage: 73.279% (-0.3%) from 73.587%

Build # #391

Build Type

push

Committed by

Commit Message

Added extensions and Rate limiting options (#314)

* Added extensions and Rate limiting options

Run Details

120 of 169 new or added lines in 18 files covered. (71.01%)

5 existing lines in 1 file now uncovered.

2523 of 3443 relevant lines covered (73.28%)

0.73 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/server/ExceptionWrappingHMSHandler.java

/**
 * Copyright (C) 2016-2024 Expedia, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.hotels.bdp.waggledance.server;

import java.lang.reflect.InvocationHandler;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
import java.lang.reflect.UndeclaredThrowableException;
import java.util.Arrays;

import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.hive.metastore.HiveMetaStore.HMSHandler;
import org.apache.hadoop.hive.metastore.IHMSHandler;
import org.apache.hadoop.hive.metastore.api.MetaException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import com.hotels.bdp.waggledance.server.security.NotAllowedException;

public class ExceptionWrappingHMSHandler implements InvocationHandler {

  private final static Logger LOG = LoggerFactory.getLogger(ExceptionWrappingHMSHandler.class);

  private final IHMSHandler baseHandler;
  private String user = "";

  public static IHMSHandler newProxyInstance(IHMSHandler baseHandler) {
    return (IHMSHandler) Proxy
        .newProxyInstance(ExceptionWrappingHMSHandler.class.getClassLoader(), new Class[] { IHMSHandler.class },
            new ExceptionWrappingHMSHandler(baseHandler));
  }

  public ExceptionWrappingHMSHandler(IHMSHandler baseHandler) {
    this.baseHandler = baseHandler;
  }

  @Override
  public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
    if (method.getName().equals("set_ugi")) {
      user = (String) args[0];
    }
    try {
      LOG
          .info("WD Audit:[User:{}, method:{}, source_ip:{}, args:{}]", user, method.getName(),
              HMSHandler.getThreadLocalIpAddress(), StringUtils.left(Arrays.toString(args), 256));
      return method.invoke(baseHandler, args);
    } catch (InvocationTargetException e) {
      Throwable cause = e.getCause();
      if (cause instanceof NotAllowedException) {
        // not logging this as this is an "expected" exception, just rewriting it so any client can do something with
        // the thrift exception.
        throw new MetaException("Waggle Dance: " + cause.getMessage());
      } else if (cause instanceof WaggleDanceServerException) {
        LOG.debug("Got error processing '{}' with args '{}'", method, Arrays.toString(args), cause);
        throw new MetaException("Waggle Dance: " + cause.getMessage());
      } else {
        // Need to unwrap this, so callers get the correct exception thrown by the handler.
        throw e.getCause();
      }
    } catch (UndeclaredThrowableException e) {
      // Need to unwrap this, so callers get the correct exception thrown by the handler.
      throw e.getCause();
    }
  }

}

1	/**
2	* Copyright (C) 2016-2024 Expedia, Inc.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.hotels.bdp.waggledance.server;
17
18	import java.lang.reflect.InvocationHandler;
19	import java.lang.reflect.InvocationTargetException;
20	import java.lang.reflect.Method;
21	import java.lang.reflect.Proxy;
22	import java.lang.reflect.UndeclaredThrowableException;
23	import java.util.Arrays;
24
25	import org.apache.commons.lang3.StringUtils;
26	import org.apache.hadoop.hive.metastore.HiveMetaStore.HMSHandler;
27	import org.apache.hadoop.hive.metastore.IHMSHandler;
28	import org.apache.hadoop.hive.metastore.api.MetaException;
29	import org.slf4j.Logger;
30	import org.slf4j.LoggerFactory;
31
32	import com.hotels.bdp.waggledance.server.security.NotAllowedException;
33
34	public class ExceptionWrappingHMSHandler implements InvocationHandler {
35
36	private final static Logger LOG = LoggerFactory.getLogger(ExceptionWrappingHMSHandler.class);	1✔
37
38	private final IHMSHandler baseHandler;
39	private String user = "";	1✔
40
41	public static IHMSHandler newProxyInstance(IHMSHandler baseHandler) {
42	return (IHMSHandler) Proxy	1✔
43	.newProxyInstance(ExceptionWrappingHMSHandler.class.getClassLoader(), new Class[] { IHMSHandler.class },	1✔
44	new ExceptionWrappingHMSHandler(baseHandler));	1✔
45	}
46
47	public ExceptionWrappingHMSHandler(IHMSHandler baseHandler) {	1✔
48	this.baseHandler = baseHandler;	1✔
49	}	1✔
50
51	@Override
52	public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
53	if (method.getName().equals("set_ugi")) {	1✔
NEW 54	user = (String) args[0];	×
55	}
56	try {
57	LOG	1✔
58	.info("WD Audit:[User:{}, method:{}, source_ip:{}, args:{}]", user, method.getName(),	1✔
59	HMSHandler.getThreadLocalIpAddress(), StringUtils.left(Arrays.toString(args), 256));	1✔
60	return method.invoke(baseHandler, args);	1✔
61	} catch (InvocationTargetException e) {	1✔
62	Throwable cause = e.getCause();	1✔
63	if (cause instanceof NotAllowedException) {	1✔
64	// not logging this as this is an "expected" exception, just rewriting it so any client can do something with
65	// the thrift exception.
66	throw new MetaException("Waggle Dance: " + cause.getMessage());	1✔
67	} else if (cause instanceof WaggleDanceServerException) {	1✔
68	LOG.debug("Got error processing '{}' with args '{}'", method, Arrays.toString(args), cause);	1✔
69	throw new MetaException("Waggle Dance: " + cause.getMessage());	1✔
70	} else {
71	// Need to unwrap this, so callers get the correct exception thrown by the handler.
72	throw e.getCause();	1✔
73	}
74	} catch (UndeclaredThrowableException e) {	×
75	// Need to unwrap this, so callers get the correct exception thrown by the handler.
76	throw e.getCause();	×
77	}
78	}
79
80	}

HotelsDotCom / waggle-dance / #391

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous