8729987205

Committed 17 Apr 2024 11:28PM UTC coverage: 32.014% (-0.02%) from 32.035%

Build # 8729987205

Build Type

push

github

Committed by

darkruby501

Commit Message

Merge remote-tracking branch 'origin/sidescroll-frontpage-tabs' into tab-picker-recombee-launch

Run Details

4662 of 38005 branches covered (12.27%)

Branch coverage included in aggregate %.

11 of 76 new or added lines in 8 files covered. (14.47%)

2 existing lines in 2 files now uncovered.

27138 of 61325 relevant lines covered (44.25%)

182.74 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

20.83

/packages/lesswrong/components/posts/RecombeePostsList.tsx

import React from 'react';
import { Components, fragmentTextForQuery, registerComponent } from '../../lib/vulcan-lib';
import { NetworkStatus, gql, useQuery } from '@apollo/client';
import { HybridRecombeeConfiguration, RecombeeConfiguration } from '../../lib/collections/users/recommendationSettings';
import { useOnMountTracking } from '../../lib/analyticsEvents';
import uniq from 'lodash/uniq';
import { filterNonnull } from '../../lib/utils/typeGuardUtils';
import { isServer } from '../../lib/executionEnvironment';

// Would be nice not to duplicate in postResolvers.ts but unfortunately the post types are different
interface RecombeeRecommendedPost {
  post: PostsListWithVotes,
  recommId: string,
  curated?: never,
  stickied?: never,
}

type RecommendedPost = RecombeeRecommendedPost | {
  post: PostsListWithVotes,
  recommId?: never,
  curated: boolean,
  stickied: boolean,
};

const styles = (theme: ThemeType) => ({
  root: {

  }
});

const DEFAULT_RESOLVER_NAME = 'RecombeeLatestPosts';
const HYBRID_RESOLVER_NAME = 'RecombeeHybridPosts';

type RecombeeResolver = typeof DEFAULT_RESOLVER_NAME | typeof HYBRID_RESOLVER_NAME;

const getRecombeePostsQuery = (resolverName: RecombeeResolver) => gql`
  query get${resolverName}($limit: Int, $settings: JSON) {
    ${resolverName}(limit: $limit, settings: $settings) {
      results {
        post {
          ...PostsListWithVotes
        }
        recommId
        curated
        stickied
      }
    }
  }
  ${fragmentTextForQuery('PostsListWithVotes')}
`;

const getLoadMoreSettings = (resolverName: RecombeeResolver, results: RecommendedPost[]): (RecombeeConfiguration | HybridRecombeeConfiguration)['loadMore'] => {
  switch (resolverName) {
    case DEFAULT_RESOLVER_NAME:
      const prevRecommId = results.find(result => result.recommId)?.recommId;
      if (!prevRecommId) {
        return undefined;
      }
      return { prevRecommId };  
    case HYBRID_RESOLVER_NAME:
      const [firstRecommId, secondRecommId] = filterNonnull(uniq(results.map(({ recommId }) => recommId)));
      return { prevRecommIds: [firstRecommId, secondRecommId] };
  }
}

export const stickiedPostTerms: PostsViewTerms = {
  view: 'stickied',
  limit: 4, // seriously, shouldn't have more than 4 stickied posts
  forum: true
};

export const RecombeePostsList = ({ algorithm, settings, limit = 15, classes }: {
  algorithm: string,
  settings: RecombeeConfiguration,
  limit?: number,
  classes: ClassesType<typeof styles>,
}) => {
  const { Loading, LoadMore, PostsItem, SectionFooter, PostsLoading } = Components;

  const recombeeSettings = { ...settings, scenario: algorithm };

  const resolverName = algorithm === 'recombee-hybrid'
    ? HYBRID_RESOLVER_NAME
    : DEFAULT_RESOLVER_NAME;

  const query = getRecombeePostsQuery(resolverName);
  const { data, loading, fetchMore, networkStatus } = useQuery(query, {
    ssr: false || !isServer,
    notifyOnNetworkStatusChange: true,
    pollInterval: 0,
    variables: {
      limit,
      settings: recombeeSettings,
    },
  });

  const results: RecommendedPost[] | undefined = data?.[resolverName]?.results;
  const postIds = results?.map(({post}) => post._id) ?? [];

  useOnMountTracking({
    eventType: "postList",
    eventProps: { postIds },
    captureOnMount: (eventProps) => eventProps.postIds.length > 0,
    skip: !postIds.length || loading,
  });

  if (loading && !results) {
    return <PostsLoading placeholderCount={limit} />;
  }

  if (!results) {
    return null;
  }


  return <div>
    <div className={classes.root}>
      {results.map(({ post, recommId, curated, stickied }) => <PostsItem 
        key={post._id} 
        post={post} 
        recombeeRecommId={recommId} 
        curatedIconLeft={curated} 
        terms={stickied ? stickiedPostTerms : undefined}
      />)}
    </div>
    <SectionFooter>
      <LoadMore
        loading={loading || networkStatus === NetworkStatus.fetchMore}
        loadMore={() => {
          const loadMoreSettings = getLoadMoreSettings(resolverName, results);
          void fetchMore({
            variables: {
              settings: { ...recombeeSettings, loadMore: loadMoreSettings },
            },
            // Update the apollo cache with the combined results of previous loads and the items returned by the current loadMore
            updateQuery: (prev: AnyBecauseHard, { fetchMoreResult }: AnyBecauseHard) => {
              if (!fetchMoreResult) return prev;

              return {
                [resolverName]: {
                  __typename: fetchMoreResult[resolverName].__typename,
                  results: [...prev[resolverName].results, ...fetchMoreResult[resolverName].results]
                }
              };
            }
          });
        }}
        sectionFooterStyles
      />
    </SectionFooter>
  </div>;
}

const RecombeePostsListComponent = registerComponent('RecombeePostsList', RecombeePostsList, {styles});

declare global {
  interface ComponentTypes {
    RecombeePostsList: typeof RecombeePostsListComponent
  }
}

1	import React from 'react';	54✔
2	import { Components, fragmentTextForQuery, registerComponent } from '../../lib/vulcan-lib';	18✔
3	import { NetworkStatus, gql, useQuery } from '@apollo/client';	18✔
4	import { HybridRecombeeConfiguration, RecombeeConfiguration } from '../../lib/collections/users/recommendationSettings';
5	import { useOnMountTracking } from '../../lib/analyticsEvents';	18✔
6	import uniq from 'lodash/uniq';	18✔
7	import { filterNonnull } from '../../lib/utils/typeGuardUtils';	18✔
8	import { isServer } from '../../lib/executionEnvironment';	18✔
9
10	// Would be nice not to duplicate in postResolvers.ts but unfortunately the post types are different
11	interface RecombeeRecommendedPost {
12	post: PostsListWithVotes,
13	recommId: string,
14	curated?: never,
15	stickied?: never,
16	}
17
18	type RecommendedPost = RecombeeRecommendedPost \| {
19	post: PostsListWithVotes,
20	recommId?: never,
21	curated: boolean,
22	stickied: boolean,
23	};
24
25	const styles = (theme: ThemeType) => ({	18✔
26	root: {
27
28	}
29	});
30
31	const DEFAULT_RESOLVER_NAME = 'RecombeeLatestPosts';	18✔
32	const HYBRID_RESOLVER_NAME = 'RecombeeHybridPosts';	18✔
33
34	type RecombeeResolver = typeof DEFAULT_RESOLVER_NAME \| typeof HYBRID_RESOLVER_NAME;
35
36	const getRecombeePostsQuery = (resolverName: RecombeeResolver) => gql`	18✔
37	query get${resolverName}($limit: Int, $settings: JSON) {
38	${resolverName}(limit: $limit, settings: $settings) {
39	results {
40	post {
41	...PostsListWithVotes
42	}
43	recommId
44	curated
45	stickied
46	}
47	}
48	}
49	${fragmentTextForQuery('PostsListWithVotes')}
50	`;
51
52	const getLoadMoreSettings = (resolverName: RecombeeResolver, results: RecommendedPost[]): (RecombeeConfiguration \| HybridRecombeeConfiguration)['loadMore'] => {	18✔
53	switch (resolverName) {	×
54	case DEFAULT_RESOLVER_NAME:
55	const prevRecommId = results.find(result => result.recommId)?.recommId;	×
56	if (!prevRecommId) {	×
57	return undefined;	×
58	}
59	return { prevRecommId };	×
60	case HYBRID_RESOLVER_NAME:
61	const [firstRecommId, secondRecommId] = filterNonnull(uniq(results.map(({ recommId }) => recommId)));	×
62	return { prevRecommIds: [firstRecommId, secondRecommId] };	×
63	}
64	}
65
66	export const stickiedPostTerms: PostsViewTerms = {	18✔
67	view: 'stickied',
68	limit: 4, // seriously, shouldn't have more than 4 stickied posts
69	forum: true
70	};
71
72	export const RecombeePostsList = ({ algorithm, settings, limit = 15, classes }: {	18!
73	algorithm: string,
74	settings: RecombeeConfiguration,
75	limit?: number,
76	classes: ClassesType<typeof styles>,
77	}) => {
NEW 78	const { Loading, LoadMore, PostsItem, SectionFooter, PostsLoading } = Components;	×
79
80	const recombeeSettings = { ...settings, scenario: algorithm };	×
81
82	const resolverName = algorithm === 'recombee-hybrid'	×
83	? HYBRID_RESOLVER_NAME	×
84	: DEFAULT_RESOLVER_NAME;
85
86	const query = getRecombeePostsQuery(resolverName);	×
87	const { data, loading, fetchMore, networkStatus } = useQuery(query, {	×
88	ssr: false \|\| !isServer,
89	notifyOnNetworkStatusChange: true,
90	pollInterval: 0,
91	variables: {
92	limit,
93	settings: recombeeSettings,
94	},
95	});
96
97	const results: RecommendedPost[] \| undefined = data?.[resolverName]?.results;	×
98	const postIds = results?.map(({post}) => post._id) ?? [];	×
99
100	useOnMountTracking({	×
101	eventType: "postList",
102	eventProps: { postIds },
103	captureOnMount: (eventProps) => eventProps.postIds.length > 0,	×
104	skip: !postIds.length \|\| loading,	×
105	});
106
107	if (loading && !results) {	×
NEW 108	return <PostsLoading placeholderCount={limit} />;	×
109	}
110
111	if (!results) {	×
112	return null;	×
113	}
114
115
116	return <div>	×
117	<div className={classes.root}>
118	{results.map(({ post, recommId, curated, stickied }) => <PostsItem	×
119	key={post._id}
120	post={post}
121	recombeeRecommId={recommId}
122	curatedIconLeft={curated}
123	terms={stickied ? stickiedPostTerms : undefined}	×
124	/>)}
125	</div>
126	<SectionFooter>
127	<LoadMore
128	loading={loading \|\| networkStatus === NetworkStatus.fetchMore}	×
129	loadMore={() => {
130	const loadMoreSettings = getLoadMoreSettings(resolverName, results);	×
131	void fetchMore({	×
132	variables: {
133	settings: { ...recombeeSettings, loadMore: loadMoreSettings },
134	},
135	// Update the apollo cache with the combined results of previous loads and the items returned by the current loadMore
136	updateQuery: (prev: AnyBecauseHard, { fetchMoreResult }: AnyBecauseHard) => {
137	if (!fetchMoreResult) return prev;	×
138
139	return {	×
140	[resolverName]: {
141	__typename: fetchMoreResult[resolverName].__typename,
142	results: [...prev[resolverName].results, ...fetchMoreResult[resolverName].results]
143	}
144	};
145	}
146	});
147	}}
148	sectionFooterStyles
149	/>
150	</SectionFooter>
151	</div>;
152	}
153
154	const RecombeePostsListComponent = registerComponent('RecombeePostsList', RecombeePostsList, {styles});	18✔
155
156	declare global {
157	interface ComponentTypes {
158	RecombeePostsList: typeof RecombeePostsListComponent
159	}
160	}

ForumMagnum / ForumMagnum / 8729987205

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous