8729440466

Committed 17 Apr 2024 10:22PM UTC coverage: 32.073% (+0.08%) from 31.992%

Build # 8729440466

Build Type

push

github

Committed by

jimrandomh

Commit Message

Merge branch 'redirect-commentid-urls' into lw-deploy

Run Details

4684 of 37966 branches covered (12.34%)

Branch coverage included in aggregate %.

170 of 365 new or added lines in 37 files covered. (46.58%)

8 existing lines in 6 files now uncovered.

27172 of 61356 relevant lines covered (44.29%)

182.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

25.0

/packages/lesswrong/components/posts/AllPostsList.tsx

import React from "react";
import { Components, registerComponent } from "../../lib/vulcan-lib";
import { useTimezone } from "../common/withTimezone";
import { useLocation } from "../../lib/routeUtil";
import { AllowHidingFrontPagePostsContext } from "../dropdowns/posts/PostActions";
import { AnalyticsContext } from "../../lib/analyticsEvents";
import {
  DEFAULT_LOW_KARMA_THRESHOLD,
  MAX_LOW_KARMA_THRESHOLD,
} from "../../lib/collections/posts/views";
import {
  getBeforeDefault,
  getAfterDefault,
  timeframeToTimeBlock,
  TimeframeType,
} from "./timeframeUtils";
import {
  forumAllPostsNumDaysSetting,
  DatabasePublicSetting,
} from "../../lib/publicSettings";
import type { PostsTimeBlockShortformOption } from "./PostsTimeBlock";
import { isFriendlyUI } from "../../themes/forumTheme";

// Number of weeks to display in the timeframe view
const forumAllPostsNumWeeksSetting = new DatabasePublicSetting<number>("forum.numberOfWeeks", 4);
// Number of months to display in the timeframe view
const forumAllPostsNumMonthsSetting = new DatabasePublicSetting<number>("forum.numberOfMonths", 4);
// Number of years to display in the timeframe view
const forumAllPostsNumYearsSetting = new DatabasePublicSetting<number>("forum.numberOfYears", 4);

const timeframeToNumTimeBlocks = {
  daily: forumAllPostsNumDaysSetting.get(),
  weekly: forumAllPostsNumWeeksSetting.get(),
  monthly: forumAllPostsNumMonthsSetting.get(),
  yearly: forumAllPostsNumYearsSetting.get(),
}

const AllPostsList = ({
  currentTimeframe,
  currentSorting,
  currentFilter,
  currentShowLowKarma,
  currentIncludeEvents,
  currentHideCommunity,
  showSettings,
}: {
  currentTimeframe: string,
  currentFilter: string,
  currentSorting: PostSortingMode,
  currentShowLowKarma: boolean,
  currentIncludeEvents: boolean,
  currentHideCommunity: boolean,
  showSettings: boolean,
}) => {
  const {timezone} = useTimezone();
  const {query} = useLocation();

  const baseTerms: PostsViewTerms = {
    karmaThreshold: query.karmaThreshold || (currentShowLowKarma
      ? MAX_LOW_KARMA_THRESHOLD
      : DEFAULT_LOW_KARMA_THRESHOLD),
    excludeEvents: !currentIncludeEvents && currentFilter !== "events",
    hideCommunity: currentHideCommunity,
    filter: currentFilter,
    sortedBy: currentSorting,
    after: query.after,
    before: query.before,
  };

  const {PostsTimeframeList, PostsTimeframeListExponential, PostsList2} = Components;

  if (currentTimeframe === "allTime") {
    return (
      <AnalyticsContext
        listContext={"allPostsPage"}
        terms={{view: "allTime" as PostsViewName, ...baseTerms}}
      >
        <PostsList2
          terms={{
            ...baseTerms,
            limit: 50
          }}
          dimWhenLoading={showSettings && !isFriendlyUI}
          showLoading={isFriendlyUI}
        />
      </AnalyticsContext>
    );
  }
  
  const numTimeBlocks = timeframeToNumTimeBlocks[currentTimeframe as TimeframeType];
  const timeBlock = timeframeToTimeBlock[currentTimeframe as TimeframeType];

  const postListParameters: PostsViewTerms = {
    view: "timeframe",
    ...baseTerms,
  };

  if (parseInt(query.limit)) {
    postListParameters.limit = parseInt(query.limit);
  }

  if (currentTimeframe === 'exponential') {
    return (
      <AnalyticsContext
        listContext={"allPostsPage"}
        terms={postListParameters}
      >
        <PostsTimeframeListExponential
          postListParameters={postListParameters}
        />
      </AnalyticsContext>
    );
  }

  const after = query.after || getAfterDefault({
    numTimeBlocks,
    timeBlock,
    timezone,
    before: query.before,
  });
  const before = query.before  || getBeforeDefault({
    timeBlock,
    timezone,
    after: query.after,
  });

  const hideTags = currentFilter !== "all";

  let shortform: PostsTimeBlockShortformOption = "all";
  if (currentFilter === "frontpage") {
    shortform = "frontpage";
  } else if (hideTags) {
    shortform = "none";
  }

  return (
    <div>
      <AnalyticsContext
        listContext={"allPostsPage"}
        terms={postListParameters}
        capturePostItemOnMount
      >
        {/* Allow unhiding posts from all posts menu to allow recovery of hiding
          * the wrong post */}
        <AllowHidingFrontPagePostsContext.Provider value={true}>
          <PostsTimeframeList
            // TODO: this doesn't seem to be guaranteed, actually?  Since it can
            // come from an unsanitized query param...
            timeframe={currentTimeframe as TimeframeType}
            postListParameters={postListParameters}
            numTimeBlocks={numTimeBlocks}
            dimWhenLoading={showSettings && !isFriendlyUI}
            after={after}
            before={before}
            reverse={query.reverse === "true"}
            shortform={query.includeShortform === "false" ? "none" : shortform}
            includeTags={!hideTags}
          />
        </AllowHidingFrontPagePostsContext.Provider>
      </AnalyticsContext>
    </div>
  );
}

const AllPostsListComponent = registerComponent("AllPostsList", AllPostsList);

declare global {
  interface ComponentTypes {
    AllPostsList: typeof AllPostsListComponent
  }
}

1	import React from "react";	1✔
2	import { Components, registerComponent } from "../../lib/vulcan-lib";	1✔
3	import { useTimezone } from "../common/withTimezone";	1✔
4	import { useLocation } from "../../lib/routeUtil";	1✔
5	import { AllowHidingFrontPagePostsContext } from "../dropdowns/posts/PostActions";	1✔
6	import { AnalyticsContext } from "../../lib/analyticsEvents";	1✔
7	import {
8	DEFAULT_LOW_KARMA_THRESHOLD,
9	MAX_LOW_KARMA_THRESHOLD,
10	} from "../../lib/collections/posts/views";	1✔
11	import {
12	getBeforeDefault,
13	getAfterDefault,
14	timeframeToTimeBlock,
15	TimeframeType,
16	} from "./timeframeUtils";	1✔
17	import {
18	forumAllPostsNumDaysSetting,
19	DatabasePublicSetting,
20	} from "../../lib/publicSettings";	1✔
21	import type { PostsTimeBlockShortformOption } from "./PostsTimeBlock";
22	import { isFriendlyUI } from "../../themes/forumTheme";	1✔
23
24	// Number of weeks to display in the timeframe view
25	const forumAllPostsNumWeeksSetting = new DatabasePublicSetting<number>("forum.numberOfWeeks", 4);	1✔
26	// Number of months to display in the timeframe view
27	const forumAllPostsNumMonthsSetting = new DatabasePublicSetting<number>("forum.numberOfMonths", 4);	1✔
28	// Number of years to display in the timeframe view
29	const forumAllPostsNumYearsSetting = new DatabasePublicSetting<number>("forum.numberOfYears", 4);	1✔
30
31	const timeframeToNumTimeBlocks = {	1✔
32	daily: forumAllPostsNumDaysSetting.get(),
33	weekly: forumAllPostsNumWeeksSetting.get(),
34	monthly: forumAllPostsNumMonthsSetting.get(),
35	yearly: forumAllPostsNumYearsSetting.get(),
36	}
37
38	const AllPostsList = ({	1✔
39	currentTimeframe,
40	currentSorting,
41	currentFilter,
42	currentShowLowKarma,
43	currentIncludeEvents,
44	currentHideCommunity,
45	showSettings,
46	}: {
47	currentTimeframe: string,
48	currentFilter: string,
49	currentSorting: PostSortingMode,
50	currentShowLowKarma: boolean,
51	currentIncludeEvents: boolean,
52	currentHideCommunity: boolean,
53	showSettings: boolean,
54	}) => {
55	const {timezone} = useTimezone();	×
56	const {query} = useLocation();	×
57
58	const baseTerms: PostsViewTerms = {	×
59	karmaThreshold: query.karmaThreshold \|\| (currentShowLowKarma	×
60	? MAX_LOW_KARMA_THRESHOLD	×
61	: DEFAULT_LOW_KARMA_THRESHOLD),
62	excludeEvents: !currentIncludeEvents && currentFilter !== "events",	×
63	hideCommunity: currentHideCommunity,
64	filter: currentFilter,
65	sortedBy: currentSorting,
66	after: query.after,
67	before: query.before,
68	};
69
NEW 70	const {PostsTimeframeList, PostsTimeframeListExponential, PostsList2} = Components;	×
71
72	if (currentTimeframe === "allTime") {	×
73	return (	×
74	<AnalyticsContext
75	listContext={"allPostsPage"}
76	terms={{view: "allTime" as PostsViewName, ...baseTerms}}
77	>
78	<PostsList2
79	terms={{
80	...baseTerms,
81	limit: 50
82	}}
83	dimWhenLoading={showSettings && !isFriendlyUI}	×
84	showLoading={isFriendlyUI}
85	/>
86	</AnalyticsContext>
87	);
88	}
89
90	const numTimeBlocks = timeframeToNumTimeBlocks[currentTimeframe as TimeframeType];	×
91	const timeBlock = timeframeToTimeBlock[currentTimeframe as TimeframeType];	×
92
93	const postListParameters: PostsViewTerms = {	×
94	view: "timeframe",
95	...baseTerms,
96	};
97
98	if (parseInt(query.limit)) {	×
99	postListParameters.limit = parseInt(query.limit);	×
100	}
101
NEW 102	if (currentTimeframe === 'exponential') {	×
NEW 103	return (	×
104	<AnalyticsContext
105	listContext={"allPostsPage"}
106	terms={postListParameters}
107	>
108	<PostsTimeframeListExponential
109	postListParameters={postListParameters}
110	/>
111	</AnalyticsContext>
112	);
113	}
114
UNCOV 115	const after = query.after \|\| getAfterDefault({	×
116	numTimeBlocks,
117	timeBlock,
118	timezone,
119	before: query.before,
120	});
121	const before = query.before \|\| getBeforeDefault({	×
122	timeBlock,
123	timezone,
124	after: query.after,
125	});
126
127	const hideTags = currentFilter !== "all";	×
128
129	let shortform: PostsTimeBlockShortformOption = "all";	×
130	if (currentFilter === "frontpage") {	×
131	shortform = "frontpage";	×
132	} else if (hideTags) {	×
133	shortform = "none";	×
134	}
135
136	return (	×
137	<div>
138	<AnalyticsContext
139	listContext={"allPostsPage"}
140	terms={postListParameters}
141	capturePostItemOnMount
142	>
143	{/* Allow unhiding posts from all posts menu to allow recovery of hiding
144	* the wrong post */}
145	<AllowHidingFrontPagePostsContext.Provider value={true}>
146	<PostsTimeframeList
147	// TODO: this doesn't seem to be guaranteed, actually? Since it can
148	// come from an unsanitized query param...
149	timeframe={currentTimeframe as TimeframeType}
150	postListParameters={postListParameters}
151	numTimeBlocks={numTimeBlocks}
152	dimWhenLoading={showSettings && !isFriendlyUI}	×
153	after={after}
154	before={before}
155	reverse={query.reverse === "true"}
156	shortform={query.includeShortform === "false" ? "none" : shortform}	×
157	includeTags={!hideTags}
158	/>
159	</AllowHidingFrontPagePostsContext.Provider>
160	</AnalyticsContext>
161	</div>
162	);
163	}
164
165	const AllPostsListComponent = registerComponent("AllPostsList", AllPostsList);	1✔
166
167	declare global {
168	interface ComponentTypes {
169	AllPostsList: typeof AllPostsListComponent
170	}
171	}

ForumMagnum / ForumMagnum / 8729440466

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous