8700740966

Committed 16 Apr 2024 06:03AM UTC coverage: 31.954% (-0.07%) from 32.023%

Build # 8700740966

Build Type

Pull #9118

github

Committed by

jimrandomh

Commit Message

Switch classNames from object-style to boolean-expr-style in high-usage-frequency components

Slack thread: https://lworg.slack.com/archives/C75BWSNBH/p1713246308322869

This looks like an arbitrary choice of convention, but it turns out to
have a performance impact. Switch usages of classNames from object-style
to boolean-expression-style, saving a bunch of object allocations and
hashmap operations.

Pull Request Pull Request #9118: Switch classNames from object-style to boolean-expr-style in high-usage-frequency components

Run Details

4645 of 37929 branches covered (12.25%)

Branch coverage included in aggregate %.

0 of 3 new or added lines in 3 files covered. (0.0%)

101 existing lines in 4 files now uncovered.

27059 of 61289 relevant lines covered (44.15%)

182.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.14

/packages/lesswrong/lib/domParser.ts

import type { DOMWindow } from "jsdom";
import { isServer } from "./executionEnvironment";

// Note: isServer is defined as `const isServer = bundleIsServer`, but checking against isServer here causes irreparable build errors
const { JSDOM = null } = bundleIsServer ? require('jsdom') : {};

/**
 * A window type that works with jsdom or the browser window
 */
export type WindowType = DOMWindow | Window & typeof globalThis

/**
 * Version of DOMParser().parseFromString that can be used server-side (including during SSR)
 */
export function parseDocumentFromString(html: string): {
  document: Document;
  window: WindowType;
} {
  if (isServer) {
    const { window } = new JSDOM(html);
    return { window, document: window.document };
  } else {
    const parser = new DOMParser();
    const document = parser.parseFromString(html, "text/html");
    return { document, window };
  }
}

1	import type { DOMWindow } from "jsdom";	73✔
2	import { isServer } from "./executionEnvironment";	20✔
3
4	// Note: isServer is defined as `const isServer = bundleIsServer`, but checking against isServer here causes irreparable build errors
5	const { JSDOM = null } = bundleIsServer ? require('jsdom') : {};	20!
6
7	/**
8	* A window type that works with jsdom or the browser window
9	*/
10	export type WindowType = DOMWindow \| Window & typeof globalThis
11
12	/**
13	* Version of DOMParser().parseFromString that can be used server-side (including during SSR)
14	*/
15	export function parseDocumentFromString(html: string): {
16	document: Document;
17	window: WindowType;
18	} {
19	if (isServer) {	13!
20	const { window } = new JSDOM(html);	13✔
21	return { window, document: window.document };	13✔
22	} else {
UNCOV 23	const parser = new DOMParser();	×
UNCOV 24	const document = parser.parseFromString(html, "text/html");	×
25	return { document, window };	×
26	}
27	}

ForumMagnum / ForumMagnum / 8700740966

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous