8662304658

Committed 12 Apr 2024 12:49PM UTC coverage: 93.03% (+0.07%) from 92.96%

Build # 8662304658

Build Type

push

github

Committed by

web-flow

Commit Message

Split auth domain (#1388)

Splits the auth domain into SiWe and JWT relative repositories:

- Remove `AuthDomainModule`
- Rename `AuthApi` to `SiweApi`
- Split `AuthRepository` into `SiweRepository` and `JwtRepository`, moving associated entities, etc. into each domain.

Run Details

1898 of 2294 branches covered (82.74%)

Branch coverage included in aggregate %.

75 of 77 new or added lines in 11 files covered. (97.4%)

1 existing line in 1 file now uncovered.

6764 of 7017 relevant lines covered (96.39%)

312.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.83

/src/domain/siwe/siwe.repository.ts

import { ISiweApi } from '@/domain/interfaces/siwe-api.interface';
import { ISiweRepository } from '@/domain/siwe/siwe.repository.interface';
import { VerifyAuthMessageDto } from '@/routes/auth/entities/verify-auth-message.dto.entity';
import { Inject, Injectable } from '@nestjs/common';

@Injectable()
export class SiweRepository implements ISiweRepository {
  constructor(
    @Inject(ISiweApi)
    private readonly siweApi: ISiweApi,
  ) {}

  /**
   * Generates a unique nonce and stores it in cache for later verification.
   *
   * @returns nonce - unique string to be signed
   */
  async generateNonce(): Promise<{ nonce: string }> {
    const nonce = this.siweApi.generateNonce();

    // Store nonce for reference to verify/prevent replay attacks
    await this.siweApi.storeNonce(nonce);

    return {
      nonce,
    };
  }

  /**
   * Verifies the validity of a signed message:
   *
   * 1. Ensure the message itself has not expired.
   * 2. Ensure the nonce was generated by us/is not a replay attack.
   * 3. Verify the signature of the message.
   *
   * @param args - DTO containing the message and signature to verify.
   *
   * @returns boolean - whether the signed message is valid.
   */
  async isValidMessage(args: VerifyAuthMessageDto): Promise<boolean> {
    const isExpired =
      !!args.message.expirationTime &&
      new Date(args.message.expirationTime) < new Date();

    try {
      // Verification is not necessary, message has expired
      if (isExpired) {
        return false;
      }

      const [isValidSignature, storedNonce] = await Promise.all([
        this.siweApi.verifyMessage(args),
        this.siweApi.getNonce(args.message.nonce),
      ]);
      const isValidNonce = storedNonce === args.message.nonce;

      return isValidSignature && isValidNonce;
    } catch {
      return false;
    } finally {
      await this.siweApi.clearNonce(args.message.nonce);
    }
  }
}

1	import { ISiweApi } from '@/domain/interfaces/siwe-api.interface';	94✔
2	import { ISiweRepository } from '@/domain/siwe/siwe.repository.interface';
3	import { VerifyAuthMessageDto } from '@/routes/auth/entities/verify-auth-message.dto.entity';
4	import { Inject, Injectable } from '@nestjs/common';	94✔
5
6	@Injectable()
7	export class SiweRepository implements ISiweRepository {	94✔
8	constructor(
9	@Inject(ISiweApi)
10	private readonly siweApi: ISiweApi,	1,192✔
11	) {}
12
13	/**
14	* Generates a unique nonce and stores it in cache for later verification.
15	*
16	* @returns nonce - unique string to be signed
17	*/
18	async generateNonce(): Promise<{ nonce: string }> {
19	const nonce = this.siweApi.generateNonce();	10✔
20
21	// Store nonce for reference to verify/prevent replay attacks
22	await this.siweApi.storeNonce(nonce);	10✔
23
24	return {	10✔
25	nonce,
26	};
27	}
28
29	/**
30	* Verifies the validity of a signed message:
31	*
32	* 1. Ensure the message itself has not expired.
33	* 2. Ensure the nonce was generated by us/is not a replay attack.
34	* 3. Verify the signature of the message.
35	*
36	* @param args - DTO containing the message and signature to verify.
37	*
38	* @returns boolean - whether the signed message is valid.
39	*/
40	async isValidMessage(args: VerifyAuthMessageDto): Promise<boolean> {
41	const isExpired =
42	!!args.message.expirationTime &&	10✔
43	new Date(args.message.expirationTime) < new Date();
44
45	try {	10✔
46	// Verification is not necessary, message has expired
47	if (isExpired) {	10✔
48	return false;	2✔
49	}
50
51	const [isValidSignature, storedNonce] = await Promise.all([	8✔
52	this.siweApi.verifyMessage(args),
53	this.siweApi.getNonce(args.message.nonce),
54	]);
55	const isValidNonce = storedNonce === args.message.nonce;	8✔
56
57	return isValidSignature && isValidNonce;	8✔
58	} catch {
NEW 59	return false;	×
60	} finally {
61	await this.siweApi.clearNonce(args.message.nonce);	10✔
62	}
63	}
64	}

safe-global / safe-client-gateway / 8662304658

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous