8644939672

Committed 11 Apr 2024 10:01AM UTC coverage: 92.944% (-0.09%) from 93.033%

Build # 8644939672

Build Type

push

github

Committed by

web-flow

Commit Message

Extract Alerts configuration (#1372)

- The Alerts related configuration and environment keys were extracted to the `AlertsApiModule` and `AlertsControllerModule`.
- By separating the properties of the Alerts feature to its own configuration object which is loaded dynamically, we can make some properties set as required in the application **only if the respective feature is loaded**.
- This effectively reduces the number of configuration properties that is needed to set for the application to launch, when features are under development or a set of features is not needed by the hosting party.
- In order to avoid key collision, the feature level configuration now uses namespaces (with `registerAs`).
  * `alerts-api` for keys used in `/datasources/alerts-api`
  * `alerts-route` for keys used in `/routes/alerts`

Run Details

1925 of 2328 branches covered (82.69%)

Branch coverage included in aggregate %.

36 of 40 new or added lines in 10 files covered. (90.0%)

3 existing lines in 1 file now uncovered.

6755 of 7011 relevant lines covered (96.35%)

315.19 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.43

/src/routes/alerts/configuration/alerts.configuration.ts

1	import { registerAs } from '@nestjs/config';	92✔
2	import { z } from 'zod';	92✔
3	import configurationValidator from '@/config/configuration.validator';	92✔
4
5	const schema = z.object({	92✔
6	signingKey: z.string(),
7	});
8
9	export default registerAs('alerts-route', () => {	92✔
NEW 10	const configuration = { signingKey: process.env.ALERTS_PROVIDER_SIGNING_KEY };	×
NEW 11	return configurationValidator(configuration, schema);	×
12	});

safe-global / safe-client-gateway / 8644939672

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous