8580159881

Committed 06 Apr 2024 09:16AM UTC coverage: 81.645% (+0.05%) from 81.591%

Build # 8580159881

Build Type

push

github

Committed by

web-flow

Commit Message

Remove Synchronous Module Loading (#1637)

* Remove non-async module loading code

* Revert "Remove non-async module loading code"

This reverts commit a56680bc5.

* Remove non-async module loading code

* Fix transpiler not skipping undefined variables in fullJS

* Update documentation and tests for loader

* Create a new path type to better indicate where absolute paths are required

* Remove xmlhttprequest-ts

* Fix documentation

* Separate bundler into a different type

* Remove paths handlers - to reintroduce later

* Run format

* Add tests for transformImportDeclarations

* Add tests for name-extractor when used with modules

* Remove extra moduleLoader file

* Run format

* Move loaders into a separate folder

* Run format

* Update snapshot

* Remove requireProvider from runners since it's not needed anymore

* Run format

* Update documentation and use more guard clauses

* Run format

* Use documentation style comment

For tooltips upon hovering.

---------

Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>

Run Details

3303 of 4409 branches covered (74.91%)

Branch coverage included in aggregate %.

282 of 309 new or added lines in 22 files covered. (91.26%)

14 existing lines in 6 files now uncovered.

10615 of 12638 relevant lines covered (83.99%)

112659.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.0

/src/modules/loader/index.ts

import type { Context } from '../../types'
import type { ModuleFunctions } from '../moduleTypes'
import { loadModuleBundleAsync, loadModuleTabsAsync } from './loaders'

/**
 * Initialize module contexts and add UI tabs needed for modules to program context
 */
async function initModuleContextAsync(moduleName: string, context: Context, loadTabs: boolean) {
  // Load the module's tabs
  if (!(moduleName in context.moduleContexts)) {
    context.moduleContexts[moduleName] = {
      state: null,
      tabs: loadTabs ? await loadModuleTabsAsync(moduleName) : null
    }
  } else if (context.moduleContexts[moduleName].tabs === null && loadTabs) {
    context.moduleContexts[moduleName].tabs = await loadModuleTabsAsync(moduleName)
  }
}

/**
 * With the given set of Source Modules to Import, load all of the bundles and
 * tabs (if `loadTabs` is true) and populate the `context.nativeStorage.loadedModules`
 * property.
 */
export default async function loadSourceModules(
  sourceModulesToImport: Set<string>,
  context: Context,
  loadTabs: boolean
) {
  const loadedModules = await Promise.all(
    [...sourceModulesToImport].map(async moduleName => {
      await initModuleContextAsync(moduleName, context, loadTabs)
      const bundle = await loadModuleBundleAsync(moduleName, context)
      return [moduleName, bundle] as [string, ModuleFunctions]
    })
  )

  const loadedObj = Object.fromEntries(loadedModules)
  context.nativeStorage.loadedModules = loadedObj

  return loadedObj
}

export {
  setModulesStaticURL,
  MODULES_STATIC_URL,
  memoizedGetModuleDocsAsync,
  memoizedGetModuleManifestAsync
} from './loaders'

1	import type { Context } from '../../types'
2	import type { ModuleFunctions } from '../moduleTypes'
3	import { loadModuleBundleAsync, loadModuleTabsAsync } from './loaders'	55✔
4
5	/**
6	* Initialize module contexts and add UI tabs needed for modules to program context
7	*/
8	async function initModuleContextAsync(moduleName: string, context: Context, loadTabs: boolean) {
9	// Load the module's tabs
10	if (!(moduleName in context.moduleContexts)) {	103!
11	context.moduleContexts[moduleName] = {	103✔
12	state: null,
13	tabs: loadTabs ? await loadModuleTabsAsync(moduleName) : null	103✔
14	}
NEW 15	} else if (context.moduleContexts[moduleName].tabs === null && loadTabs) {	×
NEW 16	context.moduleContexts[moduleName].tabs = await loadModuleTabsAsync(moduleName)	×
17	}
18	}
19
20	/**
21	* With the given set of Source Modules to Import, load all of the bundles and
22	* tabs (if `loadTabs` is true) and populate the `context.nativeStorage.loadedModules`
23	* property.
24	*/
25	export default async function loadSourceModules(	55✔
26	sourceModulesToImport: Set<string>,
27	context: Context,
28	loadTabs: boolean
29	) {
30	const loadedModules = await Promise.all(	1,589✔
31	[...sourceModulesToImport].map(async moduleName => {
32	await initModuleContextAsync(moduleName, context, loadTabs)	103✔
33	const bundle = await loadModuleBundleAsync(moduleName, context)	103✔
34	return [moduleName, bundle] as [string, ModuleFunctions]	103✔
35	})
36	)
37
38	const loadedObj = Object.fromEntries(loadedModules)	1,589✔
39	context.nativeStorage.loadedModules = loadedObj	1,589✔
40
41	return loadedObj	1,589✔
42	}
43
44	export {	55✔
45	setModulesStaticURL,	55✔
46	MODULES_STATIC_URL,	58✔
47	memoizedGetModuleDocsAsync,	68✔
48	memoizedGetModuleManifestAsync	104✔
49	} from './loaders'

source-academy / js-slang / 8580159881

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous