#755

Committed 04 Apr 2024 05:07PM UTC coverage: 76.689% (-0.08%) from 76.768%

Build # #755

Build Type

push

github

Committed by

simonprev

Commit Message

Fix aws us-east-1 subdomain and fix slow projects list

Run Details

0 of 4 new or added lines in 1 file covered. (0.0%)

2214 of 2887 relevant lines covered (76.69%)

14.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lib/accent/integrations/execute/aws_s3.ex

defmodule Accent.IntegrationManager.Execute.AWSS3 do
  @moduledoc false

  alias Accent.Hook

  def upload_translations(integration, user, params) do
    {uploads, version_tag} = Accent.IntegrationManager.Execute.UploadDocuments.all(integration, params)

    # To support bucket with '.' in the name, we need to use the region subdomain.
    # The us-east-1 subdomain is not s3-us-east-1. It’s s3 only.
    base_url =
      case integration.data.aws_s3_region do
        "us-east-1" -> "https://s3.amazonaws.com/#{integration.data.aws_s3_bucket}"
        region -> "https://s3-#{region}.amazonaws.com/#{integration.data.aws_s3_bucket}"
      end

    url =
      Path.join([
        base_url,
        integration.data.aws_s3_path_prefix
      ])

    uri = URI.parse(url)

    document_urls =
      for upload <- uploads do
        {url, document_name} = Accent.IntegrationManager.Execute.UploadDocuments.url(upload, uri, version_tag)

        headers =
          :aws_signature.sign_v4(
            integration.data.aws_s3_access_key_id,
            integration.data.aws_s3_secret_access_key,
            integration.data.aws_s3_region,
            "s3",
            :calendar.universal_time(),
            "put",
            url,
            [{"host", uri.authority}],
            upload.render,
            uri_encode_path: false
          )

        {:ok, %{status_code: 200}} = HTTPoison.put(url, {:file, upload.file}, headers)

        %{name: document_name, url: url}
      end

    Hook.outbound(%Hook.Context{
      event: "integration_execute_azure_storage_container",
      project_id: integration.project_id,
      user_id: user.id,
      payload: %{
        version_tag: version_tag,
        document_urls: document_urls
      }
    })

    :ok
  end
end

1	defmodule Accent.IntegrationManager.Execute.AWSS3 do
2	@moduledoc false
3
4	alias Accent.Hook
5
6	def upload_translations(integration, user, params) do
7	{uploads, version_tag} = Accent.IntegrationManager.Execute.UploadDocuments.all(integration, params)	×
8
9	# To support bucket with '.' in the name, we need to use the region subdomain.
10	# The us-east-1 subdomain is not s3-us-east-1. It’s s3 only.
NEW 11	base_url =	×
NEW 12	case integration.data.aws_s3_region do	×
NEW 13	"us-east-1" -> "https://s3.amazonaws.com/#{integration.data.aws_s3_bucket}"	×
NEW 14	region -> "https://s3-#{region}.amazonaws.com/#{integration.data.aws_s3_bucket}"	×
15	end
16
17	url =	×
18	Path.join([
19	base_url,
20	integration.data.aws_s3_path_prefix	×
21	])
22
23	uri = URI.parse(url)	×
24
25	document_urls =	×
26	for upload <- uploads do
27	{url, document_name} = Accent.IntegrationManager.Execute.UploadDocuments.url(upload, uri, version_tag)	×
28
29	headers =	×
30	:aws_signature.sign_v4(
31	integration.data.aws_s3_access_key_id,	×
32	integration.data.aws_s3_secret_access_key,	×
33	integration.data.aws_s3_region,	×
34	"s3",
35	:calendar.universal_time(),
36	"put",
37	url,
38	[{"host", uri.authority}],	×
39	upload.render,	×
40	uri_encode_path: false
41	)
42
43	{:ok, %{status_code: 200}} = HTTPoison.put(url, {:file, upload.file}, headers)	×
44
45	%{name: document_name, url: url}	×
46	end
47
48	Hook.outbound(%Hook.Context{	×
49	event: "integration_execute_azure_storage_container",
50	project_id: integration.project_id,	×
51	user_id: user.id,	×
52	payload: %{
53	version_tag: version_tag,
54	document_urls: document_urls
55	}
56	})
57
58	:ok
59	end
60	end

mirego / accent / #755

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous