rust-bitcoin / rust-bitcoin / 8515631286

push

github

Merge rust-bitcoin/rust-bitcoin#2581: Implement ArbitraryOrd for relative::LockTime

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d91cdd20bfc0eebce5a067d37d05381bac2845aa">d91cdd20b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6a2fd96ff6087f1f9fc979d8639dc1ff6d2ea693"> docs: Document ordered feature (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3520f550f0d00c96bba7ab0f9912bb5bfd609edd">3520f550f</a> Implement ArbitraryOrd for relative::LockTime (Tobin C. Harding)

Pull request description:

  TL;DR As we do for `absolute::LockTime` and for the same reasons; implement `ArbitraryOrd` for `relative::LockTime`.

  locktimes do not have a semantic ordering if they differ (blocks, time) so we do not derive `Ord` however it is useful for downstream to be able to order structs that contain lock times. This is exactly what the `ArbitraryOrd` trait is for.

  Fix: #2566

ACKs for top commit:
  sanket1729:
    ACK d91cdd20bfc0eebce5a067d37d05381bac2845aa
  apoelstra:
    ACK d91cdd20bfc0eebce5a067d37d05381bac2845aa

Tree-SHA512: 52ace9222c9fd579c469068d65e01c99a9e

0 of 9 new or added lines in 1 file covered. (0.0%)

19093 of 22966 relevant lines covered (83.14%)

16930.63 hits per line