source-academy / frontend / 8312630473

push

github

Refactor frontend part 6 (#2800)

* Add generic type argument to column definitions

Improves type safety.

* Migrate bp4 classes to bp5

This was missed during the initial migration.

* Remove unused `AcademyReducer` and dependents

Dependents include the associated types and tests.

* Update imports

Improves correctness and consistency.

* Fix lint

* Undo test import change

It was causing the tests to fail.

* Remove unnecessay `loadContentDispatch` sometimes

This is now no longer needed since we made the prop optional.

* Update test snapshots

* Make component typings more consistent

* Standardize to lambda function
* Standardize to `React.FC` typing
* Remove unnecessary props parameter typing
* Destructure props directly in function parameter

* Bump dependencies

* Fix class name typo

* Change relative import to project-based import

* Bump dependencies

* Update test snapshots

* Standardize typings

* Use `React.FC` type for components
* Type props as `Props` unless exported
* Place props type immediately above component
* Use lambda functions for components
* Destructure props in function parameter
* Use types for props, not interfaces
* Combine unnecessary `OwnProps` to props type
* Remove unused exports of props types

Remaining components will be migrated in the future.

* Remove unnecessary generic type arguments

* Standardize ControlBar components typings

* Type props as `Props` unless exported
* Place props type immediately above component

* Standardize more component typings

Also removed some unnecessary `useState` type arguments.

* Fix compile error

* Standardize remaining component typings

Also removed some unnecessary `useState` type arguments.

* Ban `React.FunctionComponent` type

Prefer the more succint `React.FC` instead.

* Ban `useSelector` import

We want to always use `useTypedSelector` for type-safety.

2159 of 6557 branches covered (32.93%)

Branch coverage included in aggregate %.

65 of 173 new or added lines in 118 files covered. (37.57%)

5669 of 13798 relevant lines covered (41.09%)

21.77 hits per line