8300403254

Committed 15 Mar 2024 05:57PM UTC coverage: 82.772% (-0.05%) from 82.822%

Build # 8300403254

Build Type

Pull #1385

github

Committed by

web-flow

Commit Message

Merge 8d3c73fe3 into 9fd6cdc1c

Pull Request Pull Request #1385: WIP: Feature/inline threashold

Run Details

1574 of 2165 branches covered (72.7%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

7 existing lines in 3 files now uncovered.

6469 of 7552 relevant lines covered (85.66%)

0.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.0

/numba_dpex/core/kernel_interface/spirv_kernel.py

# SPDX-FileCopyrightText: 2022 - 2024 Intel Corporation
#
# SPDX-License-Identifier: Apache-2.0

import logging
from types import FunctionType

from numba.core import ir

from numba_dpex.core import config
from numba_dpex.core.compiler import compile_with_dpex
from numba_dpex.core.exceptions import UncompiledKernelError, UnreachableError
from numba_dpex.kernel_api_impl.spirv import spirv_generator
from numba_dpex.kernel_api_impl.spirv.target import SPIRVTargetContext

from .kernel_base import KernelInterface


class SpirvKernel(KernelInterface):
    def __init__(self, func, func_name) -> None:
        """Represents a SPIR-V module compiled for a Python function.

        Args:
            func: The function to be compiled. Can be a Python function or a
            Numba IR object representing a function.
            func_name (str): Name of the function being compiled

        Raises:
            UnreachableError: An internal error indicating an unexpected code
            path was executed.
        """
        self._llvm_module = None
        self._device_driver_ir_module = None
        self._module_name = None
        self._pyfunc_name = func_name
        self._func = func
        if isinstance(func, FunctionType):
            self._func_ty = FunctionType
        elif isinstance(func, ir.FunctionIR):
            self._func_ty = ir.FunctionIR
        else:
            raise UnreachableError()
        self._target_context = None

    @property
    def llvm_module(self):
        """The LLVM IR Module corresponding to the Kernel instance."""
        if self._llvm_module:
            return self._llvm_module
        else:
            raise UncompiledKernelError(self._pyfunc_name)

    @property
    def device_driver_ir_module(self):
        """The module in a device IR (such as SPIR-V or PTX) format."""
        if self._device_driver_ir_module:
            return self._device_driver_ir_module
        else:
            raise UncompiledKernelError(self._pyfunc_name)

    @property
    def pyfunc_name(self):
        """The Python function name corresponding to the kernel."""
        return self._pyfunc_name

    @property
    def module_name(self):
        """The name of the compiled LLVM module for the kernel."""
        if self._module_name:
            return self._module_name
        else:
            raise UncompiledKernelError(self._pyfunc_name)

    @property
    def target_context(self):
        """Returns the target context that was used to compile the kernel.

        Raises:
            UncompiledKernelError: If the kernel was not yet compiled.

        Returns:
            target context used to compile the kernel
        """
        if self._target_context:
            return self._target_context
        else:
            raise UncompiledKernelError(self._pyfunc_name)

    @property
    def typing_context(self):
        """Returns the typing context that was used to compile the kernel.

        Raises:
            UncompiledKernelError: If the kernel was not yet compiled.

        Returns:
            typing context used to compile the kernel
        """
        if self._typing_context:
            return self._typing_context
        else:
            raise UncompiledKernelError(self._pyfunc_name)

    def compile(
        self,
        target_ctx,
        typing_ctx,
        args,
        debug,
        compile_flags,
    ):
        """Compiles a kernel using numba_dpex.core.compiler.Compiler.

        Args:
            args (_type_): _description_
            debug (_type_): _description_
            compile_flags (_type_): _description_
        """

        logging.debug("compiling SpirvKernel with arg types", args)

        self._target_context = target_ctx
        self._typing_context = typing_ctx

        cres = compile_with_dpex(
            self._func,
            self._pyfunc_name,
            args=args,
            return_type=None,
            debug=debug,
            is_kernel=True,
            typing_context=typing_ctx,
            target_context=target_ctx,
            extra_compile_flags=compile_flags,
        )

        func = cres.library.get_function(cres.fndesc.llvm_func_name)
        kernel_targetctx: SPIRVTargetContext = cres.target_context
        kernel = kernel_targetctx.prepare_spir_kernel(func, cres.signature.args)

        # XXX: Setting the inline_threshold in the following way is a temporary
        # workaround till the JitKernel dispatcher is replaced by
        # experimental.dispatcher.KernelDispatcher.
        if config.INLINE_THRESHOLD is not None:
            cres.library.inline_threshold = config.INLINE_THRESHOLD
        else:
            cres.library.inline_threshold = 0

        cres.library._optimize_final_module()
        self._llvm_module = kernel.module.__str__()
        self._module_name = kernel.name

        # Dump LLVM IR if DEBUG flag is set.
        if config.DUMP_KERNEL_LLVM:
            import hashlib

            # Embed hash of module name in the output file name
            # so that different kernels are written to separate files
            with open(
                "llvm_kernel_"
                + hashlib.sha256(self._module_name.encode()).hexdigest()
                + ".ll",
                "w",
            ) as f:
                f.write(self._llvm_module)

        # FIXME: There is no need to serialize the bitcode. It can be passed to
        # llvm-spirv directly via stdin.

        # FIXME: There is no need for spirv-dis. We cause use --to-text
        # (or --spirv-text) to convert SPIRV to text
        self._device_driver_ir_module = spirv_generator.llvm_to_spirv(
            self._target_context, self._llvm_module, kernel.module.as_bitcode()
        )

1	# SPDX-FileCopyrightText: 2022 - 2024 Intel Corporation
2	#
3	# SPDX-License-Identifier: Apache-2.0
4
5	import logging	1✔
6	from types import FunctionType	1✔
7
8	from numba.core import ir	1✔
9
10	from numba_dpex.core import config	1✔
11	from numba_dpex.core.compiler import compile_with_dpex	1✔
12	from numba_dpex.core.exceptions import UncompiledKernelError, UnreachableError	1✔
13	from numba_dpex.kernel_api_impl.spirv import spirv_generator	1✔
14	from numba_dpex.kernel_api_impl.spirv.target import SPIRVTargetContext	1✔
15
16	from .kernel_base import KernelInterface	1✔
17
18
19	class SpirvKernel(KernelInterface):	1✔
20	def __init__(self, func, func_name) -> None:	1✔
21	"""Represents a SPIR-V module compiled for a Python function.
22
23	Args:
24	func: The function to be compiled. Can be a Python function or a
25	Numba IR object representing a function.
26	func_name (str): Name of the function being compiled
27
28	Raises:
29	UnreachableError: An internal error indicating an unexpected code
30	path was executed.
31	"""
32	self._llvm_module = None	1✔
33	self._device_driver_ir_module = None	1✔
34	self._module_name = None	1✔
35	self._pyfunc_name = func_name	1✔
36	self._func = func	1✔
37	if isinstance(func, FunctionType):	1✔
38	self._func_ty = FunctionType	1✔
39	elif isinstance(func, ir.FunctionIR):	1!
40	self._func_ty = ir.FunctionIR	1✔
41	else:
42	raise UnreachableError()	×
43	self._target_context = None	1✔
44
45	@property	1✔
46	def llvm_module(self):	1✔
47	"""The LLVM IR Module corresponding to the Kernel instance."""
48	if self._llvm_module:	1!
49	return self._llvm_module	1✔
50	else:
51	raise UncompiledKernelError(self._pyfunc_name)	×
52
53	@property	1✔
54	def device_driver_ir_module(self):	1✔
55	"""The module in a device IR (such as SPIR-V or PTX) format."""
56	if self._device_driver_ir_module:	1!
57	return self._device_driver_ir_module	1✔
58	else:
59	raise UncompiledKernelError(self._pyfunc_name)	×
60
61	@property	1✔
62	def pyfunc_name(self):	1✔
63	"""The Python function name corresponding to the kernel."""
64	return self._pyfunc_name	×
65
66	@property	1✔
67	def module_name(self):	1✔
68	"""The name of the compiled LLVM module for the kernel."""
69	if self._module_name:	1!
70	return self._module_name	1✔
71	else:
72	raise UncompiledKernelError(self._pyfunc_name)	×
73
74	@property	1✔
75	def target_context(self):	1✔
76	"""Returns the target context that was used to compile the kernel.
77
78	Raises:
79	UncompiledKernelError: If the kernel was not yet compiled.
80
81	Returns:
82	target context used to compile the kernel
83	"""
84	if self._target_context:	1!
85	return self._target_context	1✔
86	else:
87	raise UncompiledKernelError(self._pyfunc_name)	×
88
89	@property	1✔
90	def typing_context(self):	1✔
91	"""Returns the typing context that was used to compile the kernel.
92
93	Raises:
94	UncompiledKernelError: If the kernel was not yet compiled.
95
96	Returns:
97	typing context used to compile the kernel
98	"""
99	if self._typing_context:	×
100	return self._typing_context	×
101	else:
102	raise UncompiledKernelError(self._pyfunc_name)	×
103
104	def compile(	1✔
105	self,
106	target_ctx,
107	typing_ctx,
108	args,
109	debug,
110	compile_flags,
111	):
112	"""Compiles a kernel using numba_dpex.core.compiler.Compiler.
113
114	Args:
115	args (_type_): _description_
116	debug (_type_): _description_
117	compile_flags (_type_): _description_
118	"""
119
120	logging.debug("compiling SpirvKernel with arg types", args)	1✔
121
122	self._target_context = target_ctx	1✔
123	self._typing_context = typing_ctx	1✔
124
125	cres = compile_with_dpex(	1✔
126	self._func,
127	self._pyfunc_name,
128	args=args,
129	return_type=None,
130	debug=debug,
131	is_kernel=True,
132	typing_context=typing_ctx,
133	target_context=target_ctx,
134	extra_compile_flags=compile_flags,
135	)
136
137	func = cres.library.get_function(cres.fndesc.llvm_func_name)	1✔
138	kernel_targetctx: SPIRVTargetContext = cres.target_context	1✔
139	kernel = kernel_targetctx.prepare_spir_kernel(func, cres.signature.args)	1✔
140
141	# XXX: Setting the inline_threshold in the following way is a temporary
142	# workaround till the JitKernel dispatcher is replaced by
143	# experimental.dispatcher.KernelDispatcher.
144	if config.INLINE_THRESHOLD is not None:	1!
145	cres.library.inline_threshold = config.INLINE_THRESHOLD	1✔
146	else:
UNCOV 147	cres.library.inline_threshold = 0	×
148
149	cres.library._optimize_final_module()	1✔
150	self._llvm_module = kernel.module.__str__()	1✔
151	self._module_name = kernel.name	1✔
152
153	# Dump LLVM IR if DEBUG flag is set.
154	if config.DUMP_KERNEL_LLVM:	1✔
155	import hashlib	1✔
156
157	# Embed hash of module name in the output file name
158	# so that different kernels are written to separate files
159	with open(	1✔
160	"llvm_kernel_"
161	+ hashlib.sha256(self._module_name.encode()).hexdigest()
162	+ ".ll",
163	"w",
164	) as f:
165	f.write(self._llvm_module)	1✔
166
167	# FIXME: There is no need to serialize the bitcode. It can be passed to
168	# llvm-spirv directly via stdin.
169
170	# FIXME: There is no need for spirv-dis. We cause use --to-text
171	# (or --spirv-text) to convert SPIRV to text
172	self._device_driver_ir_module = spirv_generator.llvm_to_spirv(	1✔
173	self._target_context, self._llvm_module, kernel.module.as_bitcode()
174	)

IntelPython / numba-dpex / 8300403254

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous