8284276295

Committed 14 Mar 2024 04:31PM UTC coverage: 93.631% (-0.02%) from 93.652%

Build # 8284276295

Build Type

push

github

Committed by

web-flow

Commit Message

Migrate `DataDecoded` to `zod` (#1268)

This migrates the validation of `DataDecoded` to `zod`:

- Create `DataDecodedSchema`
- Migrated `DataDecodedRepository['getDataDecoded']` to use new schema
- Add notes to remove to-be-deprecated validator

Run Details

1840 of 2197 branches covered (83.75%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 3 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

6481 of 6690 relevant lines covered (96.88%)

366.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/src/domain/data-decoder/data-decoded.validator.ts

import { Injectable } from '@nestjs/common';
import { ValidateFunction } from 'ajv';
import { DataDecoded } from '@/domain/data-decoder/entities/data-decoded.entity';
import {
  DATA_DECODED_PARAMETER_SCHEMA_ID,
  DATA_DECODED_SCHEMA_ID,
  dataDecodedParameterSchema,
  dataDecodedSchema,
} from '@/domain/data-decoder/entities/schemas/data-decoded.schema';
import { IValidator } from '@/domain/interfaces/validator.interface';
import { GenericValidator } from '@/validation/providers/generic.validator';
import { JsonSchemaService } from '@/validation/providers/json-schema.service';

// TODO: Remove after creation, module, multisig and transaction type are migrated to zod
@Injectable()
export class DataDecodedValidator implements IValidator<DataDecoded> {
  private readonly isValidDataDecoded: ValidateFunction<DataDecoded>;

  constructor(
    private readonly genericValidator: GenericValidator,
    private readonly jsonSchemaService: JsonSchemaService,
  ) {
    this.jsonSchemaService.getSchema(
      DATA_DECODED_PARAMETER_SCHEMA_ID,
      dataDecodedParameterSchema,
    );
    this.isValidDataDecoded = this.jsonSchemaService.getSchema(
      DATA_DECODED_SCHEMA_ID,
      dataDecodedSchema,
    );
  }

  validate(data: unknown): DataDecoded {
    return this.genericValidator.validate(this.isValidDataDecoded, data);
  }
}

1	import { Injectable } from '@nestjs/common';	92✔
2	import { ValidateFunction } from 'ajv';
3	import { DataDecoded } from '@/domain/data-decoder/entities/data-decoded.entity';
4	import {	92✔
5	DATA_DECODED_PARAMETER_SCHEMA_ID,
6	DATA_DECODED_SCHEMA_ID,
7	dataDecodedParameterSchema,
8	dataDecodedSchema,
9	} from '@/domain/data-decoder/entities/schemas/data-decoded.schema';
10	import { IValidator } from '@/domain/interfaces/validator.interface';
11	import { GenericValidator } from '@/validation/providers/generic.validator';	92✔
12	import { JsonSchemaService } from '@/validation/providers/json-schema.service';	92✔
13
14	// TODO: Remove after creation, module, multisig and transaction type are migrated to zod
15	@Injectable()
16	export class DataDecodedValidator implements IValidator<DataDecoded> {	92✔
17	private readonly isValidDataDecoded: ValidateFunction<DataDecoded>;
18
19	constructor(
20	private readonly genericValidator: GenericValidator,	1,182✔
21	private readonly jsonSchemaService: JsonSchemaService,	1,182✔
22	) {
23	this.jsonSchemaService.getSchema(	1,182✔
24	DATA_DECODED_PARAMETER_SCHEMA_ID,
25	dataDecodedParameterSchema,
26	);
27	this.isValidDataDecoded = this.jsonSchemaService.getSchema(	1,182✔
28	DATA_DECODED_SCHEMA_ID,
29	dataDecodedSchema,
30	);
31	}
32
33	validate(data: unknown): DataDecoded {
UNCOV 34	return this.genericValidator.validate(this.isValidDataDecoded, data);	×
35	}
36	}

safe-global / safe-client-gateway / 8284276295

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous