8282364669

Committed 14 Mar 2024 02:23PM UTC coverage: 63.049% (+0.003%) from 63.046%

Build # 8282364669

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #13901 from Habbie/backport-13867-to-auth-4.9.x

auth 4.9: on OpenBSD, try harder to send on a non-blocking socket

Run Details

12931 of 27248 branches covered (47.46%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

19 existing lines in 5 files now uncovered.

41627 of 59285 relevant lines covered (70.22%)

5140716.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

62.19

/pdns/nameserver.cc

/*
 * This file is part of PowerDNS or dnsdist.
 * Copyright -- PowerDNS.COM B.V. and its contributors
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * In addition, for the avoidance of any doubt, permission is granted to
 * link this program with OpenSSL and to (re)distribute the binaries
 * produced as the result of such linking.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include "utility.hh"
#include <cstdio>
#include <cstring>
#include <cstdlib>
#include <cerrno>
#include <iostream>
#include <string>
#include <sys/types.h>
#include "responsestats.hh"

#include "auth-main.hh"
#include "dns.hh"
#include "dnsbackend.hh"
#include "dnspacket.hh"
#include "nameserver.hh"
#include "distributor.hh"
#include "logger.hh"
#include "arguments.hh"
#include "statbag.hh"
#include "proxy-protocol.hh"

#include "namespaces.hh"

extern StatBag S;

/** \mainpage 
    PowerDNS is a very versatile nameserver that can answer questions from different backends. To implement your
    own backend, see the documentation for the DNSBackend class.

    \section copyright Copyright and License
    PowerDNS is (C) 2001-2008 PowerDNS.COM BV. It is distributed according to the terms of the General Public License version 2.

    \section overview High level overview

    The Distributor contains a configurable number of PacketHandler instances, each in its own thread, for connection pooling. 
    PacketHandler instances are recycled of they let escape an PDNSException.

    The PacketHandler implements the RFC1034 algorithm and converts question packets into DNSBackend queries.

    A DNSBackend is an entity that returns DNSResourceRecord objects in return to explicit questions for domains with a specified QType

    PowerDNS uses the UeberBackend, which hosts DNSBackends. By default it has no DNSBackends within itself, those are loaded
    by setting --load=<list of backends>. This way DNSBackend implementations can be kept completely separate, but most aren't.

    If one or more DNSBackends are loaded, the UeberBackend fields the queries to all of them until one answers.

    \section TCP TCP Operations

    The TCP operation runs within a single thread called tcpreceiver(), that also queries the PacketHandler. 

    \section Cache Caching
 
    On its own, this setup is not suitable for high performance operations. A single DNS query can turn into many DNSBackend questions,
    each taking many milliseconds to complete. This is why the qthread() first checks the PacketCache to see if an answer is known to a packet
    asking this question. If so, the entire Distributor is shunted, and the answer is sent back *directly*, within a few microseconds.

    \section misc Miscellaneous
    Configuration details are available via the ArgvMap instance arg. Statistics are created by making calls to the StatBag object called S. 
    These statistics are made available via the UeberBackend on the same socket that is used for dynamic module commands.

    \section Main Main 
    The main() of PowerDNS can be found in auth-main.cc - start reading there for further insights into the operation of the nameserver
*/

vector<ComboAddress> g_localaddresses; // not static, our unit tests need to poke this

void UDPNameserver::bindAddresses()
{
  vector<string>locals;
  stringtok(locals,::arg()["local-address"]," ,");

  int one = 1;

  if(locals.empty())
    throw PDNSException("No local address specified");

  int s;
  // for(vector<string>::const_iterator i=locals.begin();i!=locals.end();++i) {
  for (const auto &local : locals) {
    ComboAddress locala(local, ::arg().asNum("local-port"));

    s = socket(locala.sin4.sin_family, SOCK_DGRAM, 0);

    if(s < 0) {
      if(errno == EAFNOSUPPORT) {
        g_log<<Logger::Error<<"Binding "<<locala.toStringWithPort()<<": Address Family is not supported - skipping bind" << endl;
        return;
      }
      throw PDNSException("Unable to acquire a UDP socket: "+stringerror());
    }

    setCloseOnExec(s);
    if(!setNonBlocking(s))
      throw PDNSException("Unable to set UDP socket " + locala.toStringWithPort() + " to non-blocking: "+stringerror());

    if(IsAnyAddress(locala)) {
      (void)setsockopt(s, IPPROTO_IP, GEN_IP_PKTINFO, &one, sizeof(one));
      if (locala.isIPv6()) {
        (void)setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &one, sizeof(one));      // if this fails, we report an error in tcpreceiver too
#ifdef IPV6_RECVPKTINFO
        (void)setsockopt(s, IPPROTO_IPV6, IPV6_RECVPKTINFO, &one, sizeof(one));
#endif
      }
    }

    if (!setSocketTimestamps(s))
      g_log<<Logger::Warning<<"Unable to enable timestamp reporting for socket "<<locala.toStringWithPort()<<endl;

    try {
      setSocketIgnorePMTU(s, locala.sin4.sin_family);
    }
    catch(const std::exception& e) {
      g_log<<Logger::Warning<<"Failed to set IP_MTU_DISCOVER on UDP server socket: "<<e.what()<<endl;
    }

    if (d_can_reuseport) {
      if (!setReusePort(s)) {
        d_can_reuseport = false;
      }
    }

    if( ::arg().mustDo("non-local-bind") )
      Utility::setBindAny(locala.sin4.sin_family, s);

    if( !d_additional_socket )
        g_localaddresses.push_back(locala);

    if(::bind(s, (sockaddr*)&locala, locala.getSocklen()) < 0) {
      int err = errno;
      close(s);
      if (err == EADDRNOTAVAIL && !::arg().mustDo("local-address-nonexist-fail")) {
        g_log<<Logger::Error<<"Address " << locala << " does not exist on this server - skipping UDP bind" << endl;
        continue;
      } else {
        g_log<<Logger::Error<<"Unable to bind UDP socket to '"+locala.toStringWithPort()+"': "<<stringerror(err)<<endl;
        throw PDNSException("Unable to bind to UDP socket");
      }
    }
    d_sockets.push_back(s);
    struct pollfd pfd;
    pfd.fd = s;
    pfd.events = POLLIN;
    pfd.revents = 0;
    d_rfds.push_back(pfd);
    g_log<<Logger::Error<<"UDP server bound to "<<locala.toStringWithPort()<<endl;
  }
}

bool AddressIsUs(const ComboAddress& remote)
{
  for(const ComboAddress& us :  g_localaddresses) {
    if(remote == us)
      return true;
    if(IsAnyAddress(us)) {
      int s = socket(remote.sin4.sin_family, SOCK_DGRAM, 0);
      if(s < 0) 
        continue;

      if(connect(s, (struct sockaddr*)&remote, remote.getSocklen()) < 0) {
        close(s);
        continue;
      }
    
      ComboAddress actualLocal;
      actualLocal.sin4.sin_family = remote.sin4.sin_family;
      socklen_t socklen = actualLocal.getSocklen();

      if(getsockname(s, (struct sockaddr*) &actualLocal, &socklen) < 0) {
        close(s);
        continue;
      }
      close(s);
      actualLocal.sin4.sin_port = us.sin4.sin_port;
      if(actualLocal == remote)
        return true;
    }
  }
  return false;
}

UDPNameserver::UDPNameserver( bool additional_socket )
{
  d_can_reuseport = ::arg().mustDo("reuseport");
  // Are we the main socket (false) or a rebinding using SO_REUSEPORT ?
  d_additional_socket = additional_socket;

  if(::arg()["local-address"].empty())
    g_log<<Logger::Critical<<"PDNS is deaf and mute! Not listening on any interfaces"<<endl;    

  bindAddresses();
}

void UDPNameserver::send(DNSPacket& p)
{
  const string& buffer=p.getString();
  g_rs.submitResponse(p, true);

  struct msghdr msgh;
  struct iovec iov;
  cmsgbuf_aligned cbuf;

  fillMSGHdr(&msgh, &iov, &cbuf, 0, (char*)buffer.c_str(), buffer.length(), &p.d_remote);

  msgh.msg_control=nullptr;
  if(p.d_anyLocal) {
    addCMsgSrcAddr(&msgh, &cbuf, p.d_anyLocal.get_ptr(), 0);
  }
  DLOG(g_log<<Logger::Notice<<"Sending a packet to "<< p.getRemote() <<" ("<< buffer.length()<<" octets)"<<endl);
  if(buffer.length() > p.getMaxReplyLen()) {
    g_log<<Logger::Error<<"Weird, trying to send a message that needs truncation, "<< buffer.length()<<" > "<<p.getMaxReplyLen()<<". Question was for "<<p.qdomain<<"|"<<p.qtype.toString()<<endl;
  }
  if (sendOnNBSocket(p.getSocket(), &msgh) < 0) {
    int err = errno;
    g_log<<Logger::Error<<"Error sending reply with sendmsg (socket="<<p.getSocket()<<", dest="<<p.d_remote.toStringWithPort()<<"): "<<stringerror(err)<<endl;
  }
}

bool UDPNameserver::receive(DNSPacket& packet, std::string& buffer)
{
  ComboAddress remote;
  extern StatBag S;
  ssize_t len=-1;
  Utility::sock_t sock=-1;

  struct msghdr msgh;
  struct iovec iov;
  cmsgbuf_aligned cbuf;

  remote.sin6.sin6_family=AF_INET6; // make sure it is big enough
  fillMSGHdr(&msgh, &iov, &cbuf, sizeof(cbuf), &buffer.at(0), buffer.size(), &remote);
  
  int err;
  vector<struct pollfd> rfds= d_rfds;

  for(auto &pfd :  rfds) {
    pfd.events = POLLIN;
    pfd.revents = 0;
  }
    
  retry:;
  
  err = poll(&rfds[0], rfds.size(), -1);
  if(err < 0) {
    if(errno==EINTR)
      goto retry;
    unixDie("Unable to poll for new UDP events");
  }
    
  for(auto &pfd :  rfds) {
    if(pfd.revents & POLLIN) {
      sock=pfd.fd;        
      if((len=recvmsg(sock, &msgh, 0)) < 0 ) {
        if(errno != EAGAIN)
          g_log<<Logger::Error<<"recvfrom gave error, ignoring: "<<stringerror()<<endl;
        return false;
      }
      break;
    }
  }
  if(sock==-1)
    throw PDNSException("poll betrayed us! (should not happen)");
  
  DLOG(g_log<<"Received a packet " << len <<" bytes long from "<< remote.toString()<<endl);

  BOOST_STATIC_ASSERT(offsetof(sockaddr_in, sin_port) == offsetof(sockaddr_in6, sin6_port));

  if(remote.sin4.sin_port == 0) // would generate error on responding. sin4 also works for ipv6
    return false;
  
  packet.setSocket(sock);
  packet.setRemote(&remote);

  ComboAddress dest;
  if(HarvestDestinationAddress(&msgh, &dest)) {
//    cerr<<"Setting d_anyLocal to '"<<dest.toString()<<"'"<<endl;
    packet.d_anyLocal = dest;
  }            

  struct timeval recvtv;
  if(HarvestTimestamp(&msgh, &recvtv)) {
    packet.d_dt.setTimeval(recvtv);
  }
  else
    packet.d_dt.set(); // timing

  if (g_proxyProtocolACL.match(remote)) {
    ComboAddress psource, pdestination;
    bool proxyProto, tcp;
    std::vector<ProxyProtocolValue> ppvalues;

    buffer.resize(len);
    ssize_t used = parseProxyHeader(buffer, proxyProto, psource, pdestination, tcp, ppvalues);
    if (used <= 0 || (size_t) used > g_proxyProtocolMaximumSize || (len - used) > DNSPacket::s_udpTruncationThreshold) {
      S.inc("corrupt-packets");
      S.ringAccount("remotes-corrupt", packet.d_remote);
      return false;
    }
    buffer.erase(0, used);
    packet.d_inner_remote = psource;
    packet.d_tcp = tcp;
  }
  else {
    packet.d_inner_remote.reset();
  }

  if(packet.parse(&buffer.at(0), (size_t) len)<0) {
    S.inc("corrupt-packets");
    S.ringAccount("remotes-corrupt", packet.getInnerRemote());

    return false; // unable to parse
  }
  
  return true;
}

1	/*
2	* This file is part of PowerDNS or dnsdist.
3	* Copyright -- PowerDNS.COM B.V. and its contributors
4	*
5	* This program is free software; you can redistribute it and/or modify
6	* it under the terms of version 2 of the GNU General Public License as
7	* published by the Free Software Foundation.
8	*
9	* In addition, for the avoidance of any doubt, permission is granted to
10	* link this program with OpenSSL and to (re)distribute the binaries
11	* produced as the result of such linking.
12	*
13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.
17	*
18	* You should have received a copy of the GNU General Public License
19	* along with this program; if not, write to the Free Software
20	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21	*/
22	#ifdef HAVE_CONFIG_H
23	#include "config.h"
24	#endif
25	#include "utility.hh"
26	#include <cstdio>
27	#include <cstring>
28	#include <cstdlib>
29	#include <cerrno>
30	#include <iostream>
31	#include <string>
32	#include <sys/types.h>
33	#include "responsestats.hh"
34
35	#include "auth-main.hh"
36	#include "dns.hh"
37	#include "dnsbackend.hh"
38	#include "dnspacket.hh"
39	#include "nameserver.hh"
40	#include "distributor.hh"
41	#include "logger.hh"
42	#include "arguments.hh"
43	#include "statbag.hh"
44	#include "proxy-protocol.hh"
45
46	#include "namespaces.hh"
47
48	extern StatBag S;
49
50	/** \mainpage
51	PowerDNS is a very versatile nameserver that can answer questions from different backends. To implement your
52	own backend, see the documentation for the DNSBackend class.
53
54	\section copyright Copyright and License
55	PowerDNS is (C) 2001-2008 PowerDNS.COM BV. It is distributed according to the terms of the General Public License version 2.
56
57	\section overview High level overview
58
59	The Distributor contains a configurable number of PacketHandler instances, each in its own thread, for connection pooling.
60	PacketHandler instances are recycled of they let escape an PDNSException.
61
62	The PacketHandler implements the RFC1034 algorithm and converts question packets into DNSBackend queries.
63
64	A DNSBackend is an entity that returns DNSResourceRecord objects in return to explicit questions for domains with a specified QType
65
66	PowerDNS uses the UeberBackend, which hosts DNSBackends. By default it has no DNSBackends within itself, those are loaded
67	by setting --load=<list of backends>. This way DNSBackend implementations can be kept completely separate, but most aren't.
68
69	If one or more DNSBackends are loaded, the UeberBackend fields the queries to all of them until one answers.
70
71	\section TCP TCP Operations
72
73	The TCP operation runs within a single thread called tcpreceiver(), that also queries the PacketHandler.
74
75	\section Cache Caching
76
77	On its own, this setup is not suitable for high performance operations. A single DNS query can turn into many DNSBackend questions,
78	each taking many milliseconds to complete. This is why the qthread() first checks the PacketCache to see if an answer is known to a packet
79	asking this question. If so, the entire Distributor is shunted, and the answer is sent back directly, within a few microseconds.
80
81	\section misc Miscellaneous
82	Configuration details are available via the ArgvMap instance arg. Statistics are created by making calls to the StatBag object called S.
83	These statistics are made available via the UeberBackend on the same socket that is used for dynamic module commands.
84
85	\section Main Main
86	The main() of PowerDNS can be found in auth-main.cc - start reading there for further insights into the operation of the nameserver
87	*/
88
89	vector<ComboAddress> g_localaddresses; // not static, our unit tests need to poke this
90
91	void UDPNameserver::bindAddresses()
92	{	96✔
93	vector<string>locals;	96✔
94	stringtok(locals,::arg()["local-address"]," ,");	96✔
95
96	int one = 1;	96✔
97
98	if(locals.empty())	96!
99	throw PDNSException("No local address specified");	×
100
101	int s;	96✔
102	// for(vector<string>::const_iterator i=locals.begin();i!=locals.end();++i) {
103	for (const auto &local : locals) {	127✔
104	ComboAddress locala(local, ::arg().asNum("local-port"));	127✔
105
106	s = socket(locala.sin4.sin_family, SOCK_DGRAM, 0);	127✔
107
108	if(s < 0) {	127!
109	if(errno == EAFNOSUPPORT) {	×
110	g_log<<Logger::Error<<"Binding "<<locala.toStringWithPort()<<": Address Family is not supported - skipping bind" << endl;	×
111	return;	×
112	}	×
113	throw PDNSException("Unable to acquire a UDP socket: "+stringerror());	×
114	}	×
115
116	setCloseOnExec(s);	127✔
117	if(!setNonBlocking(s))	127!
118	throw PDNSException("Unable to set UDP socket " + locala.toStringWithPort() + " to non-blocking: "+stringerror());	×
119
120	if(IsAnyAddress(locala)) {	127✔
121	(void)setsockopt(s, IPPROTO_IP, GEN_IP_PKTINFO, &one, sizeof(one));	58✔
122	if (locala.isIPv6()) {	58✔
123	(void)setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &one, sizeof(one)); // if this fails, we report an error in tcpreceiver too	29✔
124	#ifdef IPV6_RECVPKTINFO	29✔
125	(void)setsockopt(s, IPPROTO_IPV6, IPV6_RECVPKTINFO, &one, sizeof(one));	29✔
126	#endif	29✔
127	}	29✔
128	}	58✔
129
130	if (!setSocketTimestamps(s))	127!
131	g_log<<Logger::Warning<<"Unable to enable timestamp reporting for socket "<<locala.toStringWithPort()<<endl;	×
132
133	try {	127✔
134	setSocketIgnorePMTU(s, locala.sin4.sin_family);	127✔
135	}	127✔
136	catch(const std::exception& e) {	127✔
137	g_log<<Logger::Warning<<"Failed to set IP_MTU_DISCOVER on UDP server socket: "<<e.what()<<endl;	×
138	}	×
139
140	if (d_can_reuseport) {	127!
141	if (!setReusePort(s)) {	×
142	d_can_reuseport = false;	×
143	}	×
144	}	×
145
146	if( ::arg().mustDo("non-local-bind") )	127!
147	Utility::setBindAny(locala.sin4.sin_family, s);	×
148
149	if( !d_additional_socket )	127!
150	g_localaddresses.push_back(locala);	127✔
151
152	if(::bind(s, (sockaddr*)&locala, locala.getSocklen()) < 0) {	127!
153	int err = errno;	×
154	close(s);	×
155	if (err == EADDRNOTAVAIL && !::arg().mustDo("local-address-nonexist-fail")) {	×
156	g_log<<Logger::Error<<"Address " << locala << " does not exist on this server - skipping UDP bind" << endl;	×
157	continue;	×
158	} else {	×
159	g_log<<Logger::Error<<"Unable to bind UDP socket to '"+locala.toStringWithPort()+"': "<<stringerror(err)<<endl;	×
160	throw PDNSException("Unable to bind to UDP socket");	×
161	}	×
162	}	×
163	d_sockets.push_back(s);	127✔
164	struct pollfd pfd;	127✔
165	pfd.fd = s;	127✔
166	pfd.events = POLLIN;	127✔
167	pfd.revents = 0;	127✔
168	d_rfds.push_back(pfd);	127✔
169	g_log<<Logger::Error<<"UDP server bound to "<<locala.toStringWithPort()<<endl;	127✔
170	}	127✔
171	}	96✔
172
173	bool AddressIsUs(const ComboAddress& remote)
174	{	26✔
175	for(const ComboAddress& us : g_localaddresses) {	26✔
176	if(remote == us)	26✔
177	return true;	7✔
178	if(IsAnyAddress(us)) {	19✔
179	int s = socket(remote.sin4.sin_family, SOCK_DGRAM, 0);	6✔
180	if(s < 0)	6!
181	continue;	×
182
183	if(connect(s, (struct sockaddr*)&remote, remote.getSocklen()) < 0) {	6!
184	close(s);	×
185	continue;	×
186	}	×
187
188	ComboAddress actualLocal;	6✔
189	actualLocal.sin4.sin_family = remote.sin4.sin_family;	6✔
190	socklen_t socklen = actualLocal.getSocklen();	6✔
191
192	if(getsockname(s, (struct sockaddr*) &actualLocal, &socklen) < 0) {	6!
193	close(s);	×
194	continue;	×
195	}	×
196	close(s);	6✔
197	actualLocal.sin4.sin_port = us.sin4.sin_port;	6✔
198	if(actualLocal == remote)	6✔
199	return true;	3✔
200	}	6✔
201	}	19✔
202	return false;	16✔
203	}	26✔
204
205	UDPNameserver::UDPNameserver( bool additional_socket )
206	{	96✔
207	d_can_reuseport = ::arg().mustDo("reuseport");	96✔
208	// Are we the main socket (false) or a rebinding using SO_REUSEPORT ?
209	d_additional_socket = additional_socket;	96✔
210
211	if(::arg()["local-address"].empty())	96!
212	g_log<<Logger::Critical<<"PDNS is deaf and mute! Not listening on any interfaces"<<endl;	×
213
214	bindAddresses();	96✔
215	}	96✔
216
217	void UDPNameserver::send(DNSPacket& p)
218	{	92,677✔
219	const string& buffer=p.getString();	92,677✔
220	g_rs.submitResponse(p, true);	92,677✔
221
222	struct msghdr msgh;	92,677✔
223	struct iovec iov;	92,677✔
224	cmsgbuf_aligned cbuf;	92,677✔
225
226	fillMSGHdr(&msgh, &iov, &cbuf, 0, (char*)buffer.c_str(), buffer.length(), &p.d_remote);	92,677✔
227
228	msgh.msg_control=nullptr;	92,677✔
229	if(p.d_anyLocal) {	92,677✔
230	addCMsgSrcAddr(&msgh, &cbuf, p.d_anyLocal.get_ptr(), 0);	25,490✔
231	}	25,490✔
232	DLOG(g_log<<Logger::Notice<<"Sending a packet to "<< p.getRemote() <<" ("<< buffer.length()<<" octets)"<<endl);	92,677✔
233	if(buffer.length() > p.getMaxReplyLen()) {	92,677!
234	g_log<<Logger::Error<<"Weird, trying to send a message that needs truncation, "<< buffer.length()<<" > "<<p.getMaxReplyLen()<<". Question was for "<<p.qdomain<<"\|"<<p.qtype.toString()<<endl;	×
235	}	×
236	if (sendOnNBSocket(p.getSocket(), &msgh) < 0) {	92,677!
NEW 237	int err = errno;	×
NEW 238	g_log<<Logger::Error<<"Error sending reply with sendmsg (socket="<<p.getSocket()<<", dest="<<p.d_remote.toStringWithPort()<<"): "<<stringerror(err)<<endl;	×
NEW 239	}	×
240	}	92,677✔
241
242	bool UDPNameserver::receive(DNSPacket& packet, std::string& buffer)
243	{	92,972✔
244	ComboAddress remote;	92,972✔
245	extern StatBag S;	92,972✔
246	ssize_t len=-1;	92,972✔
247	Utility::sock_t sock=-1;	92,972✔
248
249	struct msghdr msgh;	92,972✔
250	struct iovec iov;	92,972✔
251	cmsgbuf_aligned cbuf;	92,972✔
252
253	remote.sin6.sin6_family=AF_INET6; // make sure it is big enough	92,972✔
254	fillMSGHdr(&msgh, &iov, &cbuf, sizeof(cbuf), &buffer.at(0), buffer.size(), &remote);	92,972✔
255
256	int err;	92,972✔
257	vector<struct pollfd> rfds= d_rfds;	92,972✔
258
259	for(auto &pfd : rfds) {	118,516✔
260	pfd.events = POLLIN;	118,516✔
261	pfd.revents = 0;	118,516✔
262	}	118,516✔
263
264	retry:;	92,972✔
265
266	err = poll(&rfds[0], rfds.size(), -1);	92,972✔
267	if(err < 0) {	92,972!
268	if(errno==EINTR)	×
269	goto retry;	×
270	unixDie("Unable to poll for new UDP events");	×
271	}	×
272
273	for(auto &pfd : rfds) {	92,972✔
274	if(pfd.revents & POLLIN) {	92,879✔
275	sock=pfd.fd;	92,877✔
276	if((len=recvmsg(sock, &msgh, 0)) < 0 ) {	92,877!
277	if(errno != EAGAIN)	×
278	g_log<<Logger::Error<<"recvfrom gave error, ignoring: "<<stringerror()<<endl;	×
279	return false;	×
280	}	×
281	break;	92,877✔
282	}	92,877✔
283	}	92,879✔
284	if(sock==-1)	92,972!
285	throw PDNSException("poll betrayed us! (should not happen)");	×
286
287	DLOG(g_log<<"Received a packet " << len <<" bytes long from "<< remote.toString()<<endl);	92,972✔
288
289	BOOST_STATIC_ASSERT(offsetof(sockaddr_in, sin_port) == offsetof(sockaddr_in6, sin6_port));	92,972✔
290
291	if(remote.sin4.sin_port == 0) // would generate error on responding. sin4 also works for ipv6	92,972!
292	return false;	×
293
294	packet.setSocket(sock);	92,972✔
295	packet.setRemote(&remote);	92,972✔
296
297	ComboAddress dest;	92,972✔
298	if(HarvestDestinationAddress(&msgh, &dest)) {	92,972✔
299	// cerr<<"Setting d_anyLocal to '"<<dest.toString()<<"'"<<endl;
300	packet.d_anyLocal = dest;	25,490✔
301	}	25,490✔
302
303	struct timeval recvtv;	92,972✔
304	if(HarvestTimestamp(&msgh, &recvtv)) {	92,972✔
305	packet.d_dt.setTimeval(recvtv);	92,877✔
306	}	92,877✔
307	else	95✔
308	packet.d_dt.set(); // timing	95✔
309
310	if (g_proxyProtocolACL.match(remote)) {	92,972!
311	ComboAddress psource, pdestination;	×
312	bool proxyProto, tcp;	×
313	std::vector<ProxyProtocolValue> ppvalues;	×
314
315	buffer.resize(len);	×
316	ssize_t used = parseProxyHeader(buffer, proxyProto, psource, pdestination, tcp, ppvalues);	×
317	if (used <= 0 \|\| (size_t) used > g_proxyProtocolMaximumSize \|\| (len - used) > DNSPacket::s_udpTruncationThreshold) {	×
318	S.inc("corrupt-packets");	×
319	S.ringAccount("remotes-corrupt", packet.d_remote);	×
320	return false;	×
321	}	×
322	buffer.erase(0, used);	×
323	packet.d_inner_remote = psource;	×
324	packet.d_tcp = tcp;	×
325	}	×
326	else {	92,972✔
327	packet.d_inner_remote.reset();	92,972✔
328	}	92,972✔
329
330	if(packet.parse(&buffer.at(0), (size_t) len)<0) {	92,972!
331	S.inc("corrupt-packets");	×
332	S.ringAccount("remotes-corrupt", packet.getInnerRemote());	×
333
334	return false; // unable to parse	×
335	}	×
336
337	return true;	92,972✔
338	}	92,972✔

PowerDNS / pdns / 8282364669

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous