8277672099

Committed 14 Mar 2024 08:32AM UTC coverage: 86.091% (+0.1%) from 85.979%

Build # 8277672099

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #213 from gturi/feature/nca-alias-command

Feature/nca alias command

Run Details

221 of 316 branches covered (69.94%)

Branch coverage included in aggregate %.

598 of 661 new or added lines in 62 files covered. (90.47%)

1 existing line in 1 file now uncovered.

1116 of 1237 relevant lines covered (90.22%)

1211.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.38

/src/validator/positional-argument-validator.ts

import { PositionalArgument } from "../model/api/positional-argument";
import { PositionalArgumentType } from "../model/api/positional-argument-type";
import { DuplicatesValidator } from "./duplicates-validator";
import { EnumValidator } from "./enum-validator";
import { WhiteSpaceValidator } from "./white-space-validator";

export class PositionalArgumentValidator {

  static validate(ncaCommandName: string, positionalArguments?: PositionalArgument[]) {
    if (positionalArguments) {
      this.checkNamesFormat(ncaCommandName, positionalArguments);
      this.checkDuplicateNames(ncaCommandName, positionalArguments);
      this.checkMultipleListPositionalArguments(ncaCommandName, positionalArguments);
      this.checkPositionalArgumentType(ncaCommandName, positionalArguments);
    }
  }

  private static checkNamesFormat(
    ncaCommandName: string, positionalArguments: PositionalArgument[]
  ) {
    const positionalArgumentNames = this.getPositionalArgumentNames(positionalArguments);
    WhiteSpaceValidator.validate(positionalArgumentNames, elementsWithWhitespaces => {
      return `${ncaCommandName}: positional argument names cannot contain whitespaces ` +
        `[${elementsWithWhitespaces}]`;
    });
  }

  private static checkDuplicateNames(
    ncaCommandName: string, positionalArguments: PositionalArgument[]
  ) {
    const positionalArgumentNames = this.getPositionalArgumentNames(positionalArguments);
    const getErrorMessage = (duplicates: string[]) => {
      return `${ncaCommandName}: multiple positional arguments has been defined ` +
        `with the same name: [${duplicates}]`;
    };

    DuplicatesValidator.validate(positionalArgumentNames, getErrorMessage);
  }

  private static checkMultipleListPositionalArguments(
    ncaCommandName: string, positionalArguments: PositionalArgument[]
  ) {
    const listPositionalArgumentNames = positionalArguments
      .filter(positionalArgument => PositionalArgumentType.isListType(positionalArgument.type))
      .map(positionalArgument => positionalArgument.name);

    if (listPositionalArgumentNames.length > 1) {
      throw new Error(
        `${ncaCommandName}: only one list type positional argument is allowed, ` +
        `found: [${listPositionalArgumentNames}]`
      );
    }
  }

  private static getPositionalArgumentNames(positionalArguments: PositionalArgument[]): string[] {
    return positionalArguments.map(positionalArgument => positionalArgument.name);
  }

  private static checkPositionalArgumentType(
    ncaCommandName: string, positionalArguments: PositionalArgument[]
  ) {
    const getErrorMessage = (positionalArgument: PositionalArgument) => {
      return `Nca command '${ncaCommandName}' positionalArgument '${positionalArgument.name}' ` +
        `type '${positionalArgument.type}' is not valid: ` +
        `supported values are ${Object.keys(PositionalArgumentType)}`;
    }
    positionalArguments.forEach(positionalArgument => {
      EnumValidator.validate(
        PositionalArgumentType, positionalArgument.type, () => getErrorMessage(positionalArgument)
      );
    });
  }
}

1	import { PositionalArgument } from "../model/api/positional-argument";
2	import { PositionalArgumentType } from "../model/api/positional-argument-type";	162✔
3	import { DuplicatesValidator } from "./duplicates-validator";	162✔
4	import { EnumValidator } from "./enum-validator";	162✔
5	import { WhiteSpaceValidator } from "./white-space-validator";	162✔
6
7	export class PositionalArgumentValidator {	162✔
8
9	static validate(ncaCommandName: string, positionalArguments?: PositionalArgument[]) {
10	if (positionalArguments) {	4,349!
11	this.checkNamesFormat(ncaCommandName, positionalArguments);	4,349✔
12	this.checkDuplicateNames(ncaCommandName, positionalArguments);	4,349✔
13	this.checkMultipleListPositionalArguments(ncaCommandName, positionalArguments);	4,349✔
14	this.checkPositionalArgumentType(ncaCommandName, positionalArguments);	4,349✔
15	}
16	}
17
18	private static checkNamesFormat(
19	ncaCommandName: string, positionalArguments: PositionalArgument[]
20	) {
21	const positionalArgumentNames = this.getPositionalArgumentNames(positionalArguments);	4,349✔
22	WhiteSpaceValidator.validate(positionalArgumentNames, elementsWithWhitespaces => {	4,349✔
NEW 23	return `${ncaCommandName}: positional argument names cannot contain whitespaces ` +	×
24	`[${elementsWithWhitespaces}]`;
25	});
26	}
27
28	private static checkDuplicateNames(
29	ncaCommandName: string, positionalArguments: PositionalArgument[]
30	) {
31	const positionalArgumentNames = this.getPositionalArgumentNames(positionalArguments);	4,349✔
32	const getErrorMessage = (duplicates: string[]) => {	4,349✔
NEW 33	return `${ncaCommandName}: multiple positional arguments has been defined ` +	×
34	`with the same name: [${duplicates}]`;
35	};
36
37	DuplicatesValidator.validate(positionalArgumentNames, getErrorMessage);	4,349✔
38	}
39
40	private static checkMultipleListPositionalArguments(
41	ncaCommandName: string, positionalArguments: PositionalArgument[]
42	) {
43	const listPositionalArgumentNames = positionalArguments	4,349✔
44	.filter(positionalArgument => PositionalArgumentType.isListType(positionalArgument.type))	6,119✔
45	.map(positionalArgument => positionalArgument.name);	2,254✔
46
47	if (listPositionalArgumentNames.length > 1) {	4,349!
48	throw new Error(	×
49	`${ncaCommandName}: only one list type positional argument is allowed, ` +
50	`found: [${listPositionalArgumentNames}]`
51	);
52	}
53	}
54
55	private static getPositionalArgumentNames(positionalArguments: PositionalArgument[]): string[] {
56	return positionalArguments.map(positionalArgument => positionalArgument.name);	12,238✔
57	}
58
59	private static checkPositionalArgumentType(
60	ncaCommandName: string, positionalArguments: PositionalArgument[]
61	) {
62	const getErrorMessage = (positionalArgument: PositionalArgument) => {	4,349✔
63	return `Nca command '${ncaCommandName}' positionalArgument '${positionalArgument.name}' ` +	1✔
64	`type '${positionalArgument.type}' is not valid: ` +
65	`supported values are ${Object.keys(PositionalArgumentType)}`;
66	}
67	positionalArguments.forEach(positionalArgument => {	4,349✔
68	EnumValidator.validate(	6,119✔
69	PositionalArgumentType, positionalArgument.type, () => getErrorMessage(positionalArgument)	1✔
70	);
71	});
72	}
73	}

gturi / nca / 8277672099

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous